| Message ID | 20180529100421.31022-1-ulf.hansson@linaro.org |
|---|---|
| Headers | show |
| Series | PM / Domains: Add support for multi PM domains per device | expand |
Hi Ulf, On 29/05/18 11:04, Ulf Hansson wrote: > The existing dev_pm_domain_attach() function, allows a single PM domain to > be attached per device. To be able to support devices that are partitioned > across multiple PM domains, let's introduce a new interface, > dev_pm_domain_attach_by_id(). > > The dev_pm_domain_attach_by_id() returns a new allocated struct device with > the corresponding attached PM domain. This enables for example a driver to > operate on the new device from a power management point of view. The driver > may then also benefit from using the received device, to set up so called > device-links towards its original device. Depending on the situation, these > links may then be dynamically changed. I have given this series a go with Tegra updating the XHCI driver to make use of these new APIs. Good news it does appear to work fine for Tegra, however, initially when looking at the device_link_add() API ... /** * device_link_add - Create a link between two devices. * @consumer: Consumer end of the link. * @supplier: Supplier end of the link. * @flags: Link flags. ... I had assumed that the 'consumer' device would be the actual XHCI device (in the case of Tegra) and the 'supplier' device would be the new genpd device. However, this did not work and I got the following WARN on boot ... [ 2.050929] ---[ end trace eff0b5265e530c92 ]--- [ 2.055567] WARNING: CPU: 2 PID: 1 at drivers/base/core.c:446 device_links_driver_bound+0xc0/0xd0 [ 2.064422] Modules linked in: [ 2.067471] CPU: 2 PID: 1 Comm: swapper/0 Tainted: G W 4.17.0-rc7-next-20180529-00011-g4faf0dc0ebf3-dirty #32 [ 2.078667] Hardware name: Google Pixel C (DT) [ 2.083101] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 2.087881] pc : device_links_driver_bound+0xc0/0xd0 [ 2.092832] lr : device_links_driver_bound+0x20/0xd0 Switching the Tegra XHCI device to be the 'supplier' and genpd device to be the 'consumer' does work, but is this correct? Seems to be opposite to what I expected. Maybe I am missing something? > The new interface is typically called by drivers during their probe phase, > in case they manages devices which uses multiple PM domains. If that is the > case, the driver also becomes responsible of managing the detaching of the > PM domains, which typically should be done at the remove phase. Detaching > is done by calling the existing dev_pm_domain_detach() function and for > each of the received devices from dev_pm_domain_attach_by_id(). > > Note, currently its only genpd that supports multiple PM domains per > device, but dev_pm_domain_attach_by_id() can easily by extended to cover > other PM domain types, if/when needed. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes in v2: > - Fixed comments from Jon. Clarified function descriptions/changelog and > return ERR_PTR(-EEXIST) in case a PM domain is already assigned. > - Fix build error when CONFIG_PM is unset. > > --- > drivers/base/power/common.c | 43 ++++++++++++++++++++++++++++++++++--- > include/linux/pm_domain.h | 7 ++++++ > 2 files changed, 47 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c > index 7ae62b6355b8..5e5ea0c239de 100644 > --- a/drivers/base/power/common.c > +++ b/drivers/base/power/common.c > @@ -116,14 +116,51 @@ int dev_pm_domain_attach(struct device *dev, bool power_on) > } > EXPORT_SYMBOL_GPL(dev_pm_domain_attach); > > +/** > + * dev_pm_domain_attach_by_id - Attach a device to one of its PM domains. > + * @dev: Device to attach. Nit ... I still don't think this is the device we are attaching to, but the device the PM domains are associated with. IOW we are using this device to lookup the PM domains. > + * @index: The index of the PM domain. > + * > + * As @dev may only be attached to a single PM domain, the backend PM domain > + * provider creates a virtual device to attach instead. If attachment succeeds, > + * the ->detach() callback in the struct dev_pm_domain are assigned by the > + * corresponding backend attach function, as to deal with detaching of the > + * created virtual device. > + * > + * This function should typically be invoked by a driver during the probe phase, > + * in case its device requires power management through multiple PM domains. The > + * driver may benefit from using the received device, to configure device-links > + * towards its original device. Depending on the use-case and if needed, the > + * links may be dynamically changed by the driver, which allows it to control > + * the power to the PM domains independently from each other. > + * > + * Callers must ensure proper synchronization of this function with power > + * management callbacks. > + * > + * Returns the virtual created device when successfully attached to its PM > + * domain, NULL in case @dev don't need a PM domain, else an ERR_PTR(). > + * Note that, to detach the returned virtual device, the driver shall call > + * dev_pm_domain_detach() on it, typically during the remove phase. > + */ > +struct device *dev_pm_domain_attach_by_id(struct device *dev, > + unsigned int index) > +{ > + if (dev->pm_domain) > + return ERR_PTR(-EEXIST); > + > + return genpd_dev_pm_attach_by_id(dev, index); > +} > +EXPORT_SYMBOL_GPL(dev_pm_domain_attach_by_id); > + > /** > * dev_pm_domain_detach - Detach a device from its PM domain. > * @dev: Device to detach. > * @power_off: Used to indicate whether we should power off the device. > * > - * This functions will reverse the actions from dev_pm_domain_attach() and thus > - * try to detach the @dev from its PM domain. Typically it should be invoked > - * from subsystem level code during the remove phase. > + * This functions will reverse the actions from dev_pm_domain_attach() and > + * dev_pm_domain_attach_by_id(), thus it detaches @dev from its PM domain. > + * Typically it should be invoked during the remove phase, either from > + * subsystem level code or from drivers. > * > * Callers must ensure proper synchronization of this function with power > * management callbacks. > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h > index 82458e8e2e01..9206a4fef9ac 100644 > --- a/include/linux/pm_domain.h > +++ b/include/linux/pm_domain.h > @@ -299,6 +299,8 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) > > #ifdef CONFIG_PM > int dev_pm_domain_attach(struct device *dev, bool power_on); > +struct device *dev_pm_domain_attach_by_id(struct device *dev, > + unsigned int index); > void dev_pm_domain_detach(struct device *dev, bool power_off); > void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); > #else > @@ -306,6 +308,11 @@ static inline int dev_pm_domain_attach(struct device *dev, bool power_on) > { > return 0; > } > +static inline struct device *dev_pm_domain_attach_by_id(struct device *dev, > + unsigned int index) > +{ > + return NULL; > +} > static inline void dev_pm_domain_detach(struct device *dev, bool power_off) {} > static inline void dev_pm_domain_set(struct device *dev, > struct dev_pm_domain *pd) {} > My only other comments on this series are ... 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and that the DT binding has a 'power-domain-names' property. 2. I am wondering if there could be value in having a dev_pm_domain_attach_link_all() helper which would attach and link all PM domains at once. Cheers Jon
On Tue, May 29, 2018 at 12:04 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > Changes in v2: > - Addressed comments from Geert around DT doc. > - Addressed comments from Jon around clarification of how to use this > and changes to returned error codes. > - Fixed build error in case CONFIG_PM was unset. > > There are devices that are partitioned across multiple PM domains. Currently > these can't be supported well by the available PM infrastructures we have in > the kernel. This series is an attempt to address this. > > The interesting parts happens from patch 5 an onwards, including a minor DT > update to the existing power-domain bindings, the 4 earlier are just trivial > clean-ups of some related code in genpd, which I happened to stumble over. > > Some additional background: > > One existing case where devices are partitioned across multiple PM domains, is > the Nvida Tegra 124/210 X-USB subsystem. A while ago Jon Hunter (Nvidia) sent a > series, trying to address these issues, however this is a new approach, while > it re-uses the same concepts from DT point of view. > > The Tegra 124/210 X-USB subsystem contains of a host controller and a device > controller. Each controller have its own independent PM domain, but are being > partitioned across another shared PM domain for the USB super-speed logic. > > Currently to make the drivers work, either the related PM domains needs to stay > powered on always or the PM domain topology needs to be in-correctly modelled > through sub-domains. In both cases PM domains may be powered on while they > don't need to be, so in the end this means - wasting power -. > > As stated above, this series intends to address these problem from a PM > infrastructure point of view. More details are available in each changelog. > > It should be noted that this series has been tested on HW, however only by using > a home-cooked test PM domain driver for genpd and together with a test driver. > This allowed me to play with PM domain (genpd), runtime PM and device links. > > Any further deployment for real use cases are greatly appreciated. I am happy to > to help, if needed! > > Kind regards > Ulf Hansson > > > Ulf Hansson (9): > PM / Domains: Drop extern declarations of functions in pm_domain.h > PM / Domains: Drop __pm_genpd_add_device() > PM / Domains: Drop genpd as in-param for pm_genpd_remove_device() > PM / Domains: Drop unused parameter in genpd_allocate_dev_data() > PM / Domains: dt: Allow power-domain property to be a list of > specifiers > PM / Domains: Don't attach devices in genpd with multi PM domains > PM / Domains: Split genpd_dev_pm_attach() > PM / Domains: Add support for multi PM domains per device to genpd > PM / Domains: Add dev_pm_domain_attach_by_id() to manage multi PM > domains > > .../bindings/power/power_domain.txt | 19 ++- > drivers/base/power/common.c | 39 ++++- > drivers/base/power/domain.c | 155 ++++++++++++++---- > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- > include/linux/pm_domain.h | 79 ++++----- > 5 files changed, 216 insertions(+), 78 deletions(-) I can take patches [1-4/9] from this series for 4.18. I need an ACK from Rob on the bindings change. The rest of the series doesn't seem to be ready yet. Thanks, Rafael
On 30 May 2018 at 11:19, Jon Hunter <jonathanh@nvidia.com> wrote: > Hi Ulf, > > On 29/05/18 11:04, Ulf Hansson wrote: >> The existing dev_pm_domain_attach() function, allows a single PM domain to >> be attached per device. To be able to support devices that are partitioned >> across multiple PM domains, let's introduce a new interface, >> dev_pm_domain_attach_by_id(). >> >> The dev_pm_domain_attach_by_id() returns a new allocated struct device with >> the corresponding attached PM domain. This enables for example a driver to >> operate on the new device from a power management point of view. The driver >> may then also benefit from using the received device, to set up so called >> device-links towards its original device. Depending on the situation, these >> links may then be dynamically changed. > > I have given this series a go with Tegra updating the XHCI driver to make > use of these new APIs. Good news it does appear to work fine for Tegra, > however, initially when looking at the device_link_add() API ... > > /** > * device_link_add - Create a link between two devices. > * @consumer: Consumer end of the link. > * @supplier: Supplier end of the link. > * @flags: Link flags. > > ... I had assumed that the 'consumer' device would be the actual XHCI > device (in the case of Tegra) and the 'supplier' device would be the new > genpd device. However, this did not work and I got the following WARN on > boot ... > > [ 2.050929] ---[ end trace eff0b5265e530c92 ]--- > [ 2.055567] WARNING: CPU: 2 PID: 1 at drivers/base/core.c:446 device_links_driver_bound+0xc0/0xd0 > [ 2.064422] Modules linked in: > [ 2.067471] CPU: 2 PID: 1 Comm: swapper/0 Tainted: G W 4.17.0-rc7-next-20180529-00011-g4faf0dc0ebf3-dirty #32 > [ 2.078667] Hardware name: Google Pixel C (DT) > [ 2.083101] pstate: 80000005 (Nzcv daif -PAN -UAO) > [ 2.087881] pc : device_links_driver_bound+0xc0/0xd0 > [ 2.092832] lr : device_links_driver_bound+0x20/0xd0 > > Switching the Tegra XHCI device to be the 'supplier' and genpd device to > be the 'consumer' does work, but is this correct? Seems to be opposite to It shall be the opposite. The Tegra XHCI device shall be the consumer. > what I expected. Maybe I am missing something? The problem you get is because the device returned from dev_pm_domain_attach_by_id(), let's call it genpd_dev, doesn't have the a driver. You need to use a couple of device links flag, something like this: link = device_link_add(dev, genpd_dev, DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE); Moreover, you also need these commits, depending if you are running on something else than Rafael's tree. a0504aecba76 PM / runtime: Drop usage count for suppliers at device link removal 1e8378619841 PM / runtime: Fixup reference counting of device link suppliers at probe > >> The new interface is typically called by drivers during their probe phase, >> in case they manages devices which uses multiple PM domains. If that is the >> case, the driver also becomes responsible of managing the detaching of the >> PM domains, which typically should be done at the remove phase. Detaching >> is done by calling the existing dev_pm_domain_detach() function and for >> each of the received devices from dev_pm_domain_attach_by_id(). >> >> Note, currently its only genpd that supports multiple PM domains per >> device, but dev_pm_domain_attach_by_id() can easily by extended to cover >> other PM domain types, if/when needed. >> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> --- >> >> Changes in v2: >> - Fixed comments from Jon. Clarified function descriptions/changelog and >> return ERR_PTR(-EEXIST) in case a PM domain is already assigned. >> - Fix build error when CONFIG_PM is unset. >> >> --- >> drivers/base/power/common.c | 43 ++++++++++++++++++++++++++++++++++--- >> include/linux/pm_domain.h | 7 ++++++ >> 2 files changed, 47 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c >> index 7ae62b6355b8..5e5ea0c239de 100644 >> --- a/drivers/base/power/common.c >> +++ b/drivers/base/power/common.c >> @@ -116,14 +116,51 @@ int dev_pm_domain_attach(struct device *dev, bool power_on) >> } >> EXPORT_SYMBOL_GPL(dev_pm_domain_attach); >> >> +/** >> + * dev_pm_domain_attach_by_id - Attach a device to one of its PM domains. >> + * @dev: Device to attach. > > Nit ... I still don't think this is the device we are attaching to, but the > device the PM domains are associated with. IOW we are using this device to > lookup the PM domains. Right. I forgot to update that part of the description. What about: dev_pm_domain_attach_by_id - Associate a device with one of its PM domains. @dev: The device used to lookup the PM domain. > >> + * @index: The index of the PM domain. >> + * >> + * As @dev may only be attached to a single PM domain, the backend PM domain >> + * provider creates a virtual device to attach instead. If attachment succeeds, >> + * the ->detach() callback in the struct dev_pm_domain are assigned by the >> + * corresponding backend attach function, as to deal with detaching of the >> + * created virtual device. >> + * >> + * This function should typically be invoked by a driver during the probe phase, >> + * in case its device requires power management through multiple PM domains. The >> + * driver may benefit from using the received device, to configure device-links >> + * towards its original device. Depending on the use-case and if needed, the >> + * links may be dynamically changed by the driver, which allows it to control >> + * the power to the PM domains independently from each other. >> + * >> + * Callers must ensure proper synchronization of this function with power >> + * management callbacks. >> + * >> + * Returns the virtual created device when successfully attached to its PM >> + * domain, NULL in case @dev don't need a PM domain, else an ERR_PTR(). >> + * Note that, to detach the returned virtual device, the driver shall call >> + * dev_pm_domain_detach() on it, typically during the remove phase. >> + */ >> +struct device *dev_pm_domain_attach_by_id(struct device *dev, >> + unsigned int index) >> +{ >> + if (dev->pm_domain) >> + return ERR_PTR(-EEXIST); >> + >> + return genpd_dev_pm_attach_by_id(dev, index); >> +} >> +EXPORT_SYMBOL_GPL(dev_pm_domain_attach_by_id); >> + >> /** >> * dev_pm_domain_detach - Detach a device from its PM domain. >> * @dev: Device to detach. >> * @power_off: Used to indicate whether we should power off the device. >> * >> - * This functions will reverse the actions from dev_pm_domain_attach() and thus >> - * try to detach the @dev from its PM domain. Typically it should be invoked >> - * from subsystem level code during the remove phase. >> + * This functions will reverse the actions from dev_pm_domain_attach() and >> + * dev_pm_domain_attach_by_id(), thus it detaches @dev from its PM domain. >> + * Typically it should be invoked during the remove phase, either from >> + * subsystem level code or from drivers. >> * >> * Callers must ensure proper synchronization of this function with power >> * management callbacks. >> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h >> index 82458e8e2e01..9206a4fef9ac 100644 >> --- a/include/linux/pm_domain.h >> +++ b/include/linux/pm_domain.h >> @@ -299,6 +299,8 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) >> >> #ifdef CONFIG_PM >> int dev_pm_domain_attach(struct device *dev, bool power_on); >> +struct device *dev_pm_domain_attach_by_id(struct device *dev, >> + unsigned int index); >> void dev_pm_domain_detach(struct device *dev, bool power_off); >> void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); >> #else >> @@ -306,6 +308,11 @@ static inline int dev_pm_domain_attach(struct device *dev, bool power_on) >> { >> return 0; >> } >> +static inline struct device *dev_pm_domain_attach_by_id(struct device *dev, >> + unsigned int index) >> +{ >> + return NULL; >> +} >> static inline void dev_pm_domain_detach(struct device *dev, bool power_off) {} >> static inline void dev_pm_domain_set(struct device *dev, >> struct dev_pm_domain *pd) {} >> > > My only other comments on this series are ... > > 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and > that the DT binding has a 'power-domain-names' property. I think it makes sense, but my plan was to do that as second step on top. Are you okay with that as well? > 2. I am wondering if there could be value in having a > dev_pm_domain_attach_link_all() helper which would attach and link all > PM domains at once. Perhaps it can be useful, yes! However, maybe we can postpone that to after this series. I want to keep the series as simple as possible, then we can build upon it. Kind regards Uffe
On 30 May 2018 at 11:30, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Tue, May 29, 2018 at 12:04 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> Changes in v2: >> - Addressed comments from Geert around DT doc. >> - Addressed comments from Jon around clarification of how to use this >> and changes to returned error codes. >> - Fixed build error in case CONFIG_PM was unset. >> >> There are devices that are partitioned across multiple PM domains. Currently >> these can't be supported well by the available PM infrastructures we have in >> the kernel. This series is an attempt to address this. >> >> The interesting parts happens from patch 5 an onwards, including a minor DT >> update to the existing power-domain bindings, the 4 earlier are just trivial >> clean-ups of some related code in genpd, which I happened to stumble over. >> >> Some additional background: >> >> One existing case where devices are partitioned across multiple PM domains, is >> the Nvida Tegra 124/210 X-USB subsystem. A while ago Jon Hunter (Nvidia) sent a >> series, trying to address these issues, however this is a new approach, while >> it re-uses the same concepts from DT point of view. >> >> The Tegra 124/210 X-USB subsystem contains of a host controller and a device >> controller. Each controller have its own independent PM domain, but are being >> partitioned across another shared PM domain for the USB super-speed logic. >> >> Currently to make the drivers work, either the related PM domains needs to stay >> powered on always or the PM domain topology needs to be in-correctly modelled >> through sub-domains. In both cases PM domains may be powered on while they >> don't need to be, so in the end this means - wasting power -. >> >> As stated above, this series intends to address these problem from a PM >> infrastructure point of view. More details are available in each changelog. >> >> It should be noted that this series has been tested on HW, however only by using >> a home-cooked test PM domain driver for genpd and together with a test driver. >> This allowed me to play with PM domain (genpd), runtime PM and device links. >> >> Any further deployment for real use cases are greatly appreciated. I am happy to >> to help, if needed! >> >> Kind regards >> Ulf Hansson >> >> >> Ulf Hansson (9): >> PM / Domains: Drop extern declarations of functions in pm_domain.h >> PM / Domains: Drop __pm_genpd_add_device() >> PM / Domains: Drop genpd as in-param for pm_genpd_remove_device() >> PM / Domains: Drop unused parameter in genpd_allocate_dev_data() >> PM / Domains: dt: Allow power-domain property to be a list of >> specifiers >> PM / Domains: Don't attach devices in genpd with multi PM domains >> PM / Domains: Split genpd_dev_pm_attach() >> PM / Domains: Add support for multi PM domains per device to genpd >> PM / Domains: Add dev_pm_domain_attach_by_id() to manage multi PM >> domains >> >> .../bindings/power/power_domain.txt | 19 ++- >> drivers/base/power/common.c | 39 ++++- >> drivers/base/power/domain.c | 155 ++++++++++++++---- >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- >> include/linux/pm_domain.h | 79 ++++----- >> 5 files changed, 216 insertions(+), 78 deletions(-) > > I can take patches [1-4/9] from this series for 4.18. Thanks! > > I need an ACK from Rob on the bindings change. Yes, of course! > > The rest of the series doesn't seem to be ready yet. It's getting reviewed and tested, so let's give it some more time. BTW, from an overall design point of view, you seems okay with it? Kind regards Uffe
On 30/05/18 12:31, Ulf Hansson wrote: > On 30 May 2018 at 11:19, Jon Hunter <jonathanh@nvidia.com> wrote: >> Hi Ulf, >> >> On 29/05/18 11:04, Ulf Hansson wrote: >>> The existing dev_pm_domain_attach() function, allows a single PM domain to >>> be attached per device. To be able to support devices that are partitioned >>> across multiple PM domains, let's introduce a new interface, >>> dev_pm_domain_attach_by_id(). >>> >>> The dev_pm_domain_attach_by_id() returns a new allocated struct device with >>> the corresponding attached PM domain. This enables for example a driver to >>> operate on the new device from a power management point of view. The driver >>> may then also benefit from using the received device, to set up so called >>> device-links towards its original device. Depending on the situation, these >>> links may then be dynamically changed. >> >> I have given this series a go with Tegra updating the XHCI driver to make >> use of these new APIs. Good news it does appear to work fine for Tegra, >> however, initially when looking at the device_link_add() API ... >> >> /** >> * device_link_add - Create a link between two devices. >> * @consumer: Consumer end of the link. >> * @supplier: Supplier end of the link. >> * @flags: Link flags. >> >> ... I had assumed that the 'consumer' device would be the actual XHCI >> device (in the case of Tegra) and the 'supplier' device would be the new >> genpd device. However, this did not work and I got the following WARN on >> boot ... >> >> [ 2.050929] ---[ end trace eff0b5265e530c92 ]--- >> [ 2.055567] WARNING: CPU: 2 PID: 1 at drivers/base/core.c:446 device_links_driver_bound+0xc0/0xd0 >> [ 2.064422] Modules linked in: >> [ 2.067471] CPU: 2 PID: 1 Comm: swapper/0 Tainted: G W 4.17.0-rc7-next-20180529-00011-g4faf0dc0ebf3-dirty #32 >> [ 2.078667] Hardware name: Google Pixel C (DT) >> [ 2.083101] pstate: 80000005 (Nzcv daif -PAN -UAO) >> [ 2.087881] pc : device_links_driver_bound+0xc0/0xd0 >> [ 2.092832] lr : device_links_driver_bound+0x20/0xd0 >> >> Switching the Tegra XHCI device to be the 'supplier' and genpd device to >> be the 'consumer' does work, but is this correct? Seems to be opposite to > > It shall be the opposite. The Tegra XHCI device shall be the consumer. > >> what I expected. Maybe I am missing something? > > The problem you get is because the device returned from > dev_pm_domain_attach_by_id(), let's call it genpd_dev, doesn't have > the a driver. > > You need to use a couple of device links flag, something like this: > > link = device_link_add(dev, genpd_dev, DL_FLAG_STATELESS | > DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE); Thanks, adding the DL_FLAG_STATELESS flag resolved the issue. I already added the DL_FLAG_PM_RUNTIME but I did not bother with the DL_FLAG_RPM_ACTIVE as from the description it appears that this will always keep it on? Seems to work fine without it. > Moreover, you also need these commits, depending if you are running on > something else than Rafael's tree. > > a0504aecba76 PM / runtime: Drop usage count for suppliers at device link removal > 1e8378619841 PM / runtime: Fixup reference counting of device link > suppliers at probe Yes these are currently in -next and so I have these. >> >>> The new interface is typically called by drivers during their probe phase, >>> in case they manages devices which uses multiple PM domains. If that is the >>> case, the driver also becomes responsible of managing the detaching of the >>> PM domains, which typically should be done at the remove phase. Detaching >>> is done by calling the existing dev_pm_domain_detach() function and for >>> each of the received devices from dev_pm_domain_attach_by_id(). >>> >>> Note, currently its only genpd that supports multiple PM domains per >>> device, but dev_pm_domain_attach_by_id() can easily by extended to cover >>> other PM domain types, if/when needed. >>> >>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >>> --- >>> >>> Changes in v2: >>> - Fixed comments from Jon. Clarified function descriptions/changelog and >>> return ERR_PTR(-EEXIST) in case a PM domain is already assigned. >>> - Fix build error when CONFIG_PM is unset. >>> >>> --- >>> drivers/base/power/common.c | 43 ++++++++++++++++++++++++++++++++++--- >>> include/linux/pm_domain.h | 7 ++++++ >>> 2 files changed, 47 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/base/power/common.c b/drivers/base/power/common.c >>> index 7ae62b6355b8..5e5ea0c239de 100644 >>> --- a/drivers/base/power/common.c >>> +++ b/drivers/base/power/common.c >>> @@ -116,14 +116,51 @@ int dev_pm_domain_attach(struct device *dev, bool power_on) >>> } >>> EXPORT_SYMBOL_GPL(dev_pm_domain_attach); >>> >>> +/** >>> + * dev_pm_domain_attach_by_id - Attach a device to one of its PM domains. >>> + * @dev: Device to attach. >> >> Nit ... I still don't think this is the device we are attaching to, but the >> device the PM domains are associated with. IOW we are using this device to >> lookup the PM domains. > > Right. I forgot to update that part of the description. > > What about: > > dev_pm_domain_attach_by_id - Associate a device with one of its PM domains. > @dev: The device used to lookup the PM domain. Perfect. >> >>> + * @index: The index of the PM domain. >>> + * >>> + * As @dev may only be attached to a single PM domain, the backend PM domain >>> + * provider creates a virtual device to attach instead. If attachment succeeds, >>> + * the ->detach() callback in the struct dev_pm_domain are assigned by the >>> + * corresponding backend attach function, as to deal with detaching of the >>> + * created virtual device. >>> + * >>> + * This function should typically be invoked by a driver during the probe phase, >>> + * in case its device requires power management through multiple PM domains. The >>> + * driver may benefit from using the received device, to configure device-links >>> + * towards its original device. Depending on the use-case and if needed, the >>> + * links may be dynamically changed by the driver, which allows it to control >>> + * the power to the PM domains independently from each other. >>> + * >>> + * Callers must ensure proper synchronization of this function with power >>> + * management callbacks. >>> + * >>> + * Returns the virtual created device when successfully attached to its PM >>> + * domain, NULL in case @dev don't need a PM domain, else an ERR_PTR(). >>> + * Note that, to detach the returned virtual device, the driver shall call >>> + * dev_pm_domain_detach() on it, typically during the remove phase. >>> + */ >>> +struct device *dev_pm_domain_attach_by_id(struct device *dev, >>> + unsigned int index) >>> +{ >>> + if (dev->pm_domain) >>> + return ERR_PTR(-EEXIST); >>> + >>> + return genpd_dev_pm_attach_by_id(dev, index); >>> +} >>> +EXPORT_SYMBOL_GPL(dev_pm_domain_attach_by_id); >>> + >>> /** >>> * dev_pm_domain_detach - Detach a device from its PM domain. >>> * @dev: Device to detach. >>> * @power_off: Used to indicate whether we should power off the device. >>> * >>> - * This functions will reverse the actions from dev_pm_domain_attach() and thus >>> - * try to detach the @dev from its PM domain. Typically it should be invoked >>> - * from subsystem level code during the remove phase. >>> + * This functions will reverse the actions from dev_pm_domain_attach() and >>> + * dev_pm_domain_attach_by_id(), thus it detaches @dev from its PM domain. >>> + * Typically it should be invoked during the remove phase, either from >>> + * subsystem level code or from drivers. >>> * >>> * Callers must ensure proper synchronization of this function with power >>> * management callbacks. >>> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h >>> index 82458e8e2e01..9206a4fef9ac 100644 >>> --- a/include/linux/pm_domain.h >>> +++ b/include/linux/pm_domain.h >>> @@ -299,6 +299,8 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) >>> >>> #ifdef CONFIG_PM >>> int dev_pm_domain_attach(struct device *dev, bool power_on); >>> +struct device *dev_pm_domain_attach_by_id(struct device *dev, >>> + unsigned int index); >>> void dev_pm_domain_detach(struct device *dev, bool power_off); >>> void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd); >>> #else >>> @@ -306,6 +308,11 @@ static inline int dev_pm_domain_attach(struct device *dev, bool power_on) >>> { >>> return 0; >>> } >>> +static inline struct device *dev_pm_domain_attach_by_id(struct device *dev, >>> + unsigned int index) >>> +{ >>> + return NULL; >>> +} >>> static inline void dev_pm_domain_detach(struct device *dev, bool power_off) {} >>> static inline void dev_pm_domain_set(struct device *dev, >>> struct dev_pm_domain *pd) {} >>> >> >> My only other comments on this series are ... >> >> 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and >> that the DT binding has a 'power-domain-names' property. > > I think it makes sense, but my plan was to do that as second step on > top. Are you okay with that as well? Yes that is fine with me. >> 2. I am wondering if there could be value in having a >> dev_pm_domain_attach_link_all() helper which would attach and link all >> PM domains at once. > > Perhaps it can be useful, yes! However, maybe we can postpone that to > after this series. I want to keep the series as simple as possible, > then we can build upon it. That's fine too and I can always add these if you prefer. Cheers Jon
On 29/05/18 11:04, Ulf Hansson wrote: > To support devices being partitioned across multiple PM domains, let's > begin with extending genpd to cope with these kind of configurations. > > Therefore, add a new exported function genpd_dev_pm_attach_by_id(), which > is similar to the existing genpd_dev_pm_attach(), but with the difference > that it allows its callers to provide an index to the PM domain that it > wants to attach. > > Note that, genpd_dev_pm_attach_by_id() shall only be called by the driver > core / PM core, similar to how the existing dev_pm_domain_attach() makes > use of genpd_dev_pm_attach(). However, this is implemented by following > changes on top. > > Because, only one PM domain can be attached per device, genpd needs to > create a virtual device that it can attach/detach instead. More precisely, > let the new function genpd_dev_pm_attach_by_id() register a virtual struct > device via calling device_register(). Then let it attach this device to the > corresponding PM domain, rather than the one that is provided by the > caller. The actual attaching is done via re-using the existing genpd OF > functions. > > At successful attachment, genpd_dev_pm_attach_by_id() returns the created > virtual device, which allows the caller to operate on it to deal with power > management. Following changes on top, provides more details in this > regards. > > To deal with detaching of a PM domain for the multiple PM domains case, > let's also extend the existing genpd_dev_pm_detach() function, to cover the > cleanup of the created virtual device, via make it call device_unregister() > on it. In this way, there is no need to introduce a new function to deal > with detach for the multiple PM domain case, but instead the existing one > is re-used. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes in v2: > - Fixed comments from Jon. Clarified function descriptions > and changelog. > > --- > drivers/base/power/domain.c | 80 +++++++++++++++++++++++++++++++++++++ > include/linux/pm_domain.h | 8 ++++ > 2 files changed, 88 insertions(+) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 2af99bfcbe3c..2b496d79159d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2171,6 +2171,15 @@ struct generic_pm_domain *of_genpd_remove_last(struct device_node *np) > } > EXPORT_SYMBOL_GPL(of_genpd_remove_last); > > +static void genpd_release_dev(struct device *dev) > +{ > + kfree(dev); > +} > + > +static struct bus_type genpd_bus_type = { > + .name = "genpd", > +}; > + > /** > * genpd_dev_pm_detach - Detach a device from its PM domain. > * @dev: Device to detach. > @@ -2208,6 +2217,10 @@ static void genpd_dev_pm_detach(struct device *dev, bool power_off) > > /* Check if PM domain can be powered off after removing this device. */ > genpd_queue_power_off_work(pd); > + > + /* Unregister the device if it was created by genpd. */ > + if (dev->bus == &genpd_bus_type) > + device_unregister(dev); > } > > static void genpd_dev_pm_sync(struct device *dev) > @@ -2298,6 +2311,67 @@ int genpd_dev_pm_attach(struct device *dev) > } > EXPORT_SYMBOL_GPL(genpd_dev_pm_attach); > > +/** > + * genpd_dev_pm_attach_by_id() - Attach a device to one of its PM domain. > + * @dev: Device to attach. Can you update the description of the above as well? Thanks Jon
On 29/05/18 11:04, Ulf Hansson wrote: > The power-domain DT property may now contain a list of PM domain > specifiers, which represents that a device are partitioned across multiple > PM domains. This leads to a new situation in genpd_dev_pm_attach(), as only > one PM domain can be attached per device. > > To remain things simple for the most common configuration, when a single PM > domain is used, let's treat the multiple PM domain case as being specific. > > In other words, let's change genpd_dev_pm_attach() to check for multiple PM > domains and prevent it from attach any PM domain for this case. Instead, > leave this to be managed separately, from following changes to genpd. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Suggested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes in v2: > - Minor update to changelog to mention "PM domain specifiers" rather > than a "list of phandles". > > --- > drivers/base/power/domain.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 7ebf7993273a..12a20f21974d 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2229,10 +2229,10 @@ static void genpd_dev_pm_sync(struct device *dev) > * attaches the device to retrieved pm_domain ops. > * > * Returns 1 on successfully attached PM domain, 0 when the device don't need a > - * PM domain or a negative error code in case of failures. Note that if a > - * power-domain exists for the device, but it cannot be found or turned on, > - * then return -EPROBE_DEFER to ensure that the device is not probed and to > - * re-try again later. > + * PM domain or when multiple power-domains exists for it, else a negative error > + * code. Note that if a power-domain exists for the device, but it cannot be > + * found or turned on, then return -EPROBE_DEFER to ensure that the device is > + * not probed and to re-try again later. > */ > int genpd_dev_pm_attach(struct device *dev) > { > @@ -2243,10 +2243,18 @@ int genpd_dev_pm_attach(struct device *dev) > if (!dev->of_node) > return 0; > > + /* > + * Devices with multiple PM domains must be attached separately, as we > + * can only attach one PM domain per device. > + */ > + if (of_count_phandle_with_args(dev->of_node, "power-domains", > + "#power-domain-cells") != 1) > + return 0; > + > ret = of_parse_phandle_with_args(dev->of_node, "power-domains", > "#power-domain-cells", 0, &pd_args); > if (ret < 0) > - return 0; > + return ret; > > mutex_lock(&gpd_list_lock); > pd = genpd_get_from_provider(&pd_args); > Acked-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
On 29/05/18 11:04, Ulf Hansson wrote: > To extend genpd to deal with allowing multiple PM domains per device, some > of the code in genpd_dev_pm_attach() can be re-used. Let's prepare for this > by moving some of the code into a sub-function. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 60 ++++++++++++++++++++----------------- > 1 file changed, 33 insertions(+), 27 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 12a20f21974d..2af99bfcbe3c 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2221,38 +2221,15 @@ static void genpd_dev_pm_sync(struct device *dev) > genpd_queue_power_off_work(pd); > } > > -/** > - * genpd_dev_pm_attach - Attach a device to its PM domain using DT. > - * @dev: Device to attach. > - * > - * Parse device's OF node to find a PM domain specifier. If such is found, > - * attaches the device to retrieved pm_domain ops. > - * > - * Returns 1 on successfully attached PM domain, 0 when the device don't need a > - * PM domain or when multiple power-domains exists for it, else a negative error > - * code. Note that if a power-domain exists for the device, but it cannot be > - * found or turned on, then return -EPROBE_DEFER to ensure that the device is > - * not probed and to re-try again later. > - */ > -int genpd_dev_pm_attach(struct device *dev) > +static int __genpd_dev_pm_attach(struct device *dev, struct device_node *np, > + unsigned int index) > { > struct of_phandle_args pd_args; > struct generic_pm_domain *pd; > int ret; > > - if (!dev->of_node) > - return 0; > - > - /* > - * Devices with multiple PM domains must be attached separately, as we > - * can only attach one PM domain per device. > - */ > - if (of_count_phandle_with_args(dev->of_node, "power-domains", > - "#power-domain-cells") != 1) > - return 0; > - > - ret = of_parse_phandle_with_args(dev->of_node, "power-domains", > - "#power-domain-cells", 0, &pd_args); > + ret = of_parse_phandle_with_args(np, "power-domains", > + "#power-domain-cells", index, &pd_args); > if (ret < 0) > return ret; > > @@ -2290,6 +2267,35 @@ int genpd_dev_pm_attach(struct device *dev) > > return ret ? -EPROBE_DEFER : 1; > } > + > +/** > + * genpd_dev_pm_attach - Attach a device to its PM domain using DT. > + * @dev: Device to attach. > + * > + * Parse device's OF node to find a PM domain specifier. If such is found, > + * attaches the device to retrieved pm_domain ops. > + * > + * Returns 1 on successfully attached PM domain, 0 when the device don't need a > + * PM domain or when multiple power-domains exists for it, else a negative error > + * code. Note that if a power-domain exists for the device, but it cannot be > + * found or turned on, then return -EPROBE_DEFER to ensure that the device is > + * not probed and to re-try again later. > + */ > +int genpd_dev_pm_attach(struct device *dev) > +{ > + if (!dev->of_node) > + return 0; > + > + /* > + * Devices with multiple PM domains must be attached separately, as we > + * can only attach one PM domain per device. > + */ > + if (of_count_phandle_with_args(dev->of_node, "power-domains", > + "#power-domain-cells") != 1) > + return 0; > + > + return __genpd_dev_pm_attach(dev, dev->of_node, 0); > +} > EXPORT_SYMBOL_GPL(genpd_dev_pm_attach); > > static const struct of_device_id idle_state_match[] = { Acked-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
On Tue, May 29, 2018 at 12:04:17PM +0200, Ulf Hansson wrote: > To be able to describe topologies where devices are partitioned across > multiple power domains, let's extend the power-domain property to allow > being a list of PM domain specifiers. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Suggested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > Changes in v2: > - Fixed comments from Geert. Re-worded to "PM domain specifiers" and > clarified DT example. > > --- > .../bindings/power/power_domain.txt | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
On 29-05-18, 12:04, Ulf Hansson wrote: > Using "extern" to declare a function in a public header file is somewhat > pointless, but also doesn't hurt. However, to make all the function > declarations in pm_domain.h to be consistent, let's drop the use of > "extern". > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > include/linux/pm_domain.h | 51 ++++++++++++++++++--------------------- > 1 file changed, 23 insertions(+), 28 deletions(-) Finally. I wanted to do that earlier as checkpatch complained non stop about such declarations :) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 29-05-18, 12:04, Ulf Hansson wrote: > There are still a few non-DT existing users of genpd, however neither of > them uses __pm_genpd_add_device(), hence let's drop it. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 10 ++++------ > include/linux/pm_domain.h | 14 +++----------- > 2 files changed, 7 insertions(+), 17 deletions(-) Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
On 29-05-18, 12:04, Ulf Hansson wrote: > The in-parameter struct generic_pm_domain *genpd to > genpd_allocate_dev_data() is unused, so let's drop it. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
[...] >> +/** >> + * genpd_dev_pm_attach_by_id() - Attach a device to one of its PM domain. >> + * @dev: Device to attach. > > Can you update the description of the above as well? Yes, like below? genpd_dev_pm_attach_by_id() - Associate a device with one of its PM domains. @dev: The device used to lookup the PM domain. Kind regards Uffe
On 29-05-18, 12:04, Ulf Hansson wrote: > To be able to describe topologies where devices are partitioned across > multiple power domains, let's extend the power-domain property to allow > being a list of PM domain specifiers. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Suggested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
On 29-05-18, 12:04, Ulf Hansson wrote: > To extend genpd to deal with allowing multiple PM domains per device, some > of the code in genpd_dev_pm_attach() can be re-used. Let's prepare for this > by moving some of the code into a sub-function. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 60 ++++++++++++++++++++----------------- > 1 file changed, 33 insertions(+), 27 deletions(-) Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
On 31/05/18 07:17, Ulf Hansson wrote: > [...] > >>> +/** >>> + * genpd_dev_pm_attach_by_id() - Attach a device to one of its PM domain. >>> + * @dev: Device to attach. >> >> Can you update the description of the above as well? > > Yes, like below? > > genpd_dev_pm_attach_by_id() - Associate a device with one of its PM domains. > @dev: The device used to lookup the PM domain. Yes perfect. Thanks Jon
On 29-05-18, 12:04, Ulf Hansson wrote: > Changes in v2: > - Addressed comments from Geert around DT doc. > - Addressed comments from Jon around clarification of how to use this > and changes to returned error codes. > - Fixed build error in case CONFIG_PM was unset. > > There are devices that are partitioned across multiple PM domains. Currently > these can't be supported well by the available PM infrastructures we have in > the kernel. This series is an attempt to address this. > > The interesting parts happens from patch 5 an onwards, including a minor DT > update to the existing power-domain bindings, the 4 earlier are just trivial > clean-ups of some related code in genpd, which I happened to stumble over. > > Some additional background: > > One existing case where devices are partitioned across multiple PM domains, is > the Nvida Tegra 124/210 X-USB subsystem. A while ago Jon Hunter (Nvidia) sent a > series, trying to address these issues, however this is a new approach, while > it re-uses the same concepts from DT point of view. > > The Tegra 124/210 X-USB subsystem contains of a host controller and a device > controller. Each controller have its own independent PM domain, but are being > partitioned across another shared PM domain for the USB super-speed logic. > > Currently to make the drivers work, either the related PM domains needs to stay > powered on always or the PM domain topology needs to be in-correctly modelled > through sub-domains. In both cases PM domains may be powered on while they > don't need to be, so in the end this means - wasting power -. > > As stated above, this series intends to address these problem from a PM > infrastructure point of view. More details are available in each changelog. > > It should be noted that this series has been tested on HW, however only by using > a home-cooked test PM domain driver for genpd and together with a test driver. > This allowed me to play with PM domain (genpd), runtime PM and device links. > > Any further deployment for real use cases are greatly appreciated. I am happy to > to help, if needed! Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
On 31 May 2018 at 10:03, Jon Hunter <jonathanh@nvidia.com> wrote: > > On 31/05/18 07:17, Ulf Hansson wrote: >> [...] >> >>>> +/** >>>> + * genpd_dev_pm_attach_by_id() - Attach a device to one of its PM domain. >>>> + * @dev: Device to attach. >>> >>> Can you update the description of the above as well? >> >> Yes, like below? >> >> genpd_dev_pm_attach_by_id() - Associate a device with one of its PM domains. >> @dev: The device used to lookup the PM domain. > > Yes perfect. I assume I can consider this as an ack and tested by tag, both for patch 8 and 9? Kind regards Uffe
On 31 May 2018 at 11:14, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 29-05-18, 12:04, Ulf Hansson wrote: >> Changes in v2: >> - Addressed comments from Geert around DT doc. >> - Addressed comments from Jon around clarification of how to use this >> and changes to returned error codes. >> - Fixed build error in case CONFIG_PM was unset. >> >> There are devices that are partitioned across multiple PM domains. Currently >> these can't be supported well by the available PM infrastructures we have in >> the kernel. This series is an attempt to address this. >> >> The interesting parts happens from patch 5 an onwards, including a minor DT >> update to the existing power-domain bindings, the 4 earlier are just trivial >> clean-ups of some related code in genpd, which I happened to stumble over. >> >> Some additional background: >> >> One existing case where devices are partitioned across multiple PM domains, is >> the Nvida Tegra 124/210 X-USB subsystem. A while ago Jon Hunter (Nvidia) sent a >> series, trying to address these issues, however this is a new approach, while >> it re-uses the same concepts from DT point of view. >> >> The Tegra 124/210 X-USB subsystem contains of a host controller and a device >> controller. Each controller have its own independent PM domain, but are being >> partitioned across another shared PM domain for the USB super-speed logic. >> >> Currently to make the drivers work, either the related PM domains needs to stay >> powered on always or the PM domain topology needs to be in-correctly modelled >> through sub-domains. In both cases PM domains may be powered on while they >> don't need to be, so in the end this means - wasting power -. >> >> As stated above, this series intends to address these problem from a PM >> infrastructure point of view. More details are available in each changelog. >> >> It should be noted that this series has been tested on HW, however only by using >> a home-cooked test PM domain driver for genpd and together with a test driver. >> This allowed me to play with PM domain (genpd), runtime PM and device links. >> >> Any further deployment for real use cases are greatly appreciated. I am happy to >> to help, if needed! > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks! Kind regards Uffe
On 31/05/18 11:44, Ulf Hansson wrote: > On 31 May 2018 at 10:03, Jon Hunter <jonathanh@nvidia.com> wrote: >> >> On 31/05/18 07:17, Ulf Hansson wrote: >>> [...] >>> >>>>> +/** >>>>> + * genpd_dev_pm_attach_by_id() - Attach a device to one of its PM domain. >>>>> + * @dev: Device to attach. >>>> >>>> Can you update the description of the above as well? >>> >>> Yes, like below? >>> >>> genpd_dev_pm_attach_by_id() - Associate a device with one of its PM domains. >>> @dev: The device used to lookup the PM domain. >> >> Yes perfect. > > I assume I can consider this as an ack and tested by tag, both for > patch 8 and 9? Yes you can. Cheers Jon
On 05/30/2018 08:00 PM, Jon Hunter wrote: >>> My only other comments on this series are ... >>> >>> 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and >>> that the DT binding has a 'power-domain-names' property. >> I think it makes sense, but my plan was to do that as second step on >> top. Are you okay with that as well? > Yes that is fine with me. Ulf, do you have a patch for this? I am working on moving some of qcom remoteproc drivers to use this series and it will help to have a dev_pm_domain_attach_by_name() api. Thanks, Rajendra
On 27 June 2018 at 10:55, Rajendra Nayak <rnayak@codeaurora.org> wrote: > > > On 05/30/2018 08:00 PM, Jon Hunter wrote: >>>> My only other comments on this series are ... >>>> >>>> 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and >>>> that the DT binding has a 'power-domain-names' property. >>> I think it makes sense, but my plan was to do that as second step on >>> top. Are you okay with that as well? >> Yes that is fine with me. > > Ulf, do you have a patch for this? I am working on moving some of qcom > remoteproc drivers to use this series and it will help to have a > dev_pm_domain_attach_by_name() api. Right. Besides this I have been working on a little improvement, avoiding to power the PM domain while attaching. I post a series in a day or two. Kind regards Uffe
On 06/27/2018 02:35 PM, Ulf Hansson wrote: > On 27 June 2018 at 10:55, Rajendra Nayak <rnayak@codeaurora.org> wrote: >> >> >> On 05/30/2018 08:00 PM, Jon Hunter wrote: >>>>> My only other comments on this series are ... >>>>> >>>>> 1. I think it would be nice to have an dev_pm_domain_attach_by_name() and >>>>> that the DT binding has a 'power-domain-names' property. >>>> I think it makes sense, but my plan was to do that as second step on >>>> top. Are you okay with that as well? >>> Yes that is fine with me. >> >> Ulf, do you have a patch for this? I am working on moving some of qcom >> remoteproc drivers to use this series and it will help to have a >> dev_pm_domain_attach_by_name() api. > > Right. Besides this I have been working on a little improvement, > avoiding to power the PM domain while attaching. > > I post a series in a day or two. great, thank you. > > Kind regards > Uffe > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
Changes in v2: - Addressed comments from Geert around DT doc. - Addressed comments from Jon around clarification of how to use this and changes to returned error codes. - Fixed build error in case CONFIG_PM was unset. There are devices that are partitioned across multiple PM domains. Currently these can't be supported well by the available PM infrastructures we have in the kernel. This series is an attempt to address this. The interesting parts happens from patch 5 an onwards, including a minor DT update to the existing power-domain bindings, the 4 earlier are just trivial clean-ups of some related code in genpd, which I happened to stumble over. Some additional background: One existing case where devices are partitioned across multiple PM domains, is the Nvida Tegra 124/210 X-USB subsystem. A while ago Jon Hunter (Nvidia) sent a series, trying to address these issues, however this is a new approach, while it re-uses the same concepts from DT point of view. The Tegra 124/210 X-USB subsystem contains of a host controller and a device controller. Each controller have its own independent PM domain, but are being partitioned across another shared PM domain for the USB super-speed logic. Currently to make the drivers work, either the related PM domains needs to stay powered on always or the PM domain topology needs to be in-correctly modelled through sub-domains. In both cases PM domains may be powered on while they don't need to be, so in the end this means - wasting power -. As stated above, this series intends to address these problem from a PM infrastructure point of view. More details are available in each changelog. It should be noted that this series has been tested on HW, however only by using a home-cooked test PM domain driver for genpd and together with a test driver. This allowed me to play with PM domain (genpd), runtime PM and device links. Any further deployment for real use cases are greatly appreciated. I am happy to to help, if needed! Kind regards Ulf Hansson Ulf Hansson (9): PM / Domains: Drop extern declarations of functions in pm_domain.h PM / Domains: Drop __pm_genpd_add_device() PM / Domains: Drop genpd as in-param for pm_genpd_remove_device() PM / Domains: Drop unused parameter in genpd_allocate_dev_data() PM / Domains: dt: Allow power-domain property to be a list of specifiers PM / Domains: Don't attach devices in genpd with multi PM domains PM / Domains: Split genpd_dev_pm_attach() PM / Domains: Add support for multi PM domains per device to genpd PM / Domains: Add dev_pm_domain_attach_by_id() to manage multi PM domains .../bindings/power/power_domain.txt | 19 ++- drivers/base/power/common.c | 39 ++++- drivers/base/power/domain.c | 155 ++++++++++++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +- include/linux/pm_domain.h | 79 ++++----- 5 files changed, 216 insertions(+), 78 deletions(-)