mbox series

[v3,0/6] ARM: Add Variscite DART-MX6 SoM and Carrier-board support

Message ID 1511785716-23492-1-git-send-email-narmstrong@baylibre.com
Headers show
Series ARM: Add Variscite DART-MX6 SoM and Carrier-board support | expand

Message

Neil Armstrong Nov. 27, 2017, 12:28 p.m. UTC
This patchset adds support for the Variscite DART-MX6 SoM with :
- i.MX6 Quad or Dual Lite SoC
- 1Gb/2Gb LPDDR2
- 4-64 GB eMMC
- Camera Interface
- HDMI+CEC interface
- LVDS / DSI / Parallel RGB interfaces
- Ethernet RGMII interface
- On-SoM Wi-Fi/Bluetooth with WiLink wl1835 SDIO Module
- SD/MMC/SDIO interface
- USB Host + USB OTG interface
- I2C interfaces
- SPI interfaces
- PCI-Express 2.0 interface
- on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface
- Digital Audio interface
- S/PDIF interface

And the Carrier-Board with the following :
- LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
- HDMI Connector
- USB Host + USB OTG Connector
- 10/100/1000 Mbps Ethernet
- miniPCI-Express slot
- SD Card connector
- Audio Headphone/Line In jack connectors
- On-board DMIC
- CAN bus header
- SPI header
- Camera Interfaces header
- 4xButtons, 2xLeds
- OnBoard RTC with Coin Backup battery socket
- RS232 Header + USB-Serial debug port

First patch contains a missing pinmux define used by the SoM.
Last patch contains configs used by the SoM DT like SERDEV or WL18XX support.

PCIe, On-Board DMIC and Camera Interfaces are not handled yet.

Changes since v2 at [2]:
- Added bindings acks
- fixed enable-active-high regulators property
- moved hdmi dd-i2c-bus to son dtsi
- fixed pinmux IOMUX value
- add pcie reset-gpio

Changes since v1 at [1]:
- Add lvds display vendor prefix and bindings
- fix all gpio phandle arguments with correct ACTIVE_XXX define
- drop pcie support
- drop custom operating points
- fix arm/pu/soc vin-supply instead of &cpu node override
- fix can pinmux value
- changed button node name
- add revied-by tags on first and last patches

[1] http://lkml.kernel.org/r/1511281705-30849-1-git-send-email-narmstrong@baylibre.com
[2] http://lkml.kernel.org/r/1511348560-28505-1-git-send-email-narmstrong@baylibre.com

Neil Armstrong (6):
  ARM: dts: imx6qdl-pinfunc: Add missing
    MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT
  dt-bindings: Add vendor prefix for Solomon Goldentek Display
    Corporation
  dt-bindings: display: Add bindings for SGD GKTW70SDAE4SE Panel
  ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support
  ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support
  ARM: configs: Add missing config for DART-MX6 SoM

 .../bindings/display/panel/sgd,gktw70sdae4se.txt   |  41 ++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/imx6dl-pinfunc.h                 |   1 +
 arch/arm/boot/dts/imx6q-pinfunc.h                  |   1 +
 arch/arm/boot/dts/imx6q-var-dt6customboard.dts     | 239 ++++++++++
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi            | 504 +++++++++++++++++++++
 arch/arm/configs/imx_v6_v7_defconfig               |   6 +
 8 files changed, 794 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.txt
 create mode 100644 arch/arm/boot/dts/imx6q-var-dt6customboard.dts
 create mode 100644 arch/arm/boot/dts/imx6qdl-var-dart.dtsi

Comments

Fabio Estevam Nov. 27, 2017, 12:57 p.m. UTC | #1
On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
<narmstrong@baylibre.com> wrote:

> +&pcie {
> +       fsl,tx-swing-full = <103>;
> +       fsl,tx-swing-low = <103>;
> +       reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;

This can only be active high if 'reset-gpio-active-high' property is
present, so what you
want here is:
  reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;

With this fixed:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Fabio Estevam Nov. 27, 2017, 12:58 p.m. UTC | #2
On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
<narmstrong@baylibre.com> wrote:
> This patch adds support for the i.MX6 Quad variant of the Variscite DART-MX6
> SoM Carrier-Board.
>
> This Carrier-Board has the following :
> - LVDS interface for the VLCD-CAP-GLD-LVDS 7" LCD 800 x 480 touch display
> - HDMI Connector
> - USB Host + USB OTG Connector
> - 10/100/1000 Mbps Ethernet
> - miniPCI-Express slot
> - SD Card connector
> - Audio Headphone/Line In jack connectors
> - On-board DMIC
> - CAN bus header
> - SPI header
> - Camera Interfaces header
> - 4xButtons, 2xLeds
> - OnBoard RTC with Coin Backup battery socket
> - RS232 Header + USB-Serial debug port
>
> Product Page : http://www.variscite.com/products/evaluation-kits/dart-mx6-kits
>
> The board support is done with all on-board and header interfaces enabled.
> 7" LVDS Touchscreen is enabled by default along HDMI output.
> Audio interface is supported with the "simple-card" bindings.
>
> PCIe slot, On-Board DMIC and Camera Interfaces are not handled yet.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

 Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Neil Armstrong Nov. 28, 2017, 11:16 a.m. UTC | #3
On 27/11/2017 13:57, Fabio Estevam wrote:
> On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
> <narmstrong@baylibre.com> wrote:
> 
>> +&pcie {
>> +       fsl,tx-swing-full = <103>;
>> +       fsl,tx-swing-low = <103>;
>> +       reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;
> 
> This can only be active high if 'reset-gpio-active-high' property is
> present, so what you
> want here is:
>   reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
> 
> With this fixed:
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> 

Ok,

I will post a v4 lately with this fixed.

Thanks,
Neil