Message ID | 4B579C4A.3040907@gmail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On 01/20/2010 07:15 PM, Tejun Heo wrote: > Oops, Jeff, please send this #upstream. I was thinking #upstream but > my fingers had their own mind. Thanks. yep, definitely #upstream material... -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 21 Jan 2010 09:14:02 +0900 Tejun Heo <htejun@gmail.com> wrote: > CONFIG_NO_ATA_LEGACY isn't used by anyone. Drop it. > > Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> > Signed-off-by: Tejun Heo <tj@kernel.org> Not unless this is cleared with the FRV maintainers who were using it and I believe may still need it. Mr Howells ? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
(cc'ing David Howells, who BTW is on vacation till Feb) Hi! On 01/21/2010 09:04 PM, Alan Cox wrote: > On Thu, 21 Jan 2010 09:14:02 +0900 > Tejun Heo <htejun@gmail.com> wrote: > >> CONFIG_NO_ATA_LEGACY isn't used by anyone. Drop it. >> >> Reported-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de> >> Signed-off-by: Tejun Heo <tj@kernel.org> > > Not unless this is cleared with the FRV maintainers who were using > it and I believe may still need it. > > Mr Howells ? David, the patch in question is, http://lkml.org/lkml/2010/1/20/396 Does FRV still need it? Thanks.
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 741065c..b9df435 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -2945,15 +2945,6 @@ int ata_pci_sff_activate_host(struct ata_host *host, mask = (1 << 2) | (1 << 0); if ((tmp8 & mask) != mask) legacy_mode = 1; -#if defined(CONFIG_NO_ATA_LEGACY) - /* Some platforms with PCI limits cannot address compat - port space. In that case we punt if their firmware has - left a device in compatibility mode */ - if (legacy_mode) { - printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n"); - return -EOPNOTSUPP; - } -#endif } if (!devres_open_group(dev, NULL, GFP_KERNEL))