From patchwork Wed Jan 20 05:03:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 43260 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F0101B7CD9 for ; Wed, 20 Jan 2010 16:04:16 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236Ab0ATFEN (ORCPT ); Wed, 20 Jan 2010 00:04:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751250Ab0ATFEN (ORCPT ); Wed, 20 Jan 2010 00:04:13 -0500 Received: from mail-iw0-f197.google.com ([209.85.223.197]:58245 "EHLO mail-iw0-f197.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236Ab0ATFEL (ORCPT ); Wed, 20 Jan 2010 00:04:11 -0500 Received: by iwn35 with SMTP id 35so3522283iwn.4 for ; Tue, 19 Jan 2010 21:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=oMCvP3kb2kXmh+6U63msVhzd0Jsp2g7Cz78A1jH/VgA=; b=iQ6+CUnaOdN+0KihQ4YZpTLcWLKJo/YRTl4n/M+8g0HReGc7PmcNkbWHfGbX0Hau0L EUcxp814SXdHF/i+IlLhiAFmxlTLvsid8p7zws8jLRIwnwpV0dnh6TMbrq2VySdTyG8k cWuBXe2i7l1YPO0KMZQf9yZpLAUMnHIVrQDvQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=HwobtWZzojxmWWgWM0kNjlJtpqCL5LY6Nwsy1dLiGoe+7UP/zDtbUW/5wv0gND+pVO AC7fwGWjK7DZefOZy1FjmQO2U591XCMgDZxw/y+ktyI5Bq/XQ5nlF3MmLk4chVYTlLZM /QHitxokE24bEIbZM7zKMlR+7JVV4a9k/GcDM= Received: by 10.231.150.2 with SMTP id w2mr1623721ibv.83.1263963849378; Tue, 19 Jan 2010 21:04:09 -0800 (PST) Received: from ?192.168.1.148? (S0106000c41bb86e1.ss.shawcable.net [70.76.40.110]) by mx.google.com with ESMTPS id 22sm121474iwn.8.2010.01.19.21.04.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 19 Jan 2010 21:04:08 -0800 (PST) Message-ID: <4B568EAB.1030207@gmail.com> Date: Tue, 19 Jan 2010 23:03:39 -0600 From: Robert Hancock User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: ide , Jeff Garzik Subject: [PATCH] libata: make functions/variables static Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Make some variables in ahci and a function in pata_pcmcia static, as found using sparse. Signed-off-by: Robert Hancock --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index b8bea10..265d0d4 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -356,10 +356,10 @@ static ssize_t ahci_show_host_version(struct device *dev, static ssize_t ahci_show_port_cmd(struct device *dev, struct device_attribute *attr, char *buf); -DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL); -DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL); -DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL); -DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL); +static DEVICE_ATTR(ahci_host_caps, S_IRUGO, ahci_show_host_caps, NULL); +static DEVICE_ATTR(ahci_host_cap2, S_IRUGO, ahci_show_host_cap2, NULL); +static DEVICE_ATTR(ahci_host_version, S_IRUGO, ahci_show_host_version, NULL); +static DEVICE_ATTR(ahci_port_cmd, S_IRUGO, ahci_show_port_cmd, NULL); static struct device_attribute *ahci_shost_attrs[] = { &dev_attr_link_power_management_policy, diff --git a/drivers/ata/pata_pcmcia.c b/drivers/ata/pata_pcmcia.c index 1b392c9..3610353 100644 --- a/drivers/ata/pata_pcmcia.c +++ b/drivers/ata/pata_pcmcia.c @@ -136,7 +136,7 @@ static unsigned int ata_data_xfer_8bit(struct ata_device *dev, * */ -void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc) +static void pcmcia_8bit_drain_fifo(struct ata_queued_cmd *qc) { int count; struct ata_port *ap;