Message ID | 4B4B877A.8060106@googlemail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
2010/1/11 René Bolldorf <xsecute@googlemail.com>: > I hope that's good enough explained :-). definitely an improvement, but i think jeff is going to want your S-O-B and at least a patch title, if no description :) > + /* make sure sense_buf is cleared then atapi_eh_request_sense is > called. s/then/when/ ? > + * (to make sure nothing get's reused.) probably not necessary > + * thanks to James Bottomley this may be better in a patch description cheers, marc -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- ./drivers/ata/libata-eh.c 2010-01-07 23:21:23.622464012 +0100 +++ ./drivers/ata/libata-eh.c 2010-01-11 21:11:19.869092897 +0100 @@ -1505,7 +1505,10 @@ static unsigned int atapi_eh_request_sen DPRINTK("ATAPI request sense\n"); - /* FIXME: is this needed? */ + /* make sure sense_buf is cleared then atapi_eh_request_sense is called. + * (to make sure nothing get's reused.) + * thanks to James Bottomley + */ memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);