From patchwork Mon Jun 29 14:09:20 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejun Heo X-Patchwork-Id: 29278 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by bilbo.ozlabs.org (Postfix) with ESMTP id 37DD5B7080 for ; Tue, 30 Jun 2009 00:10:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756782AbZF2OJ3 (ORCPT ); Mon, 29 Jun 2009 10:09:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758397AbZF2OJ2 (ORCPT ); Mon, 29 Jun 2009 10:09:28 -0400 Received: from hera.kernel.org ([140.211.167.34]:53721 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbZF2OJ0 (ORCPT ); Mon, 29 Jun 2009 10:09:26 -0400 Received: from htj.dyndns.org (IDENT:U2FsdGVkX18X+p+Mve9SYiJrTy+SmYv+PTP4PY14JRI@localhost [127.0.0.1]) by hera.kernel.org (8.14.2/8.14.2) with ESMTP id n5TE9K0D032581 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 29 Jun 2009 14:09:22 GMT Received: from [127.0.0.2] (htj.dyndns.org [127.0.0.2]) by htj.dyndns.org (Postfix) with ESMTPSA id 62241405A83DE; Mon, 29 Jun 2009 23:09:20 +0900 (KST) Message-ID: <4A48CB10.5020409@kernel.org> Date: Mon, 29 Jun 2009 23:09:20 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Thomas Jackowski CC: linux-ide@vger.kernel.org Subject: Re: Errors on ICH10R with Seagate HDDs References: <49D4A232.3090504@hadiko.de> <49DE39E2.7070505@kernel.org> <49E847A3.9070100@hadiko.de> <49EAE746.4040303@kernel.org> <49F2E47C.5010803@hadiko.de> <49F3C03C.1090803@kernel.org> <4A36FC7D.5050805@hadiko.de> <4A388E1F.5070404@kernel.org> <4A3FD015.4090602@hadiko.de> <4A443366.4010807@kernel.org> <4A4878B3.9020206@hadiko.de> In-Reply-To: <4A4878B3.9020206@hadiko.de> X-Enigmail-Version: 0.95.7 X-Virus-Scanned: ClamAV 0.93.3/9517/Sun Jun 28 23:08:06 2009 on hera.kernel.org X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on hera.kernel.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Mon, 29 Jun 2009 14:09:22 +0000 (UTC) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Thomas Jackowski wrote: > there is no relevant output in this loop (running about 6 hours). Hmm... can you please try the attached patch? It should show us who's issuing the CPM. Thanks. diff --git a/block/elevator.c b/block/elevator.c index 7073a90..93e6575 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -618,6 +618,16 @@ void elv_insert(struct request_queue *q, struct request *rq, int where) unsigned ordseq; int unplug_it = 1; + if (rq->cmd[0] == 0xa1 || rq->cmd[0] == 0x85) { + u8 cmd = rq->cmd[0] == 0xa1 ? rq->cmd[9] : rq->cmd[14]; + + if (cmd == 0xe5) { + printk("XXX %s: elv_insert(ATA_CHK_POWER)\n", + rq->rq_disk ? rq->rq_disk->disk_name : "?"); + dump_stack(); + } + } + trace_block_rq_insert(q, rq); rq->q = q; diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 94919ad..a56c53d 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2722,6 +2722,7 @@ static void ata_eh_park_issue_cmd(struct ata_device *dev, int park) tf.lbah = 0x55; } else { ehc->unloaded_mask &= ~(1 << dev->devno); + ata_dev_printk(dev, KERN_INFO, "XXX issuing CHK_POWER for unparking\n"); tf.command = ATA_CMD_CHK_POWER; }