| Message ID | 20240824121449.2522086-1-cuigaosheng1@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] ata: libata: Remove obsoleted declaration for ata_sff_irq_clear | expand |
On 8/24/24 9:14 PM, Gaosheng Cui wrote: > The ata_sff_irq_clear() have been removed since > commit 37f65b8bc262 ("libata-sff: ata_sff_irq_clear() is BMDMA > specific"), and now it is useless, so remove it. Same comment as previous patch, the writing could be better. Furthermore, I think the 2 patches should be squashed since they are both modifying the same file. E.g., something like this would be better: ata: libata: Remove obsolete functions declaration The function ata_schedule_scsi_eh() was removed with commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic API for SCSI transports"). And the function ata_sff_irq_clear() was removed with commit 37f65b8bc262 ("libata-sff: ata_sff_irq_clear() is BMDMA specific"). Remove the now useless declarations of these functions in drivers/ata/libata.h. And a single patch to remove both declarations. Can you resend with this change please ? > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > include/linux/libata.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/libata.h b/include/linux/libata.h > index 0279c0a6302f..6552e90753ae 100644 > --- a/include/linux/libata.h > +++ b/include/linux/libata.h > @@ -2006,7 +2006,6 @@ extern unsigned int ata_sff_data_xfer(struct ata_queued_cmd *qc, > extern unsigned int ata_sff_data_xfer32(struct ata_queued_cmd *qc, > unsigned char *buf, unsigned int buflen, int rw); > extern void ata_sff_irq_on(struct ata_port *ap); > -extern void ata_sff_irq_clear(struct ata_port *ap); > extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc, > u8 status, int in_wq); > extern void ata_sff_queue_work(struct work_struct *work);
On 2024/8/26 12:10, Damien Le Moal wrote: > On 8/24/24 9:14 PM, Gaosheng Cui wrote: >> The ata_sff_irq_clear() have been removed since >> commit 37f65b8bc262 ("libata-sff: ata_sff_irq_clear() is BMDMA >> specific"), and now it is useless, so remove it. > Same comment as previous patch, the writing could be better. Furthermore, I > think the 2 patches should be squashed since they are both modifying the same > file. E.g., something like this would be better: > > ata: libata: Remove obsolete functions declaration > > The function ata_schedule_scsi_eh() was removed with commit f8bbfc247efb > ("[PATCH] SCSI: make scsi_implement_eh() generic API for SCSI transports"). And > the function ata_sff_irq_clear() was removed with commit 37f65b8bc262 > ("libata-sff: ata_sff_irq_clear() is BMDMA specific"). > > Remove the now useless declarations of these functions in drivers/ata/libata.h. > > And a single patch to remove both declarations. Can you resend with this change > please ? > I hava re-sent a new patch v2 with this change, thanks. >> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> >> --- >> include/linux/libata.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/libata.h b/include/linux/libata.h >> index 0279c0a6302f..6552e90753ae 100644 >> --- a/include/linux/libata.h >> +++ b/include/linux/libata.h >> @@ -2006,7 +2006,6 @@ extern unsigned int ata_sff_data_xfer(struct ata_queued_cmd *qc, >> extern unsigned int ata_sff_data_xfer32(struct ata_queued_cmd *qc, >> unsigned char *buf, unsigned int buflen, int rw); >> extern void ata_sff_irq_on(struct ata_port *ap); >> -extern void ata_sff_irq_clear(struct ata_port *ap); >> extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc, >> u8 status, int in_wq); >> extern void ata_sff_queue_work(struct work_struct *work);
diff --git a/include/linux/libata.h b/include/linux/libata.h index 0279c0a6302f..6552e90753ae 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -2006,7 +2006,6 @@ extern unsigned int ata_sff_data_xfer(struct ata_queued_cmd *qc, extern unsigned int ata_sff_data_xfer32(struct ata_queued_cmd *qc, unsigned char *buf, unsigned int buflen, int rw); extern void ata_sff_irq_on(struct ata_port *ap); -extern void ata_sff_irq_clear(struct ata_port *ap); extern int ata_sff_hsm_move(struct ata_port *ap, struct ata_queued_cmd *qc, u8 status, int in_wq); extern void ata_sff_queue_work(struct work_struct *work);
The ata_sff_irq_clear() have been removed since commit 37f65b8bc262 ("libata-sff: ata_sff_irq_clear() is BMDMA specific"), and now it is useless, so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- include/linux/libata.h | 1 - 1 file changed, 1 deletion(-)