| Message ID | 20240726031954.566882-9-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanup, renaming and horkage improvements | expand |
On Fri, Jul 26, 2024 at 12:19:51PM +0900, Damien Le Moal wrote: > Remove the comment using the term "blacklist" from piix_init_sidpr(). > That comment is useless given that the function piix_no_sidpr() name is > clear about what is being checked. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/ata/ata_piix.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c > index ec3c5bd1f813..093b940bc953 100644 > --- a/drivers/ata/ata_piix.c > +++ b/drivers/ata/ata_piix.c > @@ -1446,7 +1446,6 @@ static int piix_init_sidpr(struct ata_host *host) > if (hpriv->map[i] == IDE) > return 0; > > - /* is it blacklisted? */ > if (piix_no_sidpr(host)) > return 0; > > -- > 2.45.2 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
On Fri, Jul 26, 2024 at 12:19:51PM +0900, Damien Le Moal wrote: > Remove the comment using the term "blacklist" from piix_init_sidpr(). > That comment is useless given that the function piix_no_sidpr() name is > clear about what is being checked. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Igor Pylypiv <ipylypiv@google.com> Thanks, Igor > --- > drivers/ata/ata_piix.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c > index ec3c5bd1f813..093b940bc953 100644 > --- a/drivers/ata/ata_piix.c > +++ b/drivers/ata/ata_piix.c > @@ -1446,7 +1446,6 @@ static int piix_init_sidpr(struct ata_host *host) > if (hpriv->map[i] == IDE) > return 0; > > - /* is it blacklisted? */ > if (piix_no_sidpr(host)) > return 0; > > -- > 2.45.2 > >
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index ec3c5bd1f813..093b940bc953 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c @@ -1446,7 +1446,6 @@ static int piix_init_sidpr(struct ata_host *host) if (hpriv->map[i] == IDE) return 0; - /* is it blacklisted? */ if (piix_no_sidpr(host)) return 0;
Remove the comment using the term "blacklist" from piix_init_sidpr(). That comment is useless given that the function piix_no_sidpr() name is clear about what is being checked. Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/ata_piix.c | 1 - 1 file changed, 1 deletion(-)