| Message ID | 20240726031954.566882-11-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanup, renaming and horkage improvements | expand |
On Fri, Jul 26, 2024 at 12:19:53PM +0900, Damien Le Moal wrote: > Rename the function hpt_dma_blacklisted() to the more neutral > hpt_dma_broken(). > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/ata/pata_hpt366.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c > index bdccd1ba1524..5280e9960025 100644 > --- a/drivers/ata/pata_hpt366.c > +++ b/drivers/ata/pata_hpt366.c > @@ -170,8 +170,8 @@ static const char * const bad_ata66_3[] = { > NULL > }; > > -static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > - const char * const list[]) > +static int hpt_dma_broken(const struct ata_device *dev, char *modestr, > + const char * const list[]) > { > unsigned char model_num[ATA_ID_PROD_LEN + 1]; > int i; > @@ -197,11 +197,11 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > static unsigned int hpt366_filter(struct ata_device *adev, unsigned int mask) > { > if (adev->class == ATA_DEV_ATA) { > - if (hpt_dma_blacklisted(adev, "UDMA", bad_ata33)) > + if (hpt_dma_broken(adev, "UDMA", bad_ata33)) > mask &= ~ATA_MASK_UDMA; > - if (hpt_dma_blacklisted(adev, "UDMA3", bad_ata66_3)) > + if (hpt_dma_broken(adev, "UDMA3", bad_ata66_3)) > mask &= ~(0xF8 << ATA_SHIFT_UDMA); > - if (hpt_dma_blacklisted(adev, "UDMA4", bad_ata66_4)) > + if (hpt_dma_broken(adev, "UDMA4", bad_ata66_4)) > mask &= ~(0xF0 << ATA_SHIFT_UDMA); > } else if (adev->class == ATA_DEV_ATAPI) > mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA); > -- > 2.45.2 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
On Fri, Jul 26, 2024 at 12:19:53PM +0900, Damien Le Moal wrote: > Rename the function hpt_dma_blacklisted() to the more neutral > hpt_dma_broken(). > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Igor Pylypiv <ipylypiv@google.com> Thanks, Igor > --- > drivers/ata/pata_hpt366.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c > index bdccd1ba1524..5280e9960025 100644 > --- a/drivers/ata/pata_hpt366.c > +++ b/drivers/ata/pata_hpt366.c > @@ -170,8 +170,8 @@ static const char * const bad_ata66_3[] = { > NULL > }; > > -static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > - const char * const list[]) > +static int hpt_dma_broken(const struct ata_device *dev, char *modestr, > + const char * const list[]) > { > unsigned char model_num[ATA_ID_PROD_LEN + 1]; > int i; > @@ -197,11 +197,11 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, > static unsigned int hpt366_filter(struct ata_device *adev, unsigned int mask) > { > if (adev->class == ATA_DEV_ATA) { > - if (hpt_dma_blacklisted(adev, "UDMA", bad_ata33)) > + if (hpt_dma_broken(adev, "UDMA", bad_ata33)) > mask &= ~ATA_MASK_UDMA; > - if (hpt_dma_blacklisted(adev, "UDMA3", bad_ata66_3)) > + if (hpt_dma_broken(adev, "UDMA3", bad_ata66_3)) > mask &= ~(0xF8 << ATA_SHIFT_UDMA); > - if (hpt_dma_blacklisted(adev, "UDMA4", bad_ata66_4)) > + if (hpt_dma_broken(adev, "UDMA4", bad_ata66_4)) > mask &= ~(0xF0 << ATA_SHIFT_UDMA); > } else if (adev->class == ATA_DEV_ATAPI) > mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA); > -- > 2.45.2 > >
diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c index bdccd1ba1524..5280e9960025 100644 --- a/drivers/ata/pata_hpt366.c +++ b/drivers/ata/pata_hpt366.c @@ -170,8 +170,8 @@ static const char * const bad_ata66_3[] = { NULL }; -static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, - const char * const list[]) +static int hpt_dma_broken(const struct ata_device *dev, char *modestr, + const char * const list[]) { unsigned char model_num[ATA_ID_PROD_LEN + 1]; int i; @@ -197,11 +197,11 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr, static unsigned int hpt366_filter(struct ata_device *adev, unsigned int mask) { if (adev->class == ATA_DEV_ATA) { - if (hpt_dma_blacklisted(adev, "UDMA", bad_ata33)) + if (hpt_dma_broken(adev, "UDMA", bad_ata33)) mask &= ~ATA_MASK_UDMA; - if (hpt_dma_blacklisted(adev, "UDMA3", bad_ata66_3)) + if (hpt_dma_broken(adev, "UDMA3", bad_ata66_3)) mask &= ~(0xF8 << ATA_SHIFT_UDMA); - if (hpt_dma_blacklisted(adev, "UDMA4", bad_ata66_4)) + if (hpt_dma_broken(adev, "UDMA4", bad_ata66_4)) mask &= ~(0xF0 << ATA_SHIFT_UDMA); } else if (adev->class == ATA_DEV_ATAPI) mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
Rename the function hpt_dma_blacklisted() to the more neutral hpt_dma_broken(). Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/pata_hpt366.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)