| Message ID | 20240726031954.566882-10-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | Some cleanup, renaming and horkage improvements | expand |
On Fri, Jul 26, 2024 at 12:19:52PM +0900, Damien Le Moal wrote: > Remove the use of the term "blacklist". What the comment using that term > refers to does not seem to exist at all anyway as the driver does not > have such list but rather only a list of compatible controllers. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> > --- > drivers/ata/pata_cs5520.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c > index 027cf67101ef..3163c8d9cef5 100644 > --- a/drivers/ata/pata_cs5520.c > +++ b/drivers/ata/pata_cs5520.c > @@ -8,9 +8,9 @@ > * PIO mode and smarter silicon. > * > * The practical upshot of this is that we must always tune the > - * drive for the right PIO mode. We must also ignore all the blacklists > - * and the drive bus mastering DMA information. Also to confuse matters > - * further we can do DMA on PIO only drives. > + * drive for the right PIO mode and ignore the drive bus mastering DMA > + * information. Also to confuse matters further we can do DMA on PIO only > + * drives. > * > * DMA on the 5510 also requires we disable_hlt() during DMA on early > * revisions. > -- > 2.45.2 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
On Fri, Jul 26, 2024 at 12:19:52PM +0900, Damien Le Moal wrote: > Remove the use of the term "blacklist". What the comment using that term > refers to does not seem to exist at all anyway as the driver does not > have such list but rather only a list of compatible controllers. > > Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Igor Pylypiv <ipylypiv@google.com> Thanks, Igor > --- > drivers/ata/pata_cs5520.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c > index 027cf67101ef..3163c8d9cef5 100644 > --- a/drivers/ata/pata_cs5520.c > +++ b/drivers/ata/pata_cs5520.c > @@ -8,9 +8,9 @@ > * PIO mode and smarter silicon. > * > * The practical upshot of this is that we must always tune the > - * drive for the right PIO mode. We must also ignore all the blacklists > - * and the drive bus mastering DMA information. Also to confuse matters > - * further we can do DMA on PIO only drives. > + * drive for the right PIO mode and ignore the drive bus mastering DMA > + * information. Also to confuse matters further we can do DMA on PIO only > + * drives. > * > * DMA on the 5510 also requires we disable_hlt() during DMA on early > * revisions. > -- > 2.45.2 > >
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index 027cf67101ef..3163c8d9cef5 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c @@ -8,9 +8,9 @@ * PIO mode and smarter silicon. * * The practical upshot of this is that we must always tune the - * drive for the right PIO mode. We must also ignore all the blacklists - * and the drive bus mastering DMA information. Also to confuse matters - * further we can do DMA on PIO only drives. + * drive for the right PIO mode and ignore the drive bus mastering DMA + * information. Also to confuse matters further we can do DMA on PIO only + * drives. * * DMA on the 5510 also requires we disable_hlt() during DMA on early * revisions.
Remove the use of the term "blacklist". What the comment using that term refers to does not seem to exist at all anyway as the driver does not have such list but rather only a list of compatible controllers. Signed-off-by: Damien Le Moal <dlemoal@kernel.org> --- drivers/ata/pata_cs5520.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)