From patchwork Wed Jul 17 10:03:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayyan Ansari X-Patchwork-Id: 1961506 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GiMGFTh/; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-ide+bounces-1901-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WPBSS1GBTz20B2 for ; Wed, 17 Jul 2024 20:07:20 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 92C23281378 for ; Wed, 17 Jul 2024 10:07:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 480F317FADF; Wed, 17 Jul 2024 10:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GiMGFTh/" X-Original-To: linux-ide@vger.kernel.org Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64F2417E914 for ; Wed, 17 Jul 2024 10:06:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210777; cv=none; b=cvvymQo3YVnCHxdQZ8+V/GS20VQmSPJqxTY4/8AaTK9JkOwNlsU321oLnwpzHt2TCYGw2iG6MYmcaltZks/JDp1Cz+NsPCJnYOZuVFk9n0EbpHUsGZoOt+OJQB6qM3dkSpjsIdcNOAdQy55DWqrtnXNcvBIB9GRkP730gd17KO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721210777; c=relaxed/simple; bh=euXfg7HYC28cRCFsrCOw0XPz5Yc9gWEUSR1RJDIDDWY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u7lIwypfH8S+IRWGoCqNhPb9kNK9CMsyzC0A/13rLA+/PwBTqKz8lOt/pJxSaVgYtl03EjYmcgnHoMxrxxpjDHN1bXRJ206YvqZyvwaMl+fpD5x2c5s+VnHJhYRTAjBpdsg+0Ljl7oVAwGLJLKeEvzILI3UHdQIEtNl8LXsI8DQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GiMGFTh/; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52e94eaf5efso8380304e87.2 for ; Wed, 17 Jul 2024 03:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721210774; x=1721815574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qdywHCpErhEdHKCAH1TVR2EgQSrjfvRUWI2cgY7PlTU=; b=GiMGFTh//fcRUkUouNx7abWpZPAwjUO5Op2/p4HkxOAoJDRf+UwRjNdAJE0wxnBSoY FVanc0JhT+qz6ciyHOgaEw/c7Id2dL+LCsZaceiZBJg7YOtyDoC7n1hisl48qwKe9Oty Xr4ZkHywRBHEgk6nIdtVTQ2CCg66zrVNFsYy1i7vTaHUss3zHUSXlcQsh2hT1fM9FzA1 gLO9z/RZ93u7zG1fJXq7wT5Xek/BZfZ+rFG6ctUBfgf9sa6XaXeDRVbsfr6FpAGDc7lE 7LSUgCCE6WRPANiBScZy58RUPA8n2BoBCqUVkpm6Cc4e2j4vAUHyncxMn0WiFtqgItTu gt8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721210774; x=1721815574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qdywHCpErhEdHKCAH1TVR2EgQSrjfvRUWI2cgY7PlTU=; b=BQSNMizVRvd/x2UmOE8kB3l2pqGnebog58VSjZPcG6GmCAC2M/8B6TaERT2d7F3+Lg JeTyTo3NFzXlcDw32djIxss97hWNdbbcgBdMpx8XR/glepL6o5++ehsWYWe9uq+LssjY sNkeWZwexHvaTgHpWImlMVZliAS+MRVaI+t17EUt9XxpuymJqaposyB+liJZpxIUR7qp bwSohrtgaLFM3Axp1Qyy09pPL9KA0r5zCxpHqgVZc5loLiVFfZB2cRr4bbv0MkYz1N9C KmOBd1EAXTDlEqOXBLMIfcd77WVMLAXmSiNCb0kXxwnjYTElU5LJCsnR086GMmyEnq0Z tpyA== X-Forwarded-Encrypted: i=1; AJvYcCWqLBlk8W+Tk2FsMaSEXLbsLBAT5Ve5CEPxoeKeoNsleka4zL6Iq2PNvA60+f/JZ6iozfNGEkfa/ddVRxca+eB/8anDfmIJlz/N X-Gm-Message-State: AOJu0YxpD1xoLR98oZd6p8G+5T7FiiQHNc0NvIU4YKV1Us/JiyseMgGv R5HrST7iqMnyEHM2pk1Lp6vpYFMMrYLkZUiZyOBD+e87J6YaEYO9SuLeLcuSIlA= X-Google-Smtp-Source: AGHT+IF2wNc6IOzLFvdUXMOWee8wruo61zvxPq7WkFVhPdniwc3ixyjq4vufUinAsSzoZC2ko5egWg== X-Received: by 2002:a05:6512:39c7:b0:52e:954d:359a with SMTP id 2adb3069b0e04-52ee54111ddmr879701e87.43.1721210773583; Wed, 17 Jul 2024 03:06:13 -0700 (PDT) Received: from rayyan-pc.broadband ([2a0a:ef40:ee7:2401:197d:e048:a80f:bc44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e983e7sm163259245e9.23.2024.07.17.03.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 03:06:13 -0700 (PDT) From: Rayyan Ansari To: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Rayyan Ansari , Conor Dooley , Damien Le Moal , de Goede , Jens Axboe , Krzysztof Kozlowski , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Niklas Cassel , Rob Herring Subject: [PATCH v2 1/2] dt-bindings: ata: qcom,ipq806x-ahci: use dtschema Date: Wed, 17 Jul 2024 11:03:06 +0100 Message-ID: <20240717100600.19005-2-rayyan.ansari@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240717100600.19005-1-rayyan.ansari@linaro.org> References: <20240717100600.19005-1-rayyan.ansari@linaro.org> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove old text bindings and add ipq806x AHCI compatible to ahci-common.yaml, as well as its required properties. Signed-off-by: Rayyan Ansari Reviewed-by: Krzysztof Kozlowski --- v1 -> v2: removed assigned-* properties from binding .../bindings/ata/ahci-platform.yaml | 30 +++++++++++- .../devicetree/bindings/ata/qcom-sata.txt | 48 ------------------- 2 files changed, 28 insertions(+), 50 deletions(-) delete mode 100644 Documentation/devicetree/bindings/ata/qcom-sata.txt diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml index 358617115bb8..2c8fdfc3df9b 100644 --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml @@ -30,6 +30,7 @@ select: - marvell,armada-3700-ahci - marvell,armada-8k-ahci - marvell,berlin2q-ahci + - qcom,ipq806x-ahci - socionext,uniphier-pro4-ahci - socionext,uniphier-pxs2-ahci - socionext,uniphier-pxs3-ahci @@ -45,6 +46,7 @@ properties: - marvell,armada-8k-ahci - marvell,berlin2-ahci - marvell,berlin2q-ahci + - qcom,ipq806x-ahci - socionext,uniphier-pro4-ahci - socionext,uniphier-pxs2-ahci - socionext,uniphier-pxs3-ahci @@ -64,11 +66,11 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 5 clock-names: minItems: 1 - maxItems: 3 + maxItems: 5 interrupts: maxItems: 1 @@ -97,6 +99,30 @@ required: allOf: - $ref: ahci-common.yaml# + + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq806x-ahci + then: + properties: + clocks: + minItems: 5 + clock-names: + items: + - const: slave_iface + - const: iface + - const: core + - const: rxoob + - const: pmalive + required: + - phys + - phy-names + - clocks + - clock-names + - if: properties: compatible: diff --git a/Documentation/devicetree/bindings/ata/qcom-sata.txt b/Documentation/devicetree/bindings/ata/qcom-sata.txt deleted file mode 100644 index 094de91cd9fd..000000000000 --- a/Documentation/devicetree/bindings/ata/qcom-sata.txt +++ /dev/null @@ -1,48 +0,0 @@ -* Qualcomm AHCI SATA Controller - -SATA nodes are defined to describe on-chip Serial ATA controllers. -Each SATA controller should have its own node. - -Required properties: -- compatible : compatible list, must contain "generic-ahci" -- interrupts : -- reg : -- phys : Must contain exactly one entry as specified - in phy-bindings.txt -- phy-names : Must be "sata-phy" - -Required properties for "qcom,ipq806x-ahci" compatible: -- clocks : Must contain an entry for each entry in clock-names. -- clock-names : Shall be: - "slave_iface" - Fabric port AHB clock for SATA - "iface" - AHB clock - "core" - core clock - "rxoob" - RX out-of-band clock - "pmalive" - Power Module Alive clock -- assigned-clocks : Shall be: - SATA_RXOOB_CLK - SATA_PMALIVE_CLK -- assigned-clock-rates : Shall be: - 100Mhz (100000000) for SATA_RXOOB_CLK - 100Mhz (100000000) for SATA_PMALIVE_CLK - -Example: - sata@29000000 { - compatible = "qcom,ipq806x-ahci", "generic-ahci"; - reg = <0x29000000 0x180>; - - interrupts = <0 209 0x0>; - - clocks = <&gcc SFAB_SATA_S_H_CLK>, - <&gcc SATA_H_CLK>, - <&gcc SATA_A_CLK>, - <&gcc SATA_RXOOB_CLK>, - <&gcc SATA_PMALIVE_CLK>; - clock-names = "slave_iface", "iface", "core", - "rxoob", "pmalive"; - assigned-clocks = <&gcc SATA_RXOOB_CLK>, <&gcc SATA_PMALIVE_CLK>; - assigned-clock-rates = <100000000>, <100000000>; - - phys = <&sata_phy>; - phy-names = "sata-phy"; - };