Message ID | 20240702024735.1152293-4-ipylypiv@google.com |
---|---|
State | New |
Headers | show |
Series | ATA PASS-THROUGH sense data fixes | expand |
On 7/2/24 04:47, Igor Pylypiv wrote: > SAT-5 revision 8 specification removed the text about the ANSI INCITS > 431-2007 compliance which was requiring SCSI/ATA Translation (SAT) to > return descriptor format sense data for the ATA PASS-THROUGH commands > regardless of the setting of the D_SENSE bit. > > Let's honor the D_SENSE bit for ATA PASS-THROUGH commands while > generating the "ATA PASS-THROUGH INFORMATION AVAILABLE" sense data. > > SAT-5 revision 7 > ================ > > 12.2.2.8 Fixed format sense data > > Table 212 shows the fields returned in the fixed format sense data > (see SPC-5) for ATA PASS-THROUGH commands. SATLs compliant with ANSI > INCITS 431-2007, SCSI/ATA Translation (SAT) return descriptor format > sense data for the ATA PASS-THROUGH commands regardless of the setting > of the D_SENSE bit. > > SAT-5 revision 8 > ================ > > 12.2.2.8 Fixed format sense data > > Table 211 shows the fields returned in the fixed format sense data > (see SPC-5) for ATA PASS-THROUGH commands. > > Cc: stable@vger.kernel.org # 4.19+ > Reported-by: Niklas Cassel <cassel@kernel.org> > Closes: https://lore.kernel.org/linux-ide/Zn1WUhmLglM4iais@ryzen.lan > Reviewed-by: Niklas Cassel <cassel@kernel.org> > Signed-off-by: Igor Pylypiv <ipylypiv@google.com> > --- > drivers/ata/libata-scsi.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index b59cbb5ce5a6..076fbeadce01 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -941,11 +941,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) > &sense_key, &asc, &ascq); > ata_scsi_set_sense(qc->dev, cmd, sense_key, asc, ascq); > } else { > - /* > - * ATA PASS-THROUGH INFORMATION AVAILABLE > - * Always in descriptor format sense. > - */ > - scsi_build_sense(cmd, 1, RECOVERED_ERROR, 0, 0x1D); > + /* ATA PASS-THROUGH INFORMATION AVAILABLE */ > + ata_scsi_set_sense(qc->dev, cmd, RECOVERED_ERROR, 0, 0x1D); > } > } > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index b59cbb5ce5a6..076fbeadce01 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -941,11 +941,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc) &sense_key, &asc, &ascq); ata_scsi_set_sense(qc->dev, cmd, sense_key, asc, ascq); } else { - /* - * ATA PASS-THROUGH INFORMATION AVAILABLE - * Always in descriptor format sense. - */ - scsi_build_sense(cmd, 1, RECOVERED_ERROR, 0, 0x1D); + /* ATA PASS-THROUGH INFORMATION AVAILABLE */ + ata_scsi_set_sense(qc->dev, cmd, RECOVERED_ERROR, 0, 0x1D); } }