| Message ID | 20230915201626.4180606-1-robh@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: ata: pata-common: Add missing additionalProperties on child nodes | expand |
On Fri, Sep 15, 2023 at 03:16:20PM -0500, Rob Herring wrote: > The PATA child node schema is missing constraints to prevent unknown > properties. As none of the users of this common binding extend the child > nodes with additional properties, adding "additionalProperties: false" > here is sufficient. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/ata/pata-common.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml > index 337ddf1113c4..4e867dd4d402 100644 > --- a/Documentation/devicetree/bindings/ata/pata-common.yaml > +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml > @@ -38,6 +38,7 @@ patternProperties: > ID number 0 and the slave drive will have ID number 1. The PATA port > nodes will be named "ide-port". > type: object > + additionalProperties: false > > properties: > reg: > -- > 2.40.1 >
On 2023/09/15 13:16, Rob Herring wrote: > The PATA child node schema is missing constraints to prevent unknown > properties. As none of the users of this common binding extend the child > nodes with additional properties, adding "additionalProperties: false" > here is sufficient. > > Signed-off-by: Rob Herring <robh@kernel.org> Applied to for-6.6-fixes. Thanks ! > --- > Documentation/devicetree/bindings/ata/pata-common.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml > index 337ddf1113c4..4e867dd4d402 100644 > --- a/Documentation/devicetree/bindings/ata/pata-common.yaml > +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml > @@ -38,6 +38,7 @@ patternProperties: > ID number 0 and the slave drive will have ID number 1. The PATA port > nodes will be named "ide-port". > type: object > + additionalProperties: false > > properties: > reg:
diff --git a/Documentation/devicetree/bindings/ata/pata-common.yaml b/Documentation/devicetree/bindings/ata/pata-common.yaml index 337ddf1113c4..4e867dd4d402 100644 --- a/Documentation/devicetree/bindings/ata/pata-common.yaml +++ b/Documentation/devicetree/bindings/ata/pata-common.yaml @@ -38,6 +38,7 @@ patternProperties: ID number 0 and the slave drive will have ID number 1. The PATA port nodes will be named "ide-port". type: object + additionalProperties: false properties: reg:
The PATA child node schema is missing constraints to prevent unknown properties. As none of the users of this common binding extend the child nodes with additional properties, adding "additionalProperties: false" here is sufficient. Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/ata/pata-common.yaml | 1 + 1 file changed, 1 insertion(+)