diff mbox series

[v2,4/4] ata: pata_platform: Make use of GENMASK() macro

Message ID 20211221162614.25308-5-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series ata: pata_platform: Refurbish the driver | expand

Commit Message

Lad Prabhakar Dec. 21, 2021, 4:26 p.m. UTC 
Make use of GENMASK() macro instead of open coding.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1-->v2
* New patch
---
 drivers/ata/pata_platform.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Sergey Shtylyov Dec. 21, 2021, 6:44 p.m. UTC | #1 
On 12/21/21 7:26 PM, Lad Prabhakar wrote:

> Make use of GENMASK() macro instead of open coding.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
index 80e5cb12707e..118b332dae2d 100644
--- a/drivers/ata/pata_platform.c
+++ b/drivers/ata/pata_platform.c
@@ -244,8 +244,7 @@  static int pata_of_platform_get_pdata(struct platform_device *ofdev,
 
 	priv->use16bit = of_property_read_bool(dn, "ata-generic,use16bit");
 
-	priv->pio_mask = 1 << pio_mode;
-	priv->pio_mask |= (1 << pio_mode) - 1;
+	priv->pio_mask = GENMASK(pio_mode, 0);
 
 	return 0;
 }