diff mbox series

[71/73] pata_hpt3x2n: convert pr_err() calls

Message ID 20211208163255.114660-72-hare@suse.de
State New
Headers show
Series libata: rework logging, take II | expand

Commit Message

Hannes Reinecke Dec. 8, 2021, 4:32 p.m. UTC 
Convert pr_err() calls to dev_err()

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/ata/sata_gemini.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Damien Le Moal Dec. 9, 2021, 1:14 a.m. UTC | #1 
On 2021/12/09 1:32, Hannes Reinecke wrote:
> Convert pr_err() calls to dev_err()
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/ata/sata_gemini.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
> index f793564f3d78..440a63de20d0 100644
> --- a/drivers/ata/sata_gemini.c
> +++ b/drivers/ata/sata_gemini.c
> @@ -253,12 +253,12 @@ static int gemini_sata_bridge_init(struct sata_gemini *sg)
>  
>  	ret = clk_prepare_enable(sg->sata0_pclk);
>  	if (ret) {
> -		pr_err("failed to enable SATA0 PCLK\n");
> +		dev_err(dev, "failed to enable SATA0 PCLK\n");
>  		return ret;
>  	}
>  	ret = clk_prepare_enable(sg->sata1_pclk);
>  	if (ret) {
> -		pr_err("failed to enable SATA1 PCLK\n");
> +		dev_err(dev, "failed to enable SATA1 PCLK\n");
>  		clk_disable_unprepare(sg->sata0_pclk);
>  		return ret;
>  	}
> 

Why is this not part of the previous patch ?
Sergey Shtylyov Dec. 9, 2021, 8:09 a.m. UTC | #2 
On 08.12.2021 19:32, Hannes Reinecke wrote:

> Convert pr_err() calls to dev_err()
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>   drivers/ata/sata_gemini.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

   The subject doesn't match the patch itself. :-/

MBR, Sergey
diff mbox series

Patch

diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index f793564f3d78..440a63de20d0 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -253,12 +253,12 @@  static int gemini_sata_bridge_init(struct sata_gemini *sg)
 
 	ret = clk_prepare_enable(sg->sata0_pclk);
 	if (ret) {
-		pr_err("failed to enable SATA0 PCLK\n");
+		dev_err(dev, "failed to enable SATA0 PCLK\n");
 		return ret;
 	}
 	ret = clk_prepare_enable(sg->sata1_pclk);
 	if (ret) {
-		pr_err("failed to enable SATA1 PCLK\n");
+		dev_err(dev, "failed to enable SATA1 PCLK\n");
 		clk_disable_unprepare(sg->sata0_pclk);
 		return ret;
 	}