diff mbox series

[linux-next] include:libata: fix boolreturn.cocci warnings

Message ID 20210824060702.59006-1-deng.changcheng@zte.com.cn
State New
Headers show
Series [linux-next] include:libata: fix boolreturn.cocci warnings | expand

Commit Message

CGEL Aug. 24, 2021, 6:07 a.m. UTC 
From: Jing Yangyang <jing.yangyang@zte.com.cn>

./include/linux/libata.h:1462:8-9:WARNING: return of 0/1 in function
'ata_is_host_link' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
 include/linux/libata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jens Axboe Aug. 24, 2021, 4:11 p.m. UTC | #1 
On 8/24/21 12:07 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
> 
> ./include/linux/libata.h:1462:8-9:WARNING: return of 0/1 in function
> 'ata_is_host_link' with return type bool
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.

Applied, thanks.
diff mbox series

Patch

diff --git a/include/linux/libata.h b/include/linux/libata.h
index a2d1bae..860e63f 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1459,7 +1459,7 @@  static inline bool sata_pmp_attached(struct ata_port *ap)
 
 static inline bool ata_is_host_link(const struct ata_link *link)
 {
-	return 1;
+	return true;
 }
 #endif /* CONFIG_SATA_PMP */