From patchwork Thu Mar 18 08:51:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=P7fYXWgg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQ82N5qz9sWj for ; Thu, 18 Mar 2021 19:52:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhCRIwP (ORCPT ); Thu, 18 Mar 2021 04:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbhCRIv5 (ORCPT ); Thu, 18 Mar 2021 04:51:57 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8763DC06175F for ; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r15-20020a05600c35cfb029010e639ca09eso4913260wmq.1 for ; Thu, 18 Mar 2021 01:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aoLGrjaA86gEYNhPzBdhJFKTeunMjqb/nCBdLbMyrRo=; b=P7fYXWggStTWJ87VH6ccWK9NEZNIsOaKORnKXyLJTqXez6COXfwcLnSnSE+ursORem W2K+IED0ZIE7OoVpSVjUgHyif+UXHFSe/vVCviNpSRD5VdN4nxhNlXQchP5VBu8WOmqx ViY3LKbNm3J3iDcxt1KfmQ/K9pirPDC93Ml1ualQCpOsII0L/dZ6cCXdpRy17M1DDDc8 ZIz1EhyDpnx4aD+irzAB3Lh9Yhwgt4WfWxnovtsk/Yjubor6xTWmTW5hlvgMk32Z1a5y JywumIFxihRXZPJ3fpW5wWSLMncKmHSn+qsTcastNFZmgW62JUeaKxRhTxqCPGWi1EtX LUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aoLGrjaA86gEYNhPzBdhJFKTeunMjqb/nCBdLbMyrRo=; b=pEAXovLbSUe+vhS3AU3mTKs4PwK/XDm3qrFhOIbROanRhvxbGXOgAsOvdPNSWKtMf3 PHp3fCtGABI3z7Gy8g0qWSXlc0RoY5Ik9SSX5i84zPgH/9p8+iQhRFZkKgeHZ1t8bq+7 ljFXR2k3Mhg+Pt9owGUPnxqduO43FPCDikiUkZKuvkV1NPbjbr1npotXRKSKJTwvk29G hMgBnaMkbYQYenr6Mae2GmoP3727wAKInOYU+lRZ2u/A1a2UFKapMgvTT5PsAeZiEGeP RLlKQoZehN2erIEecmzqV/pPLx21FspzsE9deUeJsLo/WSlps8e5h2wF7dsj8CcxnhXk /CjA== X-Gm-Message-State: AOAM533TdassQ9o/VCBPWGeqaaG5owocmxRyOfd/JnpDu/9v4ffo+ijp 22OB6H4k+cods7hVmMbfDINwXosApuowvA== X-Google-Smtp-Source: ABdhPJwSvksHLUPPKG5u0cLbB8259uYmWTJcgL4zfB+XBygfRMGsA3fYXZfFeHbUs+uqn4X5byrctw== X-Received: by 2002:a1c:6309:: with SMTP id x9mr2547884wmb.62.1616057516258; Thu, 18 Mar 2021 01:51:56 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:51:55 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , Alan Cox , Torben Mathiasen , linux-ide@vger.kernel.org Subject: [PATCH 04/15] ata: pata_triflex: Repair some misnamed functions and fix some param descriptions Date: Thu, 18 Mar 2021 08:51:39 +0000 Message-Id: <20210318085150.3131936-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_triflex.c:143: warning: expecting prototype for triflex_dma_start(). Prototype was for triflex_bmdma_start() instead drivers/ata/pata_triflex.c:159: warning: Function parameter or member 'qc' not described in 'triflex_bmdma_stop' drivers/ata/pata_triflex.c:159: warning: expecting prototype for triflex_dma_stop(). Prototype was for triflex_bmdma_stop() instead Cc: Jens Axboe Cc: Alan Cox Cc: Torben Mathiasen Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_triflex.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/ata/pata_triflex.c b/drivers/ata/pata_triflex.c index 2a4d38b980261..8a033598e7e17 100644 --- a/drivers/ata/pata_triflex.c +++ b/drivers/ata/pata_triflex.c @@ -129,7 +129,7 @@ static void triflex_set_piomode(struct ata_port *ap, struct ata_device *adev) } /** - * triflex_dma_start - DMA start callback + * triflex_bmdma_start - DMA start callback * @qc: Command in progress * * Usually drivers set the DMA timing at the point the set_dmamode call @@ -146,9 +146,8 @@ static void triflex_bmdma_start(struct ata_queued_cmd *qc) } /** - * triflex_dma_stop - DMA stop callback - * @ap: ATA interface - * @adev: ATA device + * triflex_bmdma_stop - DMA stop callback + * @qc: ATA command * * We loaded new timings in dma_start, as a result we need to restore * the PIO timings in dma_stop so that the next command issue gets the