From patchwork Thu Mar 18 08:51:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1455182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=owBn+xS4; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4F1LQD0366z9sW1 for ; Thu, 18 Mar 2021 19:52:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229944AbhCRIwT (ORCPT ); Thu, 18 Mar 2021 04:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhCRIwG (ORCPT ); Thu, 18 Mar 2021 04:52:06 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CD0CC06174A for ; Thu, 18 Mar 2021 01:52:06 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so2850043wmj.1 for ; Thu, 18 Mar 2021 01:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8THP7/U46oj2AdA7yORlA1l0cGJIRsmbqUZT9U01N10=; b=owBn+xS4OiRerAuKPY02l2lKcDg4A7rfCxSZlOaV5n+p4Anewb0qiJgnRGois5rJ53 otiPAUHyB1hiJmM966DeXNQGH3Y/Vl5TNAyPGd9mNWF7yhCRp3LL9z4zkgLNfj40onmH miY9VIe/aPvbVgMkUH65Qgxe8KEtSs9fkM3dMCrXUIpohGmfGfQvnKt/kVI0O8sZ2xDA zVbl/T/SpSUdCh8n5+yuA3OZQfxRIBucBvs9ZHClC/zyv05YgKQla+7hTZLfoegwNwbr 8FDQsG7hBlEd6Fd42wAih5yRSgbFXMGjnHhTEbjb+RqqhmGBio7PbeRT1j4UlWgRWvQ0 tnfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8THP7/U46oj2AdA7yORlA1l0cGJIRsmbqUZT9U01N10=; b=sJaydDKqnRH/NqwbRSeLtcs+JRRQLDpAyL4GU/DVimxeN3fQpR+AkrZ3pJgodqCnEW fhuIpBcGan+YPRX1wDCa2kFxoMqbZtl4hrEVZyl3ytoLKfyoiBIiORNCOeQI6jN6f6wU pwwCmexlj7C6SGknLtknDWb+gZh6AzbhIks9XZnCFdCBN41mtyI7BgNn13/88kR9Hb2w 9Siz3B8EQ+DopAONLjznCR1/e3yLSw8oTPlTmYcORGiWuMssdhGLi0Zwe0x9CkNyWS+r 9yrHsYLTQ0KE0MKDuq0FzFXUp++XMpnEYpVP0uvzw6AYuXPh3zG4FYuGX54F3QycwzoV fGiw== X-Gm-Message-State: AOAM531HVWqyON2/3N1D2KQ961FZx9IIgNTjmT+jBb68AJ4MzyruyVyp ZHl7Inmt8LUL/wG55bknTAyOTA== X-Google-Smtp-Source: ABdhPJx9R9zd3as8Zx677i6YSfsUD2ksgApi6t1IlIfShE3hBRcdI0WVmZkNaqTIURd+qmu0fXnifg== X-Received: by 2002:a05:600c:3541:: with SMTP id i1mr2521821wmq.97.1616057525014; Thu, 18 Mar 2021 01:52:05 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id w131sm1526868wmb.8.2021.03.18.01.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 01:52:04 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 14/15] ata: libata-acpi: Fix function name and provide description for 'prev_gtf' Date: Thu, 18 Mar 2021 08:51:49 +0000 Message-Id: <20210318085150.3131936-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org> References: <20210318085150.3131936-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/libata-acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 224e3486e9a5d..7a7d6642edcc5 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -476,7 +476,7 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf) } /** - * ata_acpi_gtm_xfermode - determine xfermode from GTM parameter + * ata_acpi_gtm_xfermask - determine xfermode from GTM parameter * @dev: target device * @gtm: GTM parameter to use * @@ -624,6 +624,7 @@ static int ata_acpi_filter_tf(struct ata_device *dev, * ata_acpi_run_tf - send taskfile registers to host controller * @dev: target ATA device * @gtf: raw ATA taskfile register set (0x1f1 - 0x1f7) + * @prev_gtf: previous command * * Outputs ATA taskfile to standard ATA host controller. * Writes the control, feature, nsect, lbal, lbam, and lbah registers.