| Message ID | 20200204165547.115220-19-hare@suse.de |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | ata: kill ATA_DEBUG | expand |
On 2/4/20 5:55 PM, Hannes Reinecke wrote: > Reset is now logged with tracepoints, so the DPRINTK() calls can > be dropped. > > Signed-off-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/libahci.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > index c1bc973ecc16..1c6d98fab3a3 100644 > --- a/drivers/ata/libahci.c > +++ b/drivers/ata/libahci.c > @@ -1391,8 +1391,6 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, > bool fbs_disabled = false; > int rc; > > - DPRINTK("ENTER\n"); > - > /* prepare for SRST (AHCI-1.1 10.4.1) */ > rc = ahci_kick_engine(ap); > if (rc && rc != -EOPNOTSUPP) > @@ -1452,7 +1450,6 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, > if (fbs_disabled) > ahci_enable_fbs(ap); > > - DPRINTK("EXIT, class=%u\n", *class); > return 0; > > fail: > @@ -1474,8 +1471,6 @@ static int ahci_softreset(struct ata_link *link, unsigned int *class, > { > int pmp = sata_srst_pmp(link); > > - DPRINTK("ENTER\n"); > - > return ahci_do_softreset(link, class, pmp, deadline, ahci_check_ready); > } > EXPORT_SYMBOL_GPL(ahci_do_softreset); > @@ -1505,8 +1500,6 @@ static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class, > int rc; > u32 irq_sts; > > - DPRINTK("ENTER\n"); > - > rc = ahci_do_softreset(link, class, pmp, deadline, > ahci_bad_pmp_check_ready); > > @@ -1540,8 +1533,6 @@ int ahci_do_hardreset(struct ata_link *link, unsigned int *class, > struct ata_taskfile tf; > int rc; > > - DPRINTK("ENTER\n"); > - > hpriv->stop_engine(ap); > > /* clear D2H reception area to properly wait for D2H FIS */ > @@ -1557,7 +1548,6 @@ int ahci_do_hardreset(struct ata_link *link, unsigned int *class, > if (*online) > *class = ahci_dev_classify(ap); > > - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); > return rc; > } > EXPORT_SYMBOL_GPL(ahci_do_hardreset); >
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index c1bc973ecc16..1c6d98fab3a3 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1391,8 +1391,6 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, bool fbs_disabled = false; int rc; - DPRINTK("ENTER\n"); - /* prepare for SRST (AHCI-1.1 10.4.1) */ rc = ahci_kick_engine(ap); if (rc && rc != -EOPNOTSUPP) @@ -1452,7 +1450,6 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class, if (fbs_disabled) ahci_enable_fbs(ap); - DPRINTK("EXIT, class=%u\n", *class); return 0; fail: @@ -1474,8 +1471,6 @@ static int ahci_softreset(struct ata_link *link, unsigned int *class, { int pmp = sata_srst_pmp(link); - DPRINTK("ENTER\n"); - return ahci_do_softreset(link, class, pmp, deadline, ahci_check_ready); } EXPORT_SYMBOL_GPL(ahci_do_softreset); @@ -1505,8 +1500,6 @@ static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class, int rc; u32 irq_sts; - DPRINTK("ENTER\n"); - rc = ahci_do_softreset(link, class, pmp, deadline, ahci_bad_pmp_check_ready); @@ -1540,8 +1533,6 @@ int ahci_do_hardreset(struct ata_link *link, unsigned int *class, struct ata_taskfile tf; int rc; - DPRINTK("ENTER\n"); - hpriv->stop_engine(ap); /* clear D2H reception area to properly wait for D2H FIS */ @@ -1557,7 +1548,6 @@ int ahci_do_hardreset(struct ata_link *link, unsigned int *class, if (*online) *class = ahci_dev_classify(ap); - DPRINTK("EXIT, rc=%d, class=%u\n", rc, *class); return rc; } EXPORT_SYMBOL_GPL(ahci_do_hardreset);
Reset is now logged with tracepoints, so the DPRINTK() calls can be dropped. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/libahci.c | 10 ---------- 1 file changed, 10 deletions(-)