From patchwork Wed Dec 21 22:38:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 132747 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 148C9B71E7 for ; Thu, 22 Dec 2011 09:40:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218Ab1LUWk0 (ORCPT ); Wed, 21 Dec 2011 17:40:26 -0500 Received: from shards.monkeyblade.net ([198.137.202.13]:56268 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764Ab1LUWk0 (ORCPT ); Wed, 21 Dec 2011 17:40:26 -0500 Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id pBLMcBAP027043 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO); Wed, 21 Dec 2011 14:38:12 -0800 Date: Wed, 21 Dec 2011 17:38:10 -0500 (EST) Message-Id: <20111221.173810.971054965060472866.davem@davemloft.net> To: pawel.moll@arm.com CC: jgarzik@redhat.com, linux-ide@vger.kernel.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org Subject: pata_of_platform.c cannot build on sparc From: David Miller X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 21 Dec 2011 14:38:13 -0800 (PST) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org It depends upon CONFIG_OF_IRQ which not all CONFIG_OF platforms support, in particular sparc does not support CONFIG_OF_PLATFORM because it precomputes all IRQs at boot time when it scans the device tree so all of the CONFIG_OF_IRQ infrastructure to probe and resolve IRQs at driver probe time is wrong and completely unnecessary. Add the proper dependencies so that pata_of_platform.c doesn't get built on sparc. CONFIG_OF_IRQ was severely misdesigned, it should just NOP out on platforms where the architecture has the final IRQ values already like sparc does. But that's not how it was implemented at all, and now we're starting to have all of these drivers get hard dependencies on this mechanism and it's datastructures, and the resulting sparc build failures from time to time. Jeff, please push something like the following to Linus so that sparc's allmodconfig builds again. Thanks. -------------------- pata_of_platform: Add missing CONFIG_OF_IRQ dependency. Signed-off-by: David S. Miller --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 6bdedd7..cf047c4 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -820,7 +820,7 @@ config PATA_PLATFORM config PATA_OF_PLATFORM tristate "OpenFirmware platform device PATA support" - depends on PATA_PLATFORM && OF + depends on PATA_PLATFORM && OF && OF_IRQ help This option enables support for generic directly connected ATA devices commonly found on embedded systems with OpenFirmware