Message ID | 201001051939.07756.bzolnier@gmail.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Date: Tue, 5 Jan 2010 19:39:07 +0100 > We can fix it nowadays, though I worry that by fixing it we may be 'creating > competition' for 'officially blessed yet unmaintained' PATA stack... 8-) Not being able to unload a module is a bug isn't it? Bug fixes are always fine :-) I'll take a closer look at this then apply it, thanks Bart! -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am Mittwoch 06 Januar 2010 21:28:26 schrieb David Miller: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Date: Tue, 5 Jan 2010 19:39:07 +0100 > > > Not being able to unload a module is a bug isn't it? Bug fixes > are always fine :-) > > I'll take a closer look at this then apply it, thanks Bart! Funny what such trivial patch can reveal :) Regards, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Date: Tue, 5 Jan 2010 19:39:07 +0100 > - ide_pci_unregister_driver(&scc_pci_driver); > + pci_unregister_driver(&scc_pci_driver); As a side note I can't figure out how this driver can currently even build without errors before this patch. ide_pci_unregister_driver() isn't even defined anywhere these days. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Fri, 08 Jan 2010 00:13:02 -0800 (PST) > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Date: Tue, 5 Jan 2010 19:39:07 +0100 > >> - ide_pci_unregister_driver(&scc_pci_driver); >> + pci_unregister_driver(&scc_pci_driver); > > As a side note I can't figure out how this driver can currently even > build without errors before this patch. > > ide_pci_unregister_driver() isn't even defined anywhere these days. Ignore me, I'm an idiot, this code was commented out of course. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ide/scc_pata.c =================================================================== --- a/drivers/ide/scc_pata.c +++ b/drivers/ide/scc_pata.c @@ -872,20 +872,18 @@ static struct pci_driver scc_pci_driver .remove = __devexit_p(scc_remove), }; -static int scc_ide_init(void) +static int __init scc_ide_init(void) { return ide_pci_register_driver(&scc_pci_driver); } -module_init(scc_ide_init); -/* -- No exit code? -static void scc_ide_exit(void) +static void __exit scc_ide_exit(void) { - ide_pci_unregister_driver(&scc_pci_driver); + pci_unregister_driver(&scc_pci_driver); } -module_exit(scc_ide_exit); - */ +module_init(scc_ide_init); +module_exit(scc_ide_exit); MODULE_DESCRIPTION("PCI driver module for Toshiba SCC IDE"); MODULE_LICENSE("GPL");