From patchwork Wed Nov 25 17:03:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 39327 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 57965B7B68 for ; Thu, 26 Nov 2009 04:04:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758879AbZKYREE (ORCPT ); Wed, 25 Nov 2009 12:04:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759027AbZKYRED (ORCPT ); Wed, 25 Nov 2009 12:04:03 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:52887 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759023AbZKYREB (ORCPT ); Wed, 25 Nov 2009 12:04:01 -0500 Received: by mail-ew0-f219.google.com with SMTP id 19so593484ewy.21 for ; Wed, 25 Nov 2009 09:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:date:message-id :in-reply-to:references:subject; bh=ak7tdAmWAJ+wtfRIiQ39egKGg2P98usSE7iC1YWbZHk=; b=U/kB0JF5ZGOv6U5A7z45ghPtqzEhhGGwPv079CcDbWloqUAkrhzUNWsS5L8OUhH/eN h0KMNgYKWAxZJux96T5HFW3jj31dEJLwwOYJW74UtxCfBmwdUbyo0xk2luPBPrvezI4m UHOcoIiA/uDb4ylY2wIetTY2GWDMkv0oBSE8g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=IOsYo3uZRo33k46KMr6joAfi7RtayhCDV+HQKg4G62+KRrbnV3NiAYldujMxAYCI8q MWRJUT5v6/7TBOFknAFflBPsu4yh2sx0haSBeaDaahFvMNF/eITyYXZVUxz8O94JMgrB +8CFZvdHWrHYrv+5VYqs/jyU94y6WbSE/4Q6Y= Received: by 10.216.85.68 with SMTP id t46mr1309710wee.114.1259168646986; Wed, 25 Nov 2009 09:04:06 -0800 (PST) Received: from ?127.0.0.1? (chello089079027028.chello.pl [89.79.27.28]) by mx.google.com with ESMTPS id u14sm14658721gvf.19.2009.11.25.09.04.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 25 Nov 2009 09:04:06 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Wed, 25 Nov 2009 18:03:23 +0100 Message-Id: <20091125170323.5446.6849.sendpatchset@localhost> In-Reply-To: <20091125170218.5446.13513.sendpatchset@localhost> References: <20091125170218.5446.13513.sendpatchset@localhost> Subject: [PATCH 09/86] pata_atiixp: no need to program PIO timings for MWDMA Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] pata_atiixp: no need to program PIO timings for MWDMA Moreover the code to do it was buggy and programmed PIO timings even if they were already set to a desired values. There shouldn't be any problems with it as IDE atiixp host driver has been allowing separate PIO/MWDMA timings for last two years. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_atiixp.c | 15 --------------- 1 file changed, 15 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ata/pata_atiixp.c =================================================================== --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -107,7 +107,6 @@ static void atiixp_set_dmamode(struct at struct pci_dev *pdev = to_pci_dev(ap->host->dev); int dma = adev->dma_mode; int dn = 2 * ap->port_no + adev->devno; - int wanted_pio; if (adev->dma_mode >= XFER_UDMA_0) { u16 udma_mode_data; @@ -131,20 +130,6 @@ static void atiixp_set_dmamode(struct at pci_write_config_dword(pdev, ATIIXP_IDE_MWDMA_TIMING, mwdma_timing_data); } - /* - * We must now look at the PIO mode situation. We may need to - * adjust the PIO mode to keep the timings acceptable - */ - if (adev->dma_mode >= XFER_MW_DMA_2) - wanted_pio = 4; - else if (adev->dma_mode == XFER_MW_DMA_1) - wanted_pio = 3; - else if (adev->dma_mode == XFER_MW_DMA_0) - wanted_pio = 0; - else BUG(); - - if (adev->pio_mode != wanted_pio) - atiixp_set_pio_timing(ap, adev, wanted_pio); } /**