Message ID | 20091125170323.5446.6849.sendpatchset@localhost |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Wed, 25 Nov 2009 18:03:23 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_atiixp: no need to program PIO timings for MWDMA > > Moreover the code to do it was buggy and programmed PIO timings > even if they were already set to a desired values. > > There shouldn't be any problems with it as IDE atiixp host driver > has been allowing separate PIO/MWDMA timings for last two years. I need to take a look at the history of this - it got put there for a reason I am sure. Whether a right one I don't know. Needs running past AMD/ATI's maintainer anyway who should know. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_atiixp.c =================================================================== --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -107,7 +107,6 @@ static void atiixp_set_dmamode(struct at struct pci_dev *pdev = to_pci_dev(ap->host->dev); int dma = adev->dma_mode; int dn = 2 * ap->port_no + adev->devno; - int wanted_pio; if (adev->dma_mode >= XFER_UDMA_0) { u16 udma_mode_data; @@ -131,20 +130,6 @@ static void atiixp_set_dmamode(struct at pci_write_config_dword(pdev, ATIIXP_IDE_MWDMA_TIMING, mwdma_timing_data); } - /* - * We must now look at the PIO mode situation. We may need to - * adjust the PIO mode to keep the timings acceptable - */ - if (adev->dma_mode >= XFER_MW_DMA_2) - wanted_pio = 4; - else if (adev->dma_mode == XFER_MW_DMA_1) - wanted_pio = 3; - else if (adev->dma_mode == XFER_MW_DMA_0) - wanted_pio = 0; - else BUG(); - - if (adev->pio_mode != wanted_pio) - atiixp_set_pio_timing(ap, adev, wanted_pio); } /**