From patchwork Wed Nov 25 17:02:25 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 39323 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id C29C7B6F14 for ; Thu, 26 Nov 2009 04:04:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754295AbZKYRDI (ORCPT ); Wed, 25 Nov 2009 12:03:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758867AbZKYRDH (ORCPT ); Wed, 25 Nov 2009 12:03:07 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:52887 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754295AbZKYRDD (ORCPT ); Wed, 25 Nov 2009 12:03:03 -0500 Received: by mail-ew0-f219.google.com with SMTP id 19so593484ewy.21 for ; Wed, 25 Nov 2009 09:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:date:message-id :in-reply-to:references:subject; bh=VU6muPUu1rVh5oOL4wV2OSEjOoQi+cypUtXEVVaWMUM=; b=DPpZZu1XMz5l5fq2m61ul7woO/Vw4AxTSWfIH8mwQCkaaHI4OR7Qug/yv9WkhC6T3p PDSd6spCeD/nIPf2coZdh/5Qm+5UYJc5Ll+XmFQhaOrYdyk/OccOtkpZ1TSeaLab2S7z Fa/XQiZjlSkDmCyvveslppdALPqoth18a/NT0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:date:message-id:in-reply-to:references:subject; b=uLX6eo25SbDzB4nwt8au1nBo1WoSB9/5ySKSYNFiIxOT0SLuyY7GTlnu6wKR1aBlxX h352MU0e02mIMf+hKHQP2Hqo6XR9fu35j24Xa84w2qMAuIMbvQJutnkHBB5ErOISMSrb n+saeezOM9Oemb5hy9S2rM8DnbgDL4UCZXLzE= Received: by 10.216.90.203 with SMTP id e53mr124756wef.28.1259168589436; Wed, 25 Nov 2009 09:03:09 -0800 (PST) Received: from ?127.0.0.1? (chello089079027028.chello.pl [89.79.27.28]) by mx.google.com with ESMTPS id m5sm13761726gve.27.2009.11.25.09.03.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 25 Nov 2009 09:03:08 -0800 (PST) From: Bartlomiej Zolnierkiewicz To: linux-ide@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org Date: Wed, 25 Nov 2009 18:02:25 +0100 Message-Id: <20091125170225.5446.50868.sendpatchset@localhost> In-Reply-To: <20091125170218.5446.13513.sendpatchset@localhost> References: <20091125170218.5446.13513.sendpatchset@localhost> Subject: [PATCH 01/86] ata_piix: fix MWDMA handling on PIIX3 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: fix MWDMA handling on PIIX3 Fix erroneous check for ap->udma_mask in do_pata_set_dmamode() resulting in controller not being programmed properly for MWDMA. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ata/ata_piix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: b/drivers/ata/ata_piix.c =================================================================== --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c @@ -869,10 +869,10 @@ static void do_pata_set_dmamode(struct a (timings[pio][1] << 8); } - if (ap->udma_mask) { + if (ap->udma_mask) udma_enable &= ~(1 << devid); - pci_write_config_word(dev, master_port, master_data); - } + + pci_write_config_word(dev, master_port, master_data); } /* Don't scribble on 0x48 if the controller does not support UDMA */ if (ap->udma_mask)