Message ID | 1617915315-13639-2-git-send-email-skomatineni@nvidia.com |
---|---|
State | New |
Headers | show |
Series | [v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present | expand |
08.04.2021 23:55, Sowjanya Komatineni пишет: > This patch adds check to call legacy power domain API > tegra_powergate_power_off() only when PM domain is not present. > > This is a follow-up patch to Tegra186 AHCI support patch series. > --- > drivers/ata/ahci_tegra.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c > index 56612af..4fb94db 100644 > --- a/drivers/ata/ahci_tegra.c > +++ b/drivers/ata/ahci_tegra.c > @@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) > disable_power: > clk_disable_unprepare(tegra->sata_clk); > > - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > + if (!tegra->pdev->dev.pm_domain) > + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > > disable_regulators: > regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); > @@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) > reset_control_assert(tegra->sata_cold_rst); > > clk_disable_unprepare(tegra->sata_clk); > - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > + if (!tegra->pdev->dev.pm_domain) > + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > > regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); > } > Looks good, thank you. Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On Thu, Apr 08, 2021 at 01:55:15PM -0700, Sowjanya Komatineni wrote: > This patch adds check to call legacy power domain API > tegra_powergate_power_off() only when PM domain is not present. > > This is a follow-up patch to Tegra186 AHCI support patch series. > --- > drivers/ata/ahci_tegra.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On 4/8/21 2:55 PM, Sowjanya Komatineni wrote: > This patch adds check to call legacy power domain API > tegra_powergate_power_off() only when PM domain is not present. Applied, and added a Fixes line.
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index 56612af..4fb94db 100644 --- a/drivers/ata/ahci_tegra.c +++ b/drivers/ata/ahci_tegra.c @@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv) disable_power: clk_disable_unprepare(tegra->sata_clk); - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); + if (!tegra->pdev->dev.pm_domain) + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); disable_regulators: regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); @@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) reset_control_assert(tegra->sata_cold_rst); clk_disable_unprepare(tegra->sata_clk); - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); + if (!tegra->pdev->dev.pm_domain) + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); }