| Message ID | 1461262544-115408-4-git-send-email-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 04/21/2016 09:15 PM, Andy Shevchenko wrote: > The original code states: > > Make sure a LLI block is not created that will span 8K max FIS > boundary. If the block spans such a FIS boundary, there is a chance > that a DMA burst will cross that boundary -- this results in an error > in the host controller. > > Since we have switched to generic DMAengine API we satisfy above by setting > dma_boundary value to 0x1fff. > > Suggested-by: Mans Rullgard <mans@mansr.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/ata/sata_dwc_460ex.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c > index 7f95389..aee8873 100644 > --- a/drivers/ata/sata_dwc_460ex.c > +++ b/drivers/ata/sata_dwc_460ex.c > @@ -1151,7 +1151,13 @@ static struct scsi_host_template sata_dwc_sht = { > */ > .sg_tablesize = LIBATA_MAX_PRD, > /* .can_queue = ATA_MAX_QUEUE, */ > - .dma_boundary = ATA_DMA_BOUNDARY, > + /* > + * Make sure a LLI block is not created that will span 8K max FIS > + * boundary. If the block spans such a FIS boundary, there is a chance > + * that a DMA burst will cross that boundary -- this results in an > + * error in the host controller. > + */ > + .dma_boundary = 0x1fff /* ATA_DMA_BOUNDARY */, Not ~0x1fff? [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 7f95389..aee8873 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1151,7 +1151,13 @@ static struct scsi_host_template sata_dwc_sht = { */ .sg_tablesize = LIBATA_MAX_PRD, /* .can_queue = ATA_MAX_QUEUE, */ - .dma_boundary = ATA_DMA_BOUNDARY, + /* + * Make sure a LLI block is not created that will span 8K max FIS + * boundary. If the block spans such a FIS boundary, there is a chance + * that a DMA burst will cross that boundary -- this results in an + * error in the host controller. + */ + .dma_boundary = 0x1fff /* ATA_DMA_BOUNDARY */, }; static struct ata_port_operations sata_dwc_ops = {
The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results in an error in the host controller. Since we have switched to generic DMAengine API we satisfy above by setting dma_boundary value to 0x1fff. Suggested-by: Mans Rullgard <mans@mansr.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/ata/sata_dwc_460ex.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)