| Message ID | 1411991947-130166-34-git-send-email-hare@suse.de |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote: > libata already uses an internal buffer, so we should be using > __scsi_print_command() here. > > Cc: Tejun Heo <tj@kernel.org> > Cc: linux-ide@vger.kernel.org > Cc: LKML <linux-kernel@vger.kernel.org> > Signed-off-by: Hannes Reinecke <hare@suse.de> Applied to libata/for-3.18. Thanks.
On 09/29/2014 04:06 PM, Tejun Heo wrote: > On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote: >> libata already uses an internal buffer, so we should be using >> __scsi_print_command() here. >> >> Cc: Tejun Heo <tj@kernel.org> >> Cc: linux-ide@vger.kernel.org >> Cc: LKML <linux-kernel@vger.kernel.org> >> Signed-off-by: Hannes Reinecke <hare@suse.de> > > Applied to libata/for-3.18. > > Thanks. > Errm. Nice that you did, but it sort of relies for patches 01-32 to be applied previously. I'd rather apply your Signed-off-by: to the patch and have it routed through the SCSI tree; that way we're sure it'll only be applied if the previous patches are in. Can you please pull it from libata to avoid build issues? Cheers, Hannes
On Mon, Sep 29, 2014 at 04:10:30PM +0200, Hannes Reinecke wrote: > On 09/29/2014 04:06 PM, Tejun Heo wrote: > > On Mon, Sep 29, 2014 at 01:59:02PM +0200, Hannes Reinecke wrote: > >> libata already uses an internal buffer, so we should be using > >> __scsi_print_command() here. > >> > >> Cc: Tejun Heo <tj@kernel.org> > >> Cc: linux-ide@vger.kernel.org > >> Cc: LKML <linux-kernel@vger.kernel.org> > >> Signed-off-by: Hannes Reinecke <hare@suse.de> > > > > Applied to libata/for-3.18. > > > > Thanks. > > > Errm. > Nice that you did, but it sort of relies for patches 01-32 to be > applied previously. > I'd rather apply your Signed-off-by: to the patch and have it > routed through the SCSI tree; that way we're sure it'll only be > applied if the previous patches are in. > > Can you please pull it from libata to avoid build issues? Ah, okay, pulled it. Please feel free to add Acked-by: Tejun Heo <tj@kernel.org> Thanks.
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index dad83df..74c5652 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2509,15 +2509,11 @@ static void ata_eh_link_report(struct ata_link *link) if (ata_is_atapi(qc->tf.protocol)) { if (qc->scsicmd) - scsi_print_command(qc->scsicmd); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + qc->scsicmd->cmnd); else - snprintf(cdb_buf, sizeof(cdb_buf), - "cdb %02x %02x %02x %02x %02x %02x %02x %02x " - "%02x %02x %02x %02x %02x %02x %02x %02x\n ", - cdb[0], cdb[1], cdb[2], cdb[3], - cdb[4], cdb[5], cdb[6], cdb[7], - cdb[8], cdb[9], cdb[10], cdb[11], - cdb[12], cdb[13], cdb[14], cdb[15]); + __scsi_print_command(cdb_buf, sizeof(cdb_buf), + (unsigned char *)cdb); } else { const char *descr = ata_get_cmd_descript(cmd->command); if (descr)
libata already uses an internal buffer, so we should be using __scsi_print_command() here. Cc: Tejun Heo <tj@kernel.org> Cc: linux-ide@vger.kernel.org Cc: LKML <linux-kernel@vger.kernel.org> Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/ata/libata-eh.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)