mbox series

[0/2] Improve drive spinup on resume

Message ID 20231012071800.468868-1-dlemoal@kernel.org
Headers show
Series Improve drive spinup on resume | expand

Message

Damien Le Moal Oct. 12, 2023, 7:17 a.m. UTC 
Two patches to improve disk spinup on resume:
 - Patch 1: Move the spinup operation to after the drive revalidation to
   ensure that the VERIFY command is executed with the link speed
   properly setup.
 - Patch 2: Attempt to spinup the drive only if it is not already spun
   up.

Geert,

It would be great if you could test this with your RCAR setup. I ran
this on my usual machines and qemu. All good. But your setup has been
useful to flush out issues before :)
Thanks !

Damien Le Moal (2):
  ata: libata-eh: Spinup disk on resume after revalidation
  ata: libata-core: Improve ata_dev_power_set_active()

 drivers/ata/libata-core.c | 34 ++++++++++++++++++++++++++++++++++
 drivers/ata/libata-eh.c   | 20 +++++++++++---------
 2 files changed, 45 insertions(+), 9 deletions(-)

Comments

Geert Uytterhoeven Oct. 12, 2023, 11:47 a.m. UTC | #1 
Hi Damien,

On Thu, Oct 12, 2023 at 9:18 AM Damien Le Moal <dlemoal@kernel.org> wrote:
> Two patches to improve disk spinup on resume:
>  - Patch 1: Move the spinup operation to after the drive revalidation to
>    ensure that the VERIFY command is executed with the link speed
>    properly setup.
>  - Patch 2: Attempt to spinup the drive only if it is not already spun
>    up.

Thanks for your series!

> Geert,
>
> It would be great if you could test this with your RCAR setup. I ran
> this on my usual machines and qemu. All good. But your setup has been
> useful to flush out issues before :)

Nothing special to see here...
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert