Return-Path: <linux-ide-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tSM/RgFD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M8H8ZicV; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ide-owner@vger.kernel.org; receiver=<UNKNOWN>) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4J9Mwf0Cp3z9sRK for <incoming@patchwork.ozlabs.org>; Fri, 10 Dec 2021 18:29:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232117AbhLJHcy (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Fri, 10 Dec 2021 02:32:54 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:34822 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237508AbhLJHcx (ORCPT <rfc822;linux-ide@vger.kernel.org>); Fri, 10 Dec 2021 02:32:53 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9421B210EB; Fri, 10 Dec 2021 07:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1639121358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iKGAwfnPYMMneX9/rlSEcm09TjTstKOLXzEBTNSrT7A=; b=tSM/RgFDKaDoI1lSTC+SbwGxaAwJxWtpSGGD8fH5zllMa/fNIFNbZJpvuyYL6SELjsl7rm sxPSrYVPlGUrTJq8BwC717YNxG1W+C0lWpqqqPePIfAcVB0dHHV7I525TSRvTkpvG/Itqd UW6Z1/5qAFrGRexIxQqwDWTN/uYFiqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1639121358; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iKGAwfnPYMMneX9/rlSEcm09TjTstKOLXzEBTNSrT7A=; b=M8H8ZicV5iKbiSvSm3k1jkmkXfQ14+vPZy5XbFpLQ3+/Ic3nifNuZIXSdTfnOGhk3u8v5p EbWcKM8nOFBqKSAQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 65920A3B92; Fri, 10 Dec 2021 07:29:18 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 583985192021; Fri, 10 Dec 2021 08:29:18 +0100 (CET) From: Hannes Reinecke <hare@suse.de> To: Damien LeMoal <damien.lemoal@wdc.com> Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de> Subject: [PATCHv2 00/68] libata: rework logging, take II Date: Fri, 10 Dec 2021 08:27:57 +0100 Message-Id: <20211210072905.15666-1-hare@suse.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-ide.vger.kernel.org> X-Mailing-List: linux-ide@vger.kernel.org
Hi all, after some prodding from individual persons I've resurrected my patchset to put libata logging on a even keel, and use structured logging for everything. So this patch does away with DPRINTK, ATA_DEBUG or ata_msg_XXX() calls, and moves everything over to structured logging (ie the dev_XXX() calls). Additionally I've added tracepoints to trace command flow, error handling, host state machine etc. So everything is looking far saner now. As usual, comments and reviews are welcome. I know that the device names suck. Blame Tejun. Changes to the original submission: - Converted all printk() and pr_XXX() calls, too - Included reviews from Damien - Included reviews from Sergey Hannes Reinecke (68): libata: remove pointless debugging messages libata: whitespace cleanup libata: Add ata_port_classify() helper libata: move ata_dump_id() to dynamic debugging libata: sanitize ATA_HORKAGE_DUMP_ID libata: add reset tracepoints libata: add qc_prep tracepoint libata: tracepoints for bus-master DMA libata-sff: tracepoints for HSM state machine libata-scsi: drop DPRINTK calls for cdb translation libata: add tracepoints for ATA error handling libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros libata: revamp ata_get_cmd_descript() libata: move DPRINTK to ata debugging sata_mv: kill 'port' argument in mv_dump_all_regs() sata_mv: replace DPRINTK with dynamic debugging pata_octeon_cf: remove DPRINTK() macro in interrupt context pdc_adma: Remove DPRINTK call sata_fsl: move DPRINTK to ata debugging sata_rcar: replace DPRINTK() with ata_port_dbg() sata_qstor: replace DPRINTK() with ata_port_dbg() pata_pdc2027x: Replace PDPRINTK() with standard ata logging libata: remove pointless VPRINTK() calls ahci: Drop pointless VPRINTK() calls and convert the remaining ones pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one pata_via: Drop pointless VPRINTK() calls sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones sata_qstor: Drop pointless VPRINTK() calls sata_rcar: Drop pointless VPRINTK() calls sata_inic162x: Drop pointless VPRINTK() calls sata_mv: Drop pointless VPRINTK() call and convert the remaining one sata_nv: drop pointless VPRINTK() calls and convert remaining ones sata_fsl: convert VPRINTK() calls to ata_port_dbg() sata_sil: Drop pointless VPRINTK() calls sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones sata_sx4: add module parameter 'dimm_test' libata: drop ata_msg_error() and ata_msg_intr() libata: drop ata_msg_ctl() libata: drop ata_msg_malloc() libata: drop ata_msg_warn() libata: drop ata_msg_probe() libata: drop ata_msg_info() libata: drop ata_msg_drv() libata: remove 'new' ata message handling libata: remove debug compilation switches pata_atp867x: convert printk() calls pata_cmd640: convert printk() calls pata_cmd64x: convert printk() calls pata_cs5520: convert printk() calls pata_cs5536: convert printk() calls pata_cypress: convert printk() calls pata_it821x: convert printk() calls pata_marvell: convert printk() calls pata_rz1000: convert printk() calls pata_serverworks: convert printk() calls pata_sil680: convert printk() calls sata_sx4: convert printk() calls sata_mv: convert remaining printk() to structured logging pata_hpt37x: convert pr_XXX() calls pata_octeon_cf: Replace pr_XXX() calls with structured logging pata_hpt3x2n: convert pr_XXX() calls sata_gemini: convert pr_err() calls pata_hpt366: convert pr_warn() calls libata-scsi: rework ata_dump_status to avoid using pr_cont() sata_dwc_460ex: drop DEBUG_NCQ sata_dwc_460ex: remove 'checkstatus' argument sata_dwc_460ex: Remove debug compile options drivers/ata/Kconfig | 12 - drivers/ata/acard-ahci.c | 4 - drivers/ata/ahci.c | 13 +- drivers/ata/ahci_qoriq.c | 4 - drivers/ata/ahci_xgene.c | 4 - drivers/ata/ata_piix.c | 11 +- drivers/ata/libahci.c | 33 +-- drivers/ata/libata-acpi.c | 69 +++--- drivers/ata/libata-core.c | 225 ++++------------- drivers/ata/libata-eh.c | 70 +++--- drivers/ata/libata-pmp.c | 8 - drivers/ata/libata-sata.c | 5 - drivers/ata/libata-scsi.c | 111 ++------- drivers/ata/libata-sff.c | 88 +++---- drivers/ata/libata-trace.c | 47 ++++ drivers/ata/libata-transport.c | 45 +++- drivers/ata/libata.h | 5 +- drivers/ata/pata_arasan_cf.c | 3 + drivers/ata/pata_atp867x.c | 29 +-- drivers/ata/pata_cmd640.c | 2 +- drivers/ata/pata_cmd64x.c | 4 +- drivers/ata/pata_cs5520.c | 4 +- drivers/ata/pata_cs5536.c | 4 +- drivers/ata/pata_cypress.c | 2 +- drivers/ata/pata_ep93xx.c | 1 - drivers/ata/pata_hpt366.c | 5 +- drivers/ata/pata_hpt37x.c | 20 +- drivers/ata/pata_hpt3x2n.c | 12 +- drivers/ata/pata_it821x.c | 43 ++-- drivers/ata/pata_ixp4xx_cf.c | 6 +- drivers/ata/pata_marvell.c | 9 +- drivers/ata/pata_octeon_cf.c | 48 +--- drivers/ata/pata_pdc2027x.c | 71 +++--- drivers/ata/pata_pdc202xx_old.c | 2 - drivers/ata/pata_rz1000.c | 4 +- drivers/ata/pata_serverworks.c | 4 +- drivers/ata/pata_sil680.c | 9 +- drivers/ata/pata_via.c | 12 - drivers/ata/pdc_adma.c | 33 +-- drivers/ata/sata_dwc_460ex.c | 120 ++------- drivers/ata/sata_fsl.c | 165 +++++-------- drivers/ata/sata_gemini.c | 4 +- drivers/ata/sata_inic162x.c | 4 +- drivers/ata/sata_mv.c | 130 +++++----- drivers/ata/sata_nv.c | 54 ++--- drivers/ata/sata_promise.c | 31 +-- drivers/ata/sata_qstor.c | 15 +- drivers/ata/sata_rcar.c | 26 +- drivers/ata/sata_sil.c | 1 - drivers/ata/sata_sil24.c | 5 +- drivers/ata/sata_sx4.c | 148 ++++-------- include/linux/libata.h | 99 ++------ include/trace/events/libata.h | 416 +++++++++++++++++++++++++++++++- 53 files changed, 1049 insertions(+), 1250 deletions(-)
Hi all, after some prodding from individual persons I've resurrected my patchset to put libata logging on a even keel, and use structured logging for everything. So this patch does away with DPRINTK, ATA_DEBUG or ata_msg_XXX() calls, and moves everything over to structured logging (ie the dev_XXX() calls). Additionally I've added tracepoints to trace command flow, error handling, host state machine etc. So everything is looking far saner now. As usual, comments and reviews are welcome. I know that the device names suck. Blame Tejun. Changes to the original submission: - Converted all printk() and pr_XXX() calls, too - Included reviews from Damien - Included reviews from Sergey Hannes Reinecke (68): libata: remove pointless debugging messages libata: whitespace cleanup libata: Add ata_port_classify() helper libata: move ata_dump_id() to dynamic debugging libata: sanitize ATA_HORKAGE_DUMP_ID libata: add reset tracepoints libata: add qc_prep tracepoint libata: tracepoints for bus-master DMA libata-sff: tracepoints for HSM state machine libata-scsi: drop DPRINTK calls for cdb translation libata: add tracepoints for ATA error handling libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros libata: revamp ata_get_cmd_descript() libata: move DPRINTK to ata debugging sata_mv: kill 'port' argument in mv_dump_all_regs() sata_mv: replace DPRINTK with dynamic debugging pata_octeon_cf: remove DPRINTK() macro in interrupt context pdc_adma: Remove DPRINTK call sata_fsl: move DPRINTK to ata debugging sata_rcar: replace DPRINTK() with ata_port_dbg() sata_qstor: replace DPRINTK() with ata_port_dbg() pata_pdc2027x: Replace PDPRINTK() with standard ata logging libata: remove pointless VPRINTK() calls ahci: Drop pointless VPRINTK() calls and convert the remaining ones pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining one pata_via: Drop pointless VPRINTK() calls sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones sata_qstor: Drop pointless VPRINTK() calls sata_rcar: Drop pointless VPRINTK() calls sata_inic162x: Drop pointless VPRINTK() calls sata_mv: Drop pointless VPRINTK() call and convert the remaining one sata_nv: drop pointless VPRINTK() calls and convert remaining ones sata_fsl: convert VPRINTK() calls to ata_port_dbg() sata_sil: Drop pointless VPRINTK() calls sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones sata_sx4: add module parameter 'dimm_test' libata: drop ata_msg_error() and ata_msg_intr() libata: drop ata_msg_ctl() libata: drop ata_msg_malloc() libata: drop ata_msg_warn() libata: drop ata_msg_probe() libata: drop ata_msg_info() libata: drop ata_msg_drv() libata: remove 'new' ata message handling libata: remove debug compilation switches pata_atp867x: convert printk() calls pata_cmd640: convert printk() calls pata_cmd64x: convert printk() calls pata_cs5520: convert printk() calls pata_cs5536: convert printk() calls pata_cypress: convert printk() calls pata_it821x: convert printk() calls pata_marvell: convert printk() calls pata_rz1000: convert printk() calls pata_serverworks: convert printk() calls pata_sil680: convert printk() calls sata_sx4: convert printk() calls sata_mv: convert remaining printk() to structured logging pata_hpt37x: convert pr_XXX() calls pata_octeon_cf: Replace pr_XXX() calls with structured logging pata_hpt3x2n: convert pr_XXX() calls sata_gemini: convert pr_err() calls pata_hpt366: convert pr_warn() calls libata-scsi: rework ata_dump_status to avoid using pr_cont() sata_dwc_460ex: drop DEBUG_NCQ sata_dwc_460ex: remove 'checkstatus' argument sata_dwc_460ex: Remove debug compile options drivers/ata/Kconfig | 12 - drivers/ata/acard-ahci.c | 4 - drivers/ata/ahci.c | 13 +- drivers/ata/ahci_qoriq.c | 4 - drivers/ata/ahci_xgene.c | 4 - drivers/ata/ata_piix.c | 11 +- drivers/ata/libahci.c | 33 +-- drivers/ata/libata-acpi.c | 69 +++--- drivers/ata/libata-core.c | 225 ++++------------- drivers/ata/libata-eh.c | 70 +++--- drivers/ata/libata-pmp.c | 8 - drivers/ata/libata-sata.c | 5 - drivers/ata/libata-scsi.c | 111 ++------- drivers/ata/libata-sff.c | 88 +++---- drivers/ata/libata-trace.c | 47 ++++ drivers/ata/libata-transport.c | 45 +++- drivers/ata/libata.h | 5 +- drivers/ata/pata_arasan_cf.c | 3 + drivers/ata/pata_atp867x.c | 29 +-- drivers/ata/pata_cmd640.c | 2 +- drivers/ata/pata_cmd64x.c | 4 +- drivers/ata/pata_cs5520.c | 4 +- drivers/ata/pata_cs5536.c | 4 +- drivers/ata/pata_cypress.c | 2 +- drivers/ata/pata_ep93xx.c | 1 - drivers/ata/pata_hpt366.c | 5 +- drivers/ata/pata_hpt37x.c | 20 +- drivers/ata/pata_hpt3x2n.c | 12 +- drivers/ata/pata_it821x.c | 43 ++-- drivers/ata/pata_ixp4xx_cf.c | 6 +- drivers/ata/pata_marvell.c | 9 +- drivers/ata/pata_octeon_cf.c | 48 +--- drivers/ata/pata_pdc2027x.c | 71 +++--- drivers/ata/pata_pdc202xx_old.c | 2 - drivers/ata/pata_rz1000.c | 4 +- drivers/ata/pata_serverworks.c | 4 +- drivers/ata/pata_sil680.c | 9 +- drivers/ata/pata_via.c | 12 - drivers/ata/pdc_adma.c | 33 +-- drivers/ata/sata_dwc_460ex.c | 120 ++------- drivers/ata/sata_fsl.c | 165 +++++-------- drivers/ata/sata_gemini.c | 4 +- drivers/ata/sata_inic162x.c | 4 +- drivers/ata/sata_mv.c | 130 +++++----- drivers/ata/sata_nv.c | 54 ++--- drivers/ata/sata_promise.c | 31 +-- drivers/ata/sata_qstor.c | 15 +- drivers/ata/sata_rcar.c | 26 +- drivers/ata/sata_sil.c | 1 - drivers/ata/sata_sil24.c | 5 +- drivers/ata/sata_sx4.c | 148 ++++-------- include/linux/libata.h | 99 ++------ include/trace/events/libata.h | 416 +++++++++++++++++++++++++++++++- 53 files changed, 1049 insertions(+), 1250 deletions(-)