From patchwork Mon Sep 30 14:15:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 279162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF31F2C00A6 for ; Tue, 1 Oct 2013 00:15:27 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343Ab3I3OP0 (ORCPT ); Mon, 30 Sep 2013 10:15:26 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:36601 "EHLO mail-ee0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754211Ab3I3OP0 (ORCPT ); Mon, 30 Sep 2013 10:15:26 -0400 Received: by mail-ee0-f45.google.com with SMTP id c50so2732499eek.4 for ; Mon, 30 Sep 2013 07:15:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :content-type; bh=aHgRK4qOYGH6xe0mETrmaCiSxlYjTdY/w/BbMiWzMR0=; b=nLeVAKmkDCc5pPuKrK5AfhR/8QjBb2m1GbhOksohouo8Ina2d7L1miOIG3kN2Bl3wE oCML+ziJXP3a2zxWWhWCpY7KggoHgjbmtk/MnUFrmnr5Z76hfoF0KWElfVdc2uelxEuu +5VD8eZtugCgo8gQnF45FaR8/l9AE30yE0IZE5BxbnPGxfApirOZq7CKPoLs5DgR7Ktv /6TZX0lhMZsutvxITad4ueig/V5gZxhfgm4i8MZvkrw7G9KKjrZCkmJc6ElyKn3GPiK6 4s7pCboBPpqJZvR7tSX2MVcgcoOJ8psmDR+v3RH+TsiXAPJx9kpaLPPtH8brTSZpEYOe SHrw== X-Gm-Message-State: ALoCoQlrhRYtZFiRy2n+O7fQ/kbS3WTB6E3mtnVxondgTUU9ROxRfhJhsAA/cwnmdu8FdpnXuvVC X-Received: by 10.15.91.3 with SMTP id r3mr38013107eez.4.1380550525194; Mon, 30 Sep 2013 07:15:25 -0700 (PDT) Received: from localhost (nat-63.starnet.cz. [178.255.168.63]) by mx.google.com with ESMTPSA id z12sm1649257eev.6.1969.12.31.16.00.00 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 30 Sep 2013 07:15:24 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, wsa@the-dreams.de Cc: Kedareswara rao Appana , Kedareswara rao Appana , Jean Delvare , Peter Korsgaard , linux-i2c@vger.kernel.org Subject: [PATCH v2 1/3] i2c: xilinx: Fix i2c checkpatch warnings Date: Mon, 30 Sep 2013 16:15:13 +0200 Message-Id: X-Mailer: git-send-email 1.8.2.3 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Kedareswara rao Appana Code changes to fix checkpatch warnings listed below. - WARNING: please, no space before tabs - WARNING: quoted string split across lines Signed-off-by: Kedareswara rao Appana Signed-off-by: Michal Simek --- Changes in v2: - It is checkpatch warnings not sparse - Extend patch description with checkpatch warnings Tested by: ./scripts/checkpatch.pl -f drivers/i2c/busses/i2c-xiic.c --- drivers/i2c/busses/i2c-xiic.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) -- 1.8.2.3 diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4c8b368..5eb0a8b 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -68,7 +68,7 @@ struct xiic_i2c { struct i2c_adapter adap; struct i2c_msg *tx_msg; spinlock_t lock; - unsigned int tx_pos; + unsigned int tx_pos; unsigned int nmsgs; enum xilinx_i2c_state state; struct i2c_msg *rx_msg; @@ -271,11 +271,8 @@ static void xiic_read_rx(struct xiic_i2c *i2c) bytes_in_fifo = xiic_getreg8(i2c, XIIC_RFO_REG_OFFSET) + 1; - dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d" - ", SR: 0x%x, CR: 0x%x\n", - __func__, bytes_in_fifo, xiic_rx_space(i2c), - xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), - xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); + dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d", + __func__, bytes_in_fifo, xiic_rx_space(i2c)); if (bytes_in_fifo > xiic_rx_space(i2c)) bytes_in_fifo = xiic_rx_space(i2c); @@ -339,9 +336,10 @@ static void xiic_process(struct xiic_i2c *i2c) ier = xiic_getreg32(i2c, XIIC_IIER_OFFSET); pend = isr & ier; - dev_dbg(i2c->adap.dev.parent, "%s entry, IER: 0x%x, ISR: 0x%x, " - "pend: 0x%x, SR: 0x%x, msg: %p, nmsgs: %d\n", - __func__, ier, isr, pend, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s: IER: 0x%x, ISR: 0x%x, pend: 0x%x\n", + __func__, ier, isr, pend); + dev_dbg(i2c->adap.dev.parent, "%s: SR: 0x%x, msg: %p, nmsgs: %d\n", + __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), i2c->tx_msg, i2c->nmsgs); /* Do not processes a devices interrupts if the device has no @@ -541,9 +539,10 @@ static void xiic_start_send(struct xiic_i2c *i2c) xiic_irq_clr(i2c, XIIC_INTR_TX_ERROR_MASK); - dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d, " - "ISR: 0x%x, CR: 0x%x\n", - __func__, msg, msg->len, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d", + __func__, msg, msg->len); + dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); if (!(msg->flags & I2C_M_NOSTART)) {