diff mbox series

media: ddbridge: Remove unused class-based I2C autoprobing code

Message ID 8b40e95a-6c4f-4109-afb3-615c6d1e0477@gmail.com
State Awaiting Upstream
Headers show
Series media: ddbridge: Remove unused class-based I2C autoprobing code | expand

Commit Message

Heiner Kallweit Jan. 26, 2024, 10:39 p.m. UTC 
The I2C_CLASS_TV_xxx constants don't exist in kernel code, seems like
this was copied from out-of-tree code. The supported I2C_CLASS_xxx
constants reside in include/linux/i2c.h.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/media/pci/ddbridge/ddbridge-i2c.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Wolfram Sang Jan. 27, 2024, 7:12 a.m. UTC | #1 
On Fri, Jan 26, 2024 at 11:39:58PM +0100, Heiner Kallweit wrote:
> The I2C_CLASS_TV_xxx constants don't exist in kernel code, seems like
> this was copied from out-of-tree code. The supported I2C_CLASS_xxx
> constants reside in include/linux/i2c.h.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
diff mbox series

Patch

diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c b/drivers/media/pci/ddbridge/ddbridge-i2c.c
index c894be180..2db65eab2 100644
--- a/drivers/media/pci/ddbridge/ddbridge-i2c.c
+++ b/drivers/media/pci/ddbridge/ddbridge-i2c.c
@@ -170,13 +170,6 @@  static int ddb_i2c_add(struct ddb *dev, struct ddb_i2c *i2c,
 
 	adap = &i2c->adap;
 	i2c_set_adapdata(adap, i2c);
-#ifdef I2C_ADAP_CLASS_TV_DIGITAL
-	adap->class = I2C_ADAP_CLASS_TV_DIGITAL | I2C_CLASS_TV_ANALOG;
-#else
-#ifdef I2C_CLASS_TV_ANALOG
-	adap->class = I2C_CLASS_TV_ANALOG;
-#endif
-#endif
 	snprintf(adap->name, I2C_NAME_SIZE, "ddbridge_%02x.%x.%x",
 		 dev->nr, i2c->link, i);
 	adap->algo = &ddb_i2c_algo;