| Message ID | 77b5ab8e-20f2-4310-bd89-57db99e2f53b@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | [net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list | expand |
On Sat, Jan 27, 2024 at 04:08:18PM +0100, Heiner Kallweit wrote: > Class-based I2C probing requires detect() and address_list to be > set in the I2C client driver, see checks in i2c_detect(). > It's misleading to declare I2C_CLASS_HWMON support if this > precondition isn't met. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> > --- > drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c > index 6b98c3287..f0ceb196a 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c > @@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = { > > static struct i2c_driver mlxsw_m_i2c_driver = { > .driver.name = "mlxsw_minimal", > - .class = I2C_CLASS_HWMON, > .id_table = mlxsw_m_i2c_id, > }; > > -- > 2.43.0 >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 27 Jan 2024 16:08:18 +0100 you wrote: > Class-based I2C probing requires detect() and address_list to be > set in the I2C client driver, see checks in i2c_detect(). > It's misleading to declare I2C_CLASS_HWMON support if this > precondition isn't met. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list https://git.kernel.org/netdev/net-next/c/ccf1445204a1 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c index 6b98c3287..f0ceb196a 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c @@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = { static struct i2c_driver mlxsw_m_i2c_driver = { .driver.name = "mlxsw_minimal", - .class = I2C_CLASS_HWMON, .id_table = mlxsw_m_i2c_id, };
Class-based I2C probing requires detect() and address_list to be set in the I2C client driver, see checks in i2c_detect(). It's misleading to declare I2C_CLASS_HWMON support if this precondition isn't met. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 - 1 file changed, 1 deletion(-)