| Message ID | 20240806125331.3170546-1-cuigaosheng1@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | [-next] i2c: qcom-geni: Add missing geni_icc_disable in geni_i2c_runtime_resume | expand |
On 8/6/24 15:53, Gaosheng Cui wrote: > Add the missing geni_icc_disable() before return in > geni_i2c_runtime_resume(). > > Fixes: bf225ed357c6 ("i2c: i2c-qcom-geni: Add interconnect support") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > drivers/i2c/busses/i2c-qcom-geni.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 8bc4040ba8be..2deaf502e6ff 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -992,6 +992,7 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) > ret = geni_se_resources_on(&gi2c->se); > if (ret) { > clk_disable_unprepare(gi2c->core_clk); > + geni_icc_disable(&gi2c->se); > return ret; > } > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
Hi Gaosheng, On Tue, Aug 06, 2024 at 08:53:31PM GMT, Gaosheng Cui wrote: > Add the missing geni_icc_disable() before return in > geni_i2c_runtime_resume(). > > Fixes: bf225ed357c6 ("i2c: i2c-qcom-geni: Add interconnect support") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> merged in i2c/i2c-host-fixes. Next time, for fixes patches, please do Cc also the stable mailing list <stable@vger.kernel.org>. Andi
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 8bc4040ba8be..2deaf502e6ff 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -992,6 +992,7 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) ret = geni_se_resources_on(&gi2c->se); if (ret) { clk_disable_unprepare(gi2c->core_clk); + geni_icc_disable(&gi2c->se); return ret; }
Add the missing geni_icc_disable() before return in geni_i2c_runtime_resume(). Fixes: bf225ed357c6 ("i2c: i2c-qcom-geni: Add interconnect support") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- drivers/i2c/busses/i2c-qcom-geni.c | 1 + 1 file changed, 1 insertion(+)