| Message ID | 20240711120818.46543-2-wsa+renesas@sang-engineering.com |
|---|---|
| State | Accepted |
| Delegated to: | Wolfram Sang |
| Headers | show |
| Series | i2c: testunit: avoid re-issued work after read message | expand |
On Thu, Jul 11, 2024 at 02:08:19PM GMT, Wolfram Sang wrote: > The to-be-fixed commit rightfully prevented that the registers will be > cleared. However, the index must be cleared. Otherwise a read message > will re-issue the last work. Fix it and add a comment describing the > situation. > > Fixes: c422b6a63024 ("i2c: testunit: don't erase registers after STOP") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
diff --git a/drivers/i2c/i2c-slave-testunit.c b/drivers/i2c/i2c-slave-testunit.c index ca43e98cae1b..23a11e4e9256 100644 --- a/drivers/i2c/i2c-slave-testunit.c +++ b/drivers/i2c/i2c-slave-testunit.c @@ -118,6 +118,13 @@ static int i2c_slave_testunit_slave_cb(struct i2c_client *client, queue_delayed_work(system_long_wq, &tu->worker, msecs_to_jiffies(10 * tu->regs[TU_REG_DELAY])); } + + /* + * Reset reg_idx to avoid that work gets queued again in case of + * STOP after a following read message. But do not clear TU regs + * here because we still need them in the workqueue! + */ + tu->reg_idx = 0; break; case I2C_SLAVE_WRITE_REQUESTED:
The to-be-fixed commit rightfully prevented that the registers will be cleared. However, the index must be cleared. Otherwise a read message will re-issue the last work. Fix it and add a comment describing the situation. Fixes: c422b6a63024 ("i2c: testunit: don't erase registers after STOP") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/i2c-slave-testunit.c | 7 +++++++ 1 file changed, 7 insertions(+)