| Message ID | 20240531111748.441a85b6@endymion.delvare |
|---|---|
| State | Accepted |
| Delegated to: | Andi Shyti |
| Headers | show |
| Series | i2c: designware: Fix the functionality flags of the slave-only interface | expand |
On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote: > When an I2C adapter acts only as a slave, it should not claim to > support I2C master capabilities. > > Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module") > Signed-off-by: Jean Delvare <jdelvare@suse.de> The below can be separated by --- to avoid noise in the commit messages. The effect, namely Cc'ing to people, will stay the same. > Cc: Luis Oliveira <lolivei@synopsys.com> > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Jan Dabros <jsd@semihalf.com> > Cc: Andi Shyti <andi.shyti@kernel.org> > --- Other than that, LGTM, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > drivers/i2c/busses/i2c-designware-slave.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-6.9.orig/drivers/i2c/busses/i2c-designware-slave.c > +++ linux-6.9/drivers/i2c/busses/i2c-designware-slave.c > @@ -220,7 +220,7 @@ static const struct i2c_algorithm i2c_dw > > void i2c_dw_configure_slave(struct dw_i2c_dev *dev) > { > - dev->functionality = I2C_FUNC_SLAVE | DW_IC_DEFAULT_FUNCTIONALITY; > + dev->functionality = I2C_FUNC_SLAVE; > > dev->slave_cfg = DW_IC_CON_RX_FIFO_FULL_HLD_CTRL | > DW_IC_CON_RESTART_EN | DW_IC_CON_STOP_DET_IFADDRESSED;
On Fri, 31 May 2024 12:23:26 +0300, Andy Shevchenko wrote: > On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote: > > When an I2C adapter acts only as a slave, it should not claim to > > support I2C master capabilities. > > > > Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module") > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > > The below can be separated by > > --- > > to avoid noise in the commit messages. The effect, namely Cc'ing to people, > will stay the same. Noted, I'll do that from now on. > > Cc: Luis Oliveira <lolivei@synopsys.com> BTW, the address above is no longer valid so it should be omitted when replying. > > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > > Cc: Jan Dabros <jsd@semihalf.com> > > Cc: Andi Shyti <andi.shyti@kernel.org> > > --- > > Other than that, LGTM, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks,
On 5/31/24 12:31 PM, Jean Delvare wrote: > On Fri, 31 May 2024 12:23:26 +0300, Andy Shevchenko wrote: >> On Fri, May 31, 2024 at 11:17:48AM +0200, Jean Delvare wrote: >>> When an I2C adapter acts only as a slave, it should not claim to >>> support I2C master capabilities. >>> >>> Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module") >>> Signed-off-by: Jean Delvare <jdelvare@suse.de> >> >> The below can be separated by >> >> --- >> >> to avoid noise in the commit messages. The effect, namely Cc'ing to people, >> will stay the same. > > Noted, I'll do that from now on. > >>> Cc: Luis Oliveira <lolivei@synopsys.com> > > BTW, the address above is no longer valid so it should be omitted when replying. > >>> Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> >>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> >>> Cc: Jan Dabros <jsd@semihalf.com> >>> Cc: Andi Shyti <andi.shyti@kernel.org> >>> --- >> >> Other than that, LGTM, >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Hi On Fri, 31 May 2024 11:17:48 +0200, Jean Delvare wrote: > When an I2C adapter acts only as a slave, it should not claim to > support I2C master capabilities. > > Applied to i2c/i2c-host-next on git://git.kernel.org/pub/scm/linux/kernel/git/local tree Thank you, Andi Patches applied =============== [1/1] i2c: designware: Fix the functionality flags of the slave-only interface commit: 9224b8546453758f73210256597f60f897f8dafe
--- linux-6.9.orig/drivers/i2c/busses/i2c-designware-slave.c +++ linux-6.9/drivers/i2c/busses/i2c-designware-slave.c @@ -220,7 +220,7 @@ static const struct i2c_algorithm i2c_dw void i2c_dw_configure_slave(struct dw_i2c_dev *dev) { - dev->functionality = I2C_FUNC_SLAVE | DW_IC_DEFAULT_FUNCTIONALITY; + dev->functionality = I2C_FUNC_SLAVE; dev->slave_cfg = DW_IC_CON_RX_FIFO_FULL_HLD_CTRL | DW_IC_CON_RESTART_EN | DW_IC_CON_STOP_DET_IFADDRESSED;
When an I2C adapter acts only as a slave, it should not claim to support I2C master capabilities. Fixes: 5b6d721b266a ("i2c: designware: enable SLAVE in platform module") Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Luis Oliveira <lolivei@synopsys.com> Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Jan Dabros <jsd@semihalf.com> Cc: Andi Shyti <andi.shyti@kernel.org> --- drivers/i2c/busses/i2c-designware-slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)