diff mbox series

[04/64] i2c: amd-mp2-pci: reword according to newest specification

Message ID 20240322132619.6389-5-wsa+renesas@sang-engineering.com
State Changes Requested
Headers show
Series i2c: reword i2c_algorithm according to newest specification | expand

Commit Message

Wolfram Sang March 22, 2024, 1:24 p.m. UTC 
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C
specifications and replace "master/slave" with more appropriate terms.
They are also more specific because we distinguish now between a remote
entity ("client") and a local one ("target").

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/busses/i2c-amd-mp2-pci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Andi Shyti March 26, 2024, 12:14 a.m. UTC | #1 
Hi Wolfram,

On Fri, Mar 22, 2024 at 02:24:57PM +0100, Wolfram Sang wrote:
> Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C
> specifications and replace "master/slave" with more appropriate terms.
> They are also more specific because we distinguish now between a remote
> entity ("client") and a local one ("target").
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c
index 143165300949..2ad0bb4661b4 100644
--- a/drivers/i2c/busses/i2c-amd-mp2-pci.c
+++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c
@@ -112,7 +112,7 @@  static void amd_mp2_pci_check_rw_event(struct amd_i2c_common *i2c_common)
 	struct amd_mp2_dev *privdata = i2c_common->mp2_dev;
 	struct pci_dev *pdev = privdata->pci_dev;
 	int len = i2c_common->eventval.r.length;
-	u32 slave_addr = i2c_common->eventval.r.slave_addr;
+	u32 client_addr = i2c_common->eventval.r.slave_addr;
 	bool err = false;
 
 	if (unlikely(len != i2c_common->msg->len)) {
@@ -121,9 +121,9 @@  static void amd_mp2_pci_check_rw_event(struct amd_i2c_common *i2c_common)
 		err = true;
 	}
 
-	if (unlikely(slave_addr != i2c_common->msg->addr)) {
-		pci_err(pdev, "unexpected slave address %x (expected: %x)!\n",
-			slave_addr, i2c_common->msg->addr);
+	if (unlikely(client_addr != i2c_common->msg->addr)) {
+		pci_err(pdev, "unexpected client address %x (expected: %x)!\n",
+			client_addr, i2c_common->msg->addr);
 		err = true;
 	}