| Message ID | 20240322132619.6389-23-wsa+renesas@sang-engineering.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | i2c: reword i2c_algorithm according to newest specification | expand |
Hi Wolfram, On Fri, Mar 22, 2024 at 02:25:15PM +0100, Wolfram Sang wrote: > Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C > specifications and replace "master/slave" with more appropriate terms. > They are also more specific because we distinguish now between a remote > entity ("client") and a local one ("target"). I'm just noticing... what do you mean with client/target? Can you please be a bit more specific? If I search through the three documents I find the word "client" written only once in the i3c document. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/i2c/busses/i2c-highlander.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c > index 7922bc917c33..ec3546a5178b 100644 > --- a/drivers/i2c/busses/i2c-highlander.c > +++ b/drivers/i2c/busses/i2c-highlander.c > @@ -331,7 +331,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, > /* Ensure we're in a sane state */ > highlander_i2c_done(dev); > > - /* Set slave address */ > + /* Set client address */ /client/target/ ? Andi
> I'm just noticing... what do you mean with client/target? Can you > please be a bit more specific? I described it somewhere (and Easwar mentioned it in another thread by now), but, yes, it needs to be better described. This will be also in my updates to the I2C docs.
Hi Wolfram, On Mon, Apr 08, 2024 at 11:07:20AM +0200, Wolfram Sang wrote: > > I'm just noticing... what do you mean with client/target? Can you > > please be a bit more specific? > > I described it somewhere (and Easwar mentioned it in another thread by > now), but, yes, it needs to be better described. This will be also in my > updates to the I2C docs. yes, I understood the difference between "client" and "target". The problem I see here is that this is not described in the specification (except for some pictures in the i3c, iirc). So that the change slave/client looks a bit arbitrary and I hear some people don't like it. That's why I need to know a bit more about the choice :-) Thanks, Andi
diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c index 7922bc917c33..ec3546a5178b 100644 --- a/drivers/i2c/busses/i2c-highlander.c +++ b/drivers/i2c/busses/i2c-highlander.c @@ -331,7 +331,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, /* Ensure we're in a sane state */ highlander_i2c_done(dev); - /* Set slave address */ + /* Set client address */ iowrite16((addr << 1) | read_write, dev->base + SMSMADR); highlander_i2c_command(dev, command, dev->buf_len);
Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C specifications and replace "master/slave" with more appropriate terms. They are also more specific because we distinguish now between a remote entity ("client") and a local one ("target"). Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-highlander.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)