[v2,09/12] i2c: designware: Get rid of redundant 'else'

Message ID	20231109182823.3531846-10-andriy.shevchenko@linux.intel.com
State	Superseded
Headers	show Return-Path: <linux-i2c-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Jarkko Nikula <jarkko.nikula@linux.intel.com>, Herbert Xu <herbert@gondor.apana.org.au>, Mario Limonciello <mario.limonciello@amd.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>, Hans de Goede <hdegoede@redhat.com> Subject: [PATCH v2 09/12] i2c: designware: Get rid of redundant 'else' Date: Thu, 9 Nov 2023 20:19:19 +0200 Message-ID: <20231109182823.3531846-10-andriy.shevchenko@linux.intel.com> In-Reply-To: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> References: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	i2c: designware: code consolidation & cleanups \| expand [v2,00/12] i2c: designware: code consolidation & cleanups [v2,01/12] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() [v2,02/12] i2c: designware: Always provide device ID tables [v2,03/12] i2c: designware: Drop return value from i2c_dw_acpi_configure() [v2,04/12] i2c: designware: Drop return value from dw_i2c_of_configure() [v2,05/12] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() [v2,06/12] i2c: designware: Consolidate firmware parsing and configuring code [v2,07/12] i2c: desingware: Unify the firmware type checks [v2,08/12] i2c: designware: Move exports to I2C_DW namespaces [v2,09/12] i2c: designware: Get rid of redundant 'else' [v2,10/12] i2c: designware: Fix spelling and other issues in the comments [v2,11/12] i2c: designware: Remove ->disable() callback [v2,12/12] i2c: designware: Consolidate PM ops

Message ID

20231109182823.3531846-10-andriy.shevchenko@linux.intel.com

State

Superseded

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Andi Shyti <andi.shyti@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH v2 09/12] i2c: designware: Get rid of redundant 'else'
Date: Thu,  9 Nov 2023 20:19:19 +0200
Message-ID: <20231109182823.3531846-10-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com>
References: <20231109182823.3531846-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

i2c: designware: code consolidation & cleanups | expand

Commit Message

Andy Shevchenko Nov. 9, 2023, 6:19 p.m. UTC

In the snippets like the following

	if (...)
		return / goto / break / continue ...;
	else
		...

the 'else' is redundant. Get rid of it.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index 50cf4cbfeff3..4d7dc346e619 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -638,10 +638,10 @@  int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev)
 
 	if (abort_source & DW_IC_TX_ARB_LOST)
 		return -EAGAIN;
-	else if (abort_source & DW_IC_TX_ABRT_GCALL_READ)
+	if (abort_source & DW_IC_TX_ABRT_GCALL_READ)
 		return -EINVAL; /* wrong msgs[] data */
-	else
-		return -EIO;
+
+	return -EIO;
 }
 
 int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev)

[v2,09/12] i2c: designware: Get rid of redundant 'else'

Commit Message

Patch