| Message ID | 20230724105546.1964059-3-carlos.song@nxp.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/3] i2c: imx-lpi2c: directly return ISR when detect a NACK | expand |
On Mon, Jul 24, 2023 at 7:52 AM <carlos.song@nxp.com> wrote: > > From: Gao Pan <pandy.gao@nxp.com> > > Output error log when i2c peripheral clk rate is 0, then > directly return -EINVAL. > > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver") > Signed-off-by: Gao Pan <pandy.gao@nxp.com> > Signed-off-by: Carlos Song <carlos.song@nxp.com> > --- > drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c > index e93ff3b5373c..12b4f2a89343 100644 > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx) > lpi2c_imx_set_mode(lpi2c_imx); > > clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk); > + if (!clk_rate) { > + dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n"); The subject says 'debug message', but this is an error message. Please adjust the Subject.
Thanks! I will adjust it and send V3 patch. > -----Original Message----- > From: Fabio Estevam <festevam@gmail.com> > Sent: Monday, July 24, 2023 8:38 PM > To: Carlos Song <carlos.song@nxp.com> > Cc: andi.shyti@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > Clark Wang <xiaoning.wang@nxp.com>; Bough Chen <haibo.chen@nxp.com>; > dl-linux-imx <linux-imx@nxp.com>; linux-i2c@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH v2 3/3] i2c: imx-lpi2c: add debug message when i2c > peripheral clk doesn't work > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report this > email' button > > > On Mon, Jul 24, 2023 at 7:52 AM <carlos.song@nxp.com> wrote: > > > > From: Gao Pan <pandy.gao@nxp.com> > > > > Output error log when i2c peripheral clk rate is 0, then directly > > return -EINVAL. > > > > Fixes: a55fa9d0e42e ("i2c: imx-lpi2c: add low power i2c bus driver") > > Signed-off-by: Gao Pan <pandy.gao@nxp.com> > > Signed-off-by: Carlos Song <carlos.song@nxp.com> > > --- > > drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c > > b/drivers/i2c/busses/i2c-imx-lpi2c.c > > index e93ff3b5373c..12b4f2a89343 100644 > > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > > @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct > *lpi2c_imx) > > lpi2c_imx_set_mode(lpi2c_imx); > > > > clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk); > > + if (!clk_rate) { > > + dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is > > + 0\n"); > > The subject says 'debug message', but this is an error message. > > Please adjust the Subject.
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c index e93ff3b5373c..12b4f2a89343 100644 --- a/drivers/i2c/busses/i2c-imx-lpi2c.c +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c @@ -214,6 +214,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx) lpi2c_imx_set_mode(lpi2c_imx); clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk); + if (!clk_rate) { + dev_err(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n"); + return -EINVAL; + } + if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) filt = 0; else