Message ID | 20200326211014.13591-2-wsa+renesas@sang-engineering.com |
---|---|
State | Awaiting Upstream |
Headers | show |
Series | ARM: convert to use new I2C API | expand |
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote: > Move away from the deprecated API and remove printing a stale 'ret' > value. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Thu, Mar 26, 2020 at 10:10:14PM +0100, Wolfram Sang wrote: > Move away from the deprecated API and remove printing a stale 'ret' > value. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++---- Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index 937d0a83f8fd..34f1baa10c54 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c @@ -405,10 +405,9 @@ static int wlf_gf_module_probe(struct i2c_client *i2c, gf_mods[i].name, rev + 1); for (j = 0; j < gf_mods[i].num_i2c_devs; j++) { - if (!i2c_new_device(i2c->adapter, - &(gf_mods[i].i2c_devs[j]))) - dev_err(&i2c->dev, - "Failed to register dev: %d\n", ret); + if (IS_ERR(i2c_new_client_device(i2c->adapter, + &(gf_mods[i].i2c_devs[j])))) + dev_err(&i2c->dev, "Failed to register\n"); } spi_register_board_info(gf_mods[i].spi_devs,
Move away from the deprecated API and remove printing a stale 'ret' value. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/mach-s3c64xx/mach-crag6410-module.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)