diff mbox series

i2c: i801: Documentation update

Message ID 20190704113402.3ade31cb@endymion
State Accepted
Headers show
Series i2c: i801: Documentation update | expand

Commit Message

Jean Delvare July 4, 2019, 9:34 a.m. UTC 
The i2c-i801 driver documentation needs some dusting:
* Mention disable_features flag 0x20.
* The i2c_ec driver has been removed from the kernel long ago. Driver
  i2c-scmi serves the same purpose for more recent hardware.
* Replace obsolete /proc paths with equivalent /sys paths.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Wolfram Sang <wsa@the-dreams.de>
---
 Documentation/i2c/busses/i2c-i801 |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Jarkko Nikula July 4, 2019, 1:44 p.m. UTC | #1 
On 7/4/19 12:34 PM, Jean Delvare wrote:
> The i2c-i801 driver documentation needs some dusting:
> * Mention disable_features flag 0x20.
> * The i2c_ec driver has been removed from the kernel long ago. Driver
>    i2c-scmi serves the same purpose for more recent hardware.
> * Replace obsolete /proc paths with equivalent /sys paths.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> ---
>   Documentation/i2c/busses/i2c-i801 |   16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Wolfram Sang July 5, 2019, 6:31 p.m. UTC | #2 
On Thu, Jul 04, 2019 at 11:34:02AM +0200, Jean Delvare wrote:
> The i2c-i801 driver documentation needs some dusting:
> * Mention disable_features flag 0x20.
> * The i2c_ec driver has been removed from the kernel long ago. Driver
>   i2c-scmi serves the same purpose for more recent hardware.
> * Replace obsolete /proc paths with equivalent /sys paths.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>

Applied to for-next, thanks!
diff mbox series

Patch

--- linux-5.1.orig/Documentation/i2c/busses/i2c-i801	2019-07-04 10:48:54.957325058 +0200
+++ linux-5.1/Documentation/i2c/busses/i2c-i801	2019-07-04 11:28:23.665334156 +0200
@@ -59,6 +59,7 @@  possible to work around possible driver
  0x02  disable the block buffer
  0x08  disable the I2C block read functionality
  0x10  don't use interrupts
+ 0x20  disable SMBus Host Notify
 
 
 Description
@@ -119,16 +120,15 @@  BIOS to enable it, it means it has been
 well known for first doing this on their P4B motherboard, and many other
 boards after that. Some vendor machines are affected as well.
 
-The first thing to try is the "i2c_ec" ACPI driver. It could be that the
+The first thing to try is the "i2c-scmi" ACPI driver. It could be that the
 SMBus was hidden on purpose because it'll be driven by ACPI. If the
-i2c_ec driver works for you, just forget about the i2c-i801 driver and
-don't try to unhide the ICH SMBus. Even if i2c_ec doesn't work, you
+i2c-scmi driver works for you, just forget about the i2c-i801 driver and
+don't try to unhide the ICH SMBus. Even if i2c-scmi doesn't work, you
 better make sure that the SMBus isn't used by the ACPI code. Try loading
-the "fan" and "thermal" drivers, and check in /proc/acpi/fan and
-/proc/acpi/thermal_zone. If you find anything there, it's likely that
-the ACPI is accessing the SMBus and it's safer not to unhide it. Only
-once you are certain that ACPI isn't using the SMBus, you can attempt
-to unhide it.
+the "fan" and "thermal" drivers, and check in /sys/class/thermal. If you
+find a thermal zone with type "acpitz", it's likely that the ACPI is
+accessing the SMBus and it's safer not to unhide it. Only once you are
+certain that ACPI isn't using the SMBus, you can attempt to unhide it.
 
 In order to unhide the SMBus, we need to change the value of a PCI
 register before the kernel enumerates the PCI devices. This is done in