From patchwork Fri Apr 8 07:59:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 607905 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qhBgv64F0z9t3q for ; Fri, 8 Apr 2016 17:59:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b=xZyoCNfb; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757655AbcDHH7i (ORCPT ); Fri, 8 Apr 2016 03:59:38 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33406 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757860AbcDHH7h (ORCPT ); Fri, 8 Apr 2016 03:59:37 -0400 Received: by mail-pf0-f196.google.com with SMTP id e190so8959533pfe.0 for ; Fri, 08 Apr 2016 00:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=g+K7gp4kiR3/igsd+M+On8pATIaXYFOdNiWWLHI3LeM=; b=xZyoCNfbWb6i/1N3VK7Hzb7U9I3b77Qq0Ygr8K1KU/WdKq/cLyiGlv4Eu9q+uhnPKQ 9JW1SYhivZ6ulgifF6KCWMARIj8lFqykUGTu2ebn0+pe/Jzz3FG9pHV8mFZ+geEM4hH9 GwgE0BDnAiUME3lRW00pivTysNzyPrql1j2YBHw/5b5wayI6FufkasN8LZTSc2iv5F61 KGYc1s9hKUSaCuKfzrwUZe/7OOWOpUoeuTbrY8xRoTlTIamf+JAflwzHJVdW93JyFDTc mYkYFK27Jez1MLMYKz4KfFI041/GMB8tMiORE2eor7qNsZH+EAETYsCn0laoumE/T+uy 02LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=g+K7gp4kiR3/igsd+M+On8pATIaXYFOdNiWWLHI3LeM=; b=YouMD+rE9Cf7ilyr6YFI6wPQtmf32IJ3dv9b405nXZQLGzUKPBGBwZq7FLPymK57Oq +VbTtKc3Ksa5eU+Ds11a7tMPq+2BV2ESZBrsdzZlCJFJSn0X2ogtoAxu89SntpoRUBj4 iG/DRlGfDdDF6L3mFHbO/butLELz+FGoRXKX7vjQV0kX97kB6iQVSZkYW9HcNviRSxTj Ac86qpKZcwba9NKW0dNnU7UYTEP0HknbZNjTIEPROOYOXKWrki7086TIndnV4SjmEWIB tEV9XBMFfKrFNazwMWNQY2SkGjoYcr+c2IayJVgoEFYjSq9QSUSJkOinLxk5Vggy/Ce4 EQ7w== X-Gm-Message-State: AD7BkJJ3VuITGT5sROPYEecDGML2iSF6W7uGE2K1+XZ9sRVB4B2nKlNVzKQgwKrrIEr09A== X-Received: by 10.98.68.71 with SMTP id r68mr10809349pfa.119.1460102376754; Fri, 08 Apr 2016 00:59:36 -0700 (PDT) Received: from phoenix (218-164-97-106.dynamic.hinet.net. [218.164.97.106]) by smtp.gmail.com with ESMTPSA id 17sm16812474pfp.96.2016.04.08.00.59.34 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Apr 2016 00:59:35 -0700 (PDT) Message-ID: <1460102372.5233.1.camel@ingics.com> Subject: [PATCH] i2c: jz4780: Return error if clk_freq is set to 0 From: Axel Lin To: Wolfram Sang Cc: Zubair Lutfullah Kakakhel , linux-i2c@vger.kernel.org Date: Fri, 08 Apr 2016 15:59:32 +0800 X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Current code returns 0 in probe if clk_freq is set to 0. As a result, the probe success but the module does not work. Fix it. Fixes: 34cf2acdafaa ("i2c: jz4780: prevent potential division by zero") Signed-off-by: Axel Lin --- drivers/i2c/busses/i2c-jz4780.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c index 597408f..0b3ba8d 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c @@ -772,6 +772,8 @@ static int jz4780_i2c_probe(struct platform_device *pdev) &clk_freq); if (ret || clk_freq == 0) { dev_err(&pdev->dev, "clock-frequency not specified in DT"); + if (ret == 0) + ret = -EINVAL; goto err; }