| Message ID | 1402319473-14993-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jun 09, 2014 at 03:11:13PM +0200, Linus Walleij wrote: > This driver causes the following randconfig build error: > > drivers/i2c/muxes/i2c-mux-pca954x.c: In function ‘pca954x_probe’: > drivers/i2c/muxes/i2c-mux-pca954x.c:204:2: error: implicit declaration > of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration] > gpio = devm_gpiod_get(&client->dev, "reset"); > ^ > drivers/i2c/muxes/i2c-mux-pca954x.c:204:7: warning: assignment makes > pointer from integer without a cast [enabled by default] > gpio = devm_gpiod_get(&client->dev, "reset"); > ^ > drivers/i2c/muxes/i2c-mux-pca954x.c:206:3: error: implicit declaration > of function ‘gpiod_direction_output’ > [-Werror=implicit-function-declaration] > gpiod_direction_output(gpio, 0); > ^ > cc1: some warnings being treated as errors > make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1 > > This is because it is getting compiled without gpiolib, so > introduce an explicit dependency. > > Reported-by: Jim Davis <jim.epost@gmail.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Applied to for-current, thanks!
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig index f7f9865b8b89..f6d313e528de 100644 --- a/drivers/i2c/muxes/Kconfig +++ b/drivers/i2c/muxes/Kconfig @@ -40,6 +40,7 @@ config I2C_MUX_PCA9541 config I2C_MUX_PCA954x tristate "Philips PCA954x I2C Mux/switches" + depends on GPIOLIB help If you say yes here you get support for the Philips PCA954x I2C mux/switch devices.
This driver causes the following randconfig build error: drivers/i2c/muxes/i2c-mux-pca954x.c: In function ‘pca954x_probe’: drivers/i2c/muxes/i2c-mux-pca954x.c:204:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration] gpio = devm_gpiod_get(&client->dev, "reset"); ^ drivers/i2c/muxes/i2c-mux-pca954x.c:204:7: warning: assignment makes pointer from integer without a cast [enabled by default] gpio = devm_gpiod_get(&client->dev, "reset"); ^ drivers/i2c/muxes/i2c-mux-pca954x.c:206:3: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration] gpiod_direction_output(gpio, 0); ^ cc1: some warnings being treated as errors make[3]: *** [drivers/i2c/muxes/i2c-mux-pca954x.o] Error 1 This is because it is getting compiled without gpiolib, so introduce an explicit dependency. Reported-by: Jim Davis <jim.epost@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/i2c/muxes/Kconfig | 1 + 1 file changed, 1 insertion(+)