mbox series

[0/2] Add missing icc_disable in exit path

Message ID 20240812194029.2222697-1-andi.shyti@kernel.org
Headers show
Series Add missing icc_disable in exit path | expand

Message

Andi Shyti Aug. 12, 2024, 7:40 p.m. UTC 
Hi,

Last week I committed the following patches from Gaosheng:

9ba48db9f77ce i2c: qcom-geni: Add missing geni_icc_disable in geni_i2c_runtime_resume
b93d16bee5573 i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runtime_resume

that wanted to add some cleanups in the geni_i2c_runtime_resume()
exit path. However, one case was overlooked. While addressing
this, I also replaced multiple return statements with a single
goto exit to improve code clarity and consistency.

I decided to keep the patches separate because the first patch
applies cleanly to the stable branch, whereas merging them into a
single patch would have created complications for backporting.

Thanks,
Andi

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

Andi Shyti (2):
  i2c: qcom-geni: Add missing geni_icc_disable in geni_i2c_runtime_resume
  i2c: qcom-geni: Use goto for clearer exit path

 drivers/i2c/busses/i2c-qcom-geni.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

Comments

Andi Shyti Aug. 13, 2024, 11:03 p.m. UTC | #1 
Hi,

> Andi Shyti (2):
>   i2c: qcom-geni: Add missing geni_icc_disable in geni_i2c_runtime_resume

Because this was a fix I merged it...

>   i2c: qcom-geni: Use goto for clearer exit path

... I leave this one for more comment opportunities.

Andi