mbox series

[0/2] i2c: rcar: use iopoll helpers for better timeout handling

Message ID 20200829203810.1467-1-wsa+renesas@sang-engineering.com
Headers show
Series i2c: rcar: use iopoll helpers for better timeout handling | expand

Message

Wolfram Sang Aug. 29, 2020, 8:38 p.m. UTC 
Originally, I noticed that the timeout value for initiating bus recovery
was not optimal. While fixing it, I took the chance to convert its
handling to the iopoll helpers. And then, I converted the timeout
handling for resetting the device, too, while I was at it.

Tested on a Renesas Lager board (H2) and Salvator-XS (M3-N).

Wolfram Sang (2):
  i2c: rcar: improve bus busy detection
  i2c: rcar: refactor and shorten timeout when resetting

 drivers/i2c/busses/i2c-rcar.c | 34 +++++++++++++---------------------
 1 file changed, 13 insertions(+), 21 deletions(-)

Comments

Niklas Söderlund Aug. 30, 2020, 8:30 a.m. UTC | #1 
Hi Wolfram,

Neat work, I learnt something new.

On 2020-08-29 22:38:08 +0200, Wolfram Sang wrote:
> Originally, I noticed that the timeout value for initiating bus recovery
> was not optimal. While fixing it, I took the chance to convert its
> handling to the iopoll helpers. And then, I converted the timeout
> handling for resetting the device, too, while I was at it.
> 
> Tested on a Renesas Lager board (H2) and Salvator-XS (M3-N).
> 
> Wolfram Sang (2):
>   i2c: rcar: improve bus busy detection
>   i2c: rcar: refactor and shorten timeout when resetting

For the whole series,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
>  drivers/i2c/busses/i2c-rcar.c | 34 +++++++++++++---------------------
>  1 file changed, 13 insertions(+), 21 deletions(-)
> 
> -- 
> 2.20.1
>