mbox series

[v4,0/3] i2c: mv64xxx: Fix clock resource for Armada 7K/8K

Message ID 20180116163540.1092-1-gregory.clement@free-electrons.com
Headers show
Series i2c: mv64xxx: Fix clock resource for Armada 7K/8K | expand

Message

Gregory CLEMENT Jan. 16, 2018, 4:35 p.m. UTC 
Hi,

This short series fixes the way the clocks are used for the mv64xxx
controller embedded in the Marvell Armada 7K/8K SoCs. On these SoCs a
second one is needed in order to clock the registers. It was not
noticed until now because we relied on the bootloader and also because
the clock driver was wrong.

Thanks to this fix, it would be possible to fix the clock driver
without introducing a regression.

The first patch is just a small cleanup found when I wrote the main
patch.

The last patch is not related to the series but as Wolfram to have a
maintainer for this driver I added the patch here.

Thanks,

Gregory

Changelog:
v1 -> v2:

 - Really add the binding documentation in the second patch, noticed
   by Thomas Petazzoni.

v2 -> v3:

 - Fix typo in binding documentation reported by Thomas	Petazzoni
 - Use correct name for the axi clock, reported by Thomas Petazzoni

v2 -> v4:

 - Use "reg" instead of "axi" as requested by Maxime Ripard
 - Reformulate the binding documentation, requested by Maxime Ripard
 - Add a maintainer for the i2c-mv64xxx driver, requested by Woflram
   Sang

Gregory CLEMENT (3):
  i2c: mv64xxx: Remove useless test before clk_disable_unprepare
  i2c: mv64xxx: Fix clock resource by adding an optional bus clock
  i2c: mv64xxx: Add myslef as maintainer for this driver

 .../devicetree/bindings/i2c/i2c-mv64xxx.txt          | 20 ++++++++++++++++++++
 MAINTAINERS                                          |  6 ++++++
 drivers/i2c/busses/i2c-mv64xxx.c                     | 20 +++++++++++++-------
 3 files changed, 39 insertions(+), 7 deletions(-)

Comments

Wolfram Sang Jan. 24, 2018, 6:35 a.m. UTC | #1 
On Tue, Jan 16, 2018 at 05:35:37PM +0100, Gregory CLEMENT wrote:

> This short series fixes the way the clocks are used for the mv64xxx
> controller embedded in the Marvell Armada 7K/8K SoCs. On these SoCs a
> second one is needed in order to clock the registers. It was not
> noticed until now because we relied on the bootloader and also because
> the clock driver was wrong.
> 
> Thanks to this fix, it would be possible to fix the clock driver
> without introducing a regression.
> 
> The first patch is just a small cleanup found when I wrote the main
> patch.
> 
> The last patch is not related to the series but as Wolfram to have a
> maintainer for this driver I added the patch here.

Thomas, Andrew, Maxime, any tags you'd like to donate?

>  - Add a maintainer for the i2c-mv64xxx driver, requested

Well, I'd say "asked for"...

> by Woflram Sang

... whoever that guy is ;)