| Message ID | bb6b85722d80d665779e3043d1499c4fc38f0ff3.1714562004.git.mirq-linux@rere.qmqm.pl |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: renesas/sh73a0: use rdev_get_drvdata() | expand |
Hi Michal, On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > Replace `reg_data` access with the official wrapper. The field is going > away soon. Thanks for your patch! > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404301218.URkWO6dj-lkp@intel.com/ I am not sure these tags are needed, as the issue is not present in any tree yet? > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Do you want me to pick this up (for v6.11), or do you want to queue this with the other patches from the series that removes reg_data? Please let me know. In case of the latter: Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
On Thu, May 02, 2024 at 09:56:39AM +0200, Geert Uytterhoeven wrote: > Hi Michal, > > On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > > Replace `reg_data` access with the official wrapper. The field is going > > away soon. > > Thanks for your patch! > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202404301218.URkWO6dj-lkp@intel.com/ > > I am not sure these tags are needed, as the issue is not present in > any tree yet? > > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Do you want me to pick this up (for v6.11), or do you want to queue > this with the other patches from the series that removes reg_data? > Please let me know. > In case of the latter: > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> If you're ok with it going through the regulator tree, then I guess it would be easier to manage as the series would build without observing additional dependencies. Best Regards Michał Mirosław
Hi Michał, On Thu, May 2, 2024 at 2:40 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > On Thu, May 02, 2024 at 09:56:39AM +0200, Geert Uytterhoeven wrote: > > On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > > > Replace `reg_data` access with the official wrapper. The field is going > > > away soon. > > > > Thanks for your patch! > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202404301218.URkWO6dj-lkp@intel.com/ > > > > I am not sure these tags are needed, as the issue is not present in > > any tree yet? > > > > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Do you want me to pick this up (for v6.11), or do you want to queue > > this with the other patches from the series that removes reg_data? > > Please let me know. > > In case of the latter: > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > If you're ok with it going through the regulator tree, then I guess it > would be easier to manage as the series would build without observing > additional dependencies. I was wondering how the rest of the series is doing? If you want me to queue this for v6.11, the deadline for that is this Friday. Thanks! Gr{oetje,eeting}s, Geert
On Mon, Jun 24, 2024 at 12:04 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, May 2, 2024 at 2:40 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > > On Thu, May 02, 2024 at 09:56:39AM +0200, Geert Uytterhoeven wrote: > > > On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote: > > > > Replace `reg_data` access with the official wrapper. The field is going > > > > away soon. > > > > > > Thanks for your patch! > > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > > > Closes: https://lore.kernel.org/oe-kbuild-all/202404301218.URkWO6dj-lkp@intel.com/ > > > > > > I am not sure these tags are needed, as the issue is not present in > > > any tree yet? > > > > > > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > Do you want me to pick this up (for v6.11), or do you want to queue > > > this with the other patches from the series that removes reg_data? > > > Please let me know. > > > In case of the latter: > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > If you're ok with it going through the regulator tree, then I guess it > > would be easier to manage as the series would build without observing > > additional dependencies. > > I was wondering how the rest of the series is doing? > > If you want me to queue this for v6.11, the deadline for that is > this Friday. I'm just gonna queue this in renesas-pinctrl for v6.11, as it's good to have anyway. Gr{oetje,eeting}s, Geert
diff --git a/drivers/pinctrl/renesas/pfc-sh73a0.c b/drivers/pinctrl/renesas/pfc-sh73a0.c index ca5adf2095be..41587233aa44 100644 --- a/drivers/pinctrl/renesas/pfc-sh73a0.c +++ b/drivers/pinctrl/renesas/pfc-sh73a0.c @@ -4024,7 +4024,7 @@ static const struct pinmux_irq pinmux_irqs[] = { static void sh73a0_vccq_mc0_endisable(struct regulator_dev *reg, bool enable) { - struct sh_pfc *pfc = reg->reg_data; + struct sh_pfc *pfc = rdev_get_drvdata(reg); void __iomem *addr = pfc->windows[1].virt + 4; unsigned long flags; u32 value; @@ -4057,7 +4057,7 @@ static int sh73a0_vccq_mc0_disable(struct regulator_dev *reg) static int sh73a0_vccq_mc0_is_enabled(struct regulator_dev *reg) { - struct sh_pfc *pfc = reg->reg_data; + struct sh_pfc *pfc = rdev_get_drvdata(reg); void __iomem *addr = pfc->windows[1].virt + 4; unsigned long flags; u32 value;
Replace `reg_data` access with the official wrapper. The field is going away soon. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404301218.URkWO6dj-lkp@intel.com/ Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/pinctrl/renesas/pfc-sh73a0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)