From patchwork Thu Jun 25 08:29:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 488312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 07DF31402DE for ; Thu, 25 Jun 2015 18:29:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751374AbbFYI33 (ORCPT ); Thu, 25 Jun 2015 04:29:29 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:33961 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbbFYI31 (ORCPT ); Thu, 25 Jun 2015 04:29:27 -0400 Received: by wgqq4 with SMTP id q4so55909653wgq.1 for ; Thu, 25 Jun 2015 01:29:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=yYn49jqXToOt/I5nMfF9pGkY8mRc4P+0qDLj4q+Mc1U=; b=Cevy95rZPItevjh1znTjFW67CpVIGU11Afoet6McPeuzi9ZH8teCYTNllSd5Hw1BhY BmdxIYZW0eaz91V0vs7u+amA6wVC1sw9HrLcIGaf31bbj6a/CW8USoLSPclf5HnzVk2D zkQAHrOQla/KUWog6xJnK6HGKxLJWrtLEWNs7jPXUgeQmgcYlVoCjyQn3ov6MzmSm0j7 KFbGyvJ604jM2ZnCC2KjOvpkYgM1jnidXTzSEEEVhhEVTLhcou7op/60u27C0Etkymab 55wH8ny11G2q/42S8fuIByqaUT6Xv7JyJYvT7wdXZFe6M13MAU05M8y9YuuAIZx64Iry 9EdA== X-Gm-Message-State: ALoCoQnskG2u1aAN4qxj7imCjwFlyT8ttR7EUrTnKqAgiony07NglJiFZ0HHwmvfvmjyxILep8oK X-Received: by 10.194.81.67 with SMTP id y3mr76396066wjx.7.1435220965580; Thu, 25 Jun 2015 01:29:25 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by mx.google.com with ESMTPSA id s10sm44606166wjy.35.2015.06.25.01.29.24 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 25 Jun 2015 01:29:24 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , Steffen Trumtrar , Linus Walleij , Peter Crosthwaite , linux-gpio@vger.kernel.org, Rob Herring , Alexandre Courbot , Josh Cartwright , linux-arm-kernel@lists.infradead.org Subject: [PATCH] gpio: zynq: Fix problem with unbalanced pm_runtime_enable Date: Thu, 25 Jun 2015 10:29:19 +0200 Message-Id: X-Mailer: git-send-email 2.3.5 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add missing pm_runtime_disabled to remove(). Error log: root@zynqmp:~# modprobe gpio_zynq root@zynqmp:~# lsmod Not tainted gpio_zynq 7086 0 - Live 0xffffffbffc00a000 root@zynqmp:~# rmmod gpio_zynq root@zynqmp:~# lsmod Not tainted root@zynqmp:~# modprobe gpio_zynq [ 246.924438] zynq-gpio ff0a0000.gpio: Unbalanced pm_runtime_enable! root@zynqmp:~# rmmod gpio_zynq root@zynqmp:~# lsmod Not tainted Signed-off-by: Michal Simek Reviewed-by: Alexandre Courbot --- drivers/gpio/gpio-zynq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 2e87c4b8da26..a78882389836 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -757,6 +757,7 @@ static int zynq_gpio_remove(struct platform_device *pdev) gpiochip_remove(&gpio->chip); clk_disable_unprepare(gpio->clk); device_set_wakeup_capable(&pdev->dev, 0); + pm_runtime_disable(&pdev->dev); return 0; }