| Message ID | b17a0414-8503-950e-a133-e5a1b1cab8c4@digi.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/6] pinctrl: ls1012a: Add pinctrl driver support | expand |
On Tue, 27 Aug 2024 12:15:08 +1000, David Leonard wrote: > > Add a binding schema and examples for the LS1046A's pinctrl function. > > Signed-off-by: David Leonard <David.Leonard@digi.com> > --- > .../bindings/pinctrl/fsl,ls1046a-pinctrl.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.example.dtb: pinmux@157040c: pinctrl-i2c3-gpio: {'groups': ['M3', 'N3'], 'function': ['gpio']} is not of type 'array' from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/b17a0414-8503-950e-a133-e5a1b1cab8c4@digi.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Aug 27, 2024 at 12:15:08PM +1000, David Leonard wrote: > Why do you keep sending emails one-by-one? Fix your threading. All previous comments apply. > Add a binding schema and examples for the LS1046A's pinctrl function. > > Signed-off-by: David Leonard <David.Leonard@digi.com> > --- > .../bindings/pinctrl/fsl,ls1046a-pinctrl.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml > new file mode 100644 > index 000000000000..3d49e42d33e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/fsl,ls1046a-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP QorIQ LS1046A pin multiplexing > + > +maintainers: > + - David.Leonard@digi.com > + > +description: > > + Bindings for LS1046A pinmux control. > + > +properties: > + compatible: > + const: fsl,ls1046a-pinctrl > + > + reg: > + description: > Drop >, actually entire description... insteasd list and describe the items. > + Specifies the base address of SCFG_RCWPMUXCR0 > + maxItems: 2 > + > + big-endian: > + description: > Drop > all other comments also apply. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml new file mode 100644 index 000000000000..3d49e42d33e8 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/fsl,ls1046a-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP QorIQ LS1046A pin multiplexing + +maintainers: + - David.Leonard@digi.com + +description: > + Bindings for LS1046A pinmux control. + +properties: + compatible: + const: fsl,ls1046a-pinctrl + + reg: + description: > + Specifies the base address of SCFG_RCWPMUXCR0 + maxItems: 2 + + big-endian: + description: > + If present, the register is implemented in big endian mode. + type: boolean + +patternProperties: + '^pinctrl-': + type: object + $ref: pinmux-node.yaml# + unevaluatedProperties: false + + properties: + function: + enum: [ i2c, gpio, evt, usb, ftm ] + + groups: + items: + enum: [ L4, M4, M3, N3 ] + +allOf: + - $ref: pinctrl.yaml# + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pinmux: pinmux@157040c { + compatible = "fsl,ls1046a-pinctrl"; + reg = <0 0x157040c 0 4>; + big-endian; + pinctrl_i2c2: pinctrl-i2c2 { + groups = "L4", "M4"; + function = "i2c"; + }; + pinctrl_i2c2_gpio: pinctrl-i2c2-gpio3 { + groups = "L4", "M4"; + function = "gpio"; + }; + pinctrl_i2c3: pinctrl-i2c3 { + groups = "M3", "N3"; + function = "i2c"; + }; + pinctrl_i2c3_gpio: pinctrl-i2c3-gpio { + groups = "M3", "N3"; + function = "gpio"; + }; + };
Add a binding schema and examples for the LS1046A's pinctrl function. Signed-off-by: David Leonard <David.Leonard@digi.com> --- .../bindings/pinctrl/fsl,ls1046a-pinctrl.yaml | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml