| Message ID | IA1PR20MB4953D5E7D7D68DDCE31C0031BBCF2@IA1PR20MB4953.namprd20.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties | expand |
On Thu, 20 Jun 2024 07:14:47 +0800, Inochi Amaoto wrote: > The "pinctrl-single,input-schmitt" have four arguments in the bindings > but the driver needs two. According to the meaning of other properties > and driver, it should have "enable" suffix. Fortunately, there is no > dts using this property, so it is safe to correct this property with the > right name. > > Rename existed property "pinctrl-single,input-schmitt" to > "pinctrl-single,input-schmitt-enable" and add the right description for > property "pinctrl-single,input-schmitt" used by the driver. > > Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml") > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > --- > .../devicetree/bindings/pinctrl/pinctrl-single.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On Thu, Jun 20, 2024 at 1:15 AM Inochi Amaoto <inochiama@outlook.com> wrote: > The "pinctrl-single,input-schmitt" have four arguments in the bindings > but the driver needs two. According to the meaning of other properties > and driver, it should have "enable" suffix. Fortunately, there is no > dts using this property, so it is safe to correct this property with the > right name. > > Rename existed property "pinctrl-single,input-schmitt" to > "pinctrl-single,input-schmitt-enable" and add the right description for > property "pinctrl-single,input-schmitt" used by the driver. > > Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml") > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml index c11495524dd2..e8177cc1115c 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml @@ -144,6 +144,13 @@ patternProperties: - description: drive strength mask pinctrl-single,input-schmitt: + description: Optional schmitt strength configuration + $ref: /schemas/types.yaml#/definitions/uint32-array + items: + - description: schmitt strength current + - description: schmitt strength mask + + pinctrl-single,input-schmitt-enable: description: Optional input schmitt configuration $ref: /schemas/types.yaml#/definitions/uint32-array items:
The "pinctrl-single,input-schmitt" have four arguments in the bindings but the driver needs two. According to the meaning of other properties and driver, it should have "enable" suffix. Fortunately, there is no dts using this property, so it is safe to correct this property with the right name. Rename existed property "pinctrl-single,input-schmitt" to "pinctrl-single,input-schmitt-enable" and add the right description for property "pinctrl-single,input-schmitt" used by the driver. Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml") Signed-off-by: Inochi Amaoto <inochiama@outlook.com> --- .../devicetree/bindings/pinctrl/pinctrl-single.yaml | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.45.2